linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Justin He <Justin.He@arm.com>
To: Dan Williams <dan.j.williams@intel.com>,
	Mike Rapoport <rppt@linux.ibm.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>,
	Will Deacon <will@kernel.org>,
	David Hildenbrand <david@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Vishal L Verma <vishal.l.verma@intel.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Linux MM <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>,
	Joao Martins <joao.m.martins@oracle.com>
Subject: RE: [PATCH v2 08/22] memblock: Introduce a generic phys_addr_to_target_node()
Date: Tue, 14 Jul 2020 01:36:50 +0000	[thread overview]
Message-ID: <AM6PR08MB40694ADECAF34D4A099A4E70F7610@AM6PR08MB4069.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAPcyv4iRJRz==VRgq=M_FYz0TfNKqKASOD1+NRfMLcHzEOBApQ@mail.gmail.com>

Hi Dan

> -----Original Message-----
> From: Dan Williams <dan.j.williams@intel.com>
> Sent: Monday, July 13, 2020 11:48 PM
> To: Mike Rapoport <rppt@linux.ibm.com>
> Cc: linux-nvdimm <linux-nvdimm@lists.01.org>; Justin He
> <Justin.He@arm.com>; Will Deacon <will@kernel.org>; David Hildenbrand
> <david@redhat.com>; Andrew Morton <akpm@linux-foundation.org>; Peter
> Zijlstra <peterz@infradead.org>; Vishal L Verma <vishal.l.verma@intel.com>;
> Dave Hansen <dave.hansen@linux.intel.com>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>; Linux MM <linux-mm@kvack.org>; Linux Kernel
> Mailing List <linux-kernel@vger.kernel.org>; Linux ACPI <linux-
> acpi@vger.kernel.org>; Christoph Hellwig <hch@lst.de>; Joao Martins
> <joao.m.martins@oracle.com>
> Subject: Re: [PATCH v2 08/22] memblock: Introduce a generic
> phys_addr_to_target_node()
>
> On Mon, Jul 13, 2020 at 12:04 AM Mike Rapoport <rppt@linux.ibm.com> wrote:
> >
> > Hi Dan,
> >
> > On Sun, Jul 12, 2020 at 09:26:48AM -0700, Dan Williams wrote:
> > > Similar to how generic memory_add_physaddr_to_nid() interrogates
> > > memblock data for numa information, introduce
> > > get_reserved_pfn_range_from_nid() to enable the same operation for
> > > reserved memory ranges. Example memory ranges that are reserved, but
> > > still have associated numa-info are persistent memory or Soft Reserved
> > > (EFI_MEMORY_SP) memory.
> >
> > Here again, I would prefer to add a weak default for
> > phys_to_target_node() because the "generic" implementation is not really
> > generic.
> >
> > The fallback to reserved ranges is x86 specfic because on x86 most of
> the
> > reserved areas is not in memblock.memory. AFAIK, no other architecture
> > does this.
>
> True, I was pre-fetching ARM using the new EFI "Special Purpose"
> memory attribute. However, until that becomes something that platforms
> deploy in practice I'm ok with not solving that problem for now.
>
> > And x86 anyway has implementation of phys_to_target_node().
>
> Sure, let's go with the default stub for non-x86.
>
> Justin, do you think it would make sense to fold your dax_kmem
> enabling for arm64 series into my enabling of dax_hmem for all
> memory-hotplug archs?

It is ok with me, thanks for the folding 😊

--
Cheers,
Justin (Jia He)



IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

  reply	other threads:[~2020-07-14  1:37 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-12 16:26 [PATCH v2 00/22] device-dax: Support sub-dividing soft-reserved ranges Dan Williams
2020-07-12 16:26 ` [PATCH v2 01/22] x86/numa: Cleanup configuration dependent command-line options Dan Williams
2020-07-12 16:26 ` [PATCH v2 02/22] x86/numa: Add 'nohmat' option Dan Williams
2020-07-12 16:58   ` Randy Dunlap
2020-07-12 16:26 ` [PATCH v2 03/22] efi/fake_mem: Arrange for a resource entry per efi_fake_mem instance Dan Williams
2020-07-12 16:26 ` [PATCH v2 04/22] ACPI: HMAT: Refactor hmat_register_target_device to hmem_register_device Dan Williams
2020-07-12 16:26 ` [PATCH v2 05/22] resource: Report parent to walk_iomem_res_desc() callback Dan Williams
2020-07-12 16:26 ` [PATCH v2 06/22] x86: Move NUMA_KEEP_MEMINFO and related definition to x86-internals Dan Williams
2020-07-12 16:26 ` [PATCH v2 07/22] numa: Introduce a generic memory_add_physaddr_to_nid() Dan Williams
2020-07-13  6:58   ` Mike Rapoport
2020-07-13 15:42     ` Dan Williams
2020-07-12 16:26 ` [PATCH v2 08/22] memblock: Introduce a generic phys_addr_to_target_node() Dan Williams
2020-07-13  7:03   ` Mike Rapoport
2020-07-13 15:48     ` Dan Williams
2020-07-14  1:36       ` Justin He [this message]
2020-07-12 16:26 ` [PATCH v2 09/22] arm64: Convert to generic memblock for numa-info Dan Williams
2020-07-12 16:26 ` [PATCH v2 10/22] ACPI: HMAT: Attach a device for each soft-reserved range Dan Williams
2020-07-12 16:27 ` [PATCH v2 11/22] device-dax: Drop the dax_region.pfn_flags attribute Dan Williams
2020-07-12 16:27 ` [PATCH v2 12/22] device-dax: Move instance creation parameters to 'struct dev_dax_data' Dan Williams
2020-07-12 16:27 ` [PATCH v2 13/22] device-dax: Make pgmap optional for instance creation Dan Williams
2020-07-12 16:27 ` [PATCH v2 14/22] device-dax: Kill dax_kmem_res Dan Williams
2020-07-12 16:27 ` [PATCH v2 15/22] device-dax: Add an allocation interface for device-dax instances Dan Williams
2020-07-12 16:27 ` [PATCH v2 16/22] device-dax: Introduce 'seed' devices Dan Williams
2020-07-12 16:27 ` [PATCH v2 17/22] drivers/base: Make device_find_child_by_name() compatible with sysfs inputs Dan Williams
2020-07-12 17:09   ` Greg Kroah-Hartman
2020-07-13 15:39     ` Dan Williams
2020-07-13 15:52       ` Greg Kroah-Hartman
2020-07-13 16:09         ` Dan Williams
2020-07-13 16:12           ` Greg Kroah-Hartman
2020-07-13 16:36             ` Dan Williams
2020-07-12 16:27 ` [PATCH v2 18/22] device-dax: Add resize support Dan Williams
2020-07-12 16:27 ` [PATCH v2 19/22] mm/memremap_pages: Convert to 'struct range' Dan Williams
2020-07-13 16:36   ` Ralph Campbell
2020-07-13 16:54     ` Dan Williams
2020-07-12 16:27 ` [PATCH v2 20/22] mm/memremap_pages: Support multiple ranges per invocation Dan Williams
2020-07-12 16:27 ` [PATCH v2 21/22] device-dax: Add dis-contiguous resource support Dan Williams
2020-07-12 16:28 ` [PATCH v2 22/22] device-dax: Introduce 'mapping' devices Dan Williams
2020-07-16 13:18   ` Joao Martins
2020-07-16 16:00     ` Dan Williams
2020-07-16 19:04       ` Joao Martins
2020-07-16 17:29 ` [PATCH v1 0/4] device-dax: Further improvements to subdivision Joao Martins
2020-07-16 17:29   ` [PATCH v1 1/4] device-dax: Make align a per-device property Joao Martins
2020-07-16 17:29   ` [PATCH v1 2/4] device-dax: Add an 'align' attribute Joao Martins
2020-07-31 14:52     ` Dan Williams
2020-07-16 17:29   ` [PATCH v1 3/4] dax/hmem: Introduce dax_hmem.region_idle parameter Joao Martins
2020-07-16 17:29   ` [PATCH v1 4/4] device-dax: Add a range mapping allocation attribute Joao Martins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR08MB40694ADECAF34D4A099A4E70F7610@AM6PR08MB4069.eurprd08.prod.outlook.com \
    --to=justin.he@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@redhat.com \
    --cc=hch@lst.de \
    --cc=joao.m.martins@oracle.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=peterz@infradead.org \
    --cc=rppt@linux.ibm.com \
    --cc=vishal.l.verma@intel.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).