From: "Zi Yan" <zi.yan@sent.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: kirill.shutemov@linux.intel.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, akpm@linux-foundation.org,
minchan@kernel.org, vbabka@suse.cz, mgorman@techsingularity.net,
mhocko@kernel.org, khandual@linux.vnet.ibm.com,
dnellans@nvidia.com, dave.hansen@intel.com,
n-horiguchi@ah.jp.nec.com
Subject: Re: [PATCH v8 05/10] mm: thp: enable thp migration in generic path
Date: Sun, 02 Jul 2017 21:26:48 -0400 [thread overview]
Message-ID: <C4F49980-32D7-4888-A5BE-7B0B1977AACC@sent.com> (raw)
In-Reply-To: <20170702175732.okngzb6y6gwxrpdo@node.shutemov.name>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
On 2 Jul 2017, at 13:57, Kirill A. Shutemov wrote:
> On Sat, Jul 01, 2017 at 09:40:03AM -0400, Zi Yan wrote:
>> --- a/mm/rmap.c
>> +++ b/mm/rmap.c
>> @@ -1302,6 +1302,7 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
>> bool ret = true;
>> enum ttu_flags flags = (enum ttu_flags)arg;
>>
>> +
>> /* munlock has nothing to gain from examining un-locked vmas */
>> if ((flags & TTU_MUNLOCK) && !(vma->vm_flags & VM_LOCKED))
>> return true;
>
> With exception of this useless hunk, looks good to me
>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>
Thanks.
BTW, is this Acked-by for Patch 5 or both Path 5 and 6?
--
Best Regards
Yan Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 496 bytes --]
next prev parent reply other threads:[~2017-07-03 1:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-01 13:39 [PATCH v8 00/10] mm: page migration enhancement for thp Zi Yan
2017-07-01 13:39 ` [PATCH v8 01/10] mm: mempolicy: add queue_pages_required() Zi Yan
2017-07-01 13:40 ` [PATCH v8 02/10] mm: x86: move _PAGE_SWP_SOFT_DIRTY from bit 7 to bit 1 Zi Yan
2017-07-01 13:40 ` [PATCH v8 03/10] mm: thp: introduce separate TTU flag for thp freezing Zi Yan
2017-07-01 13:40 ` [PATCH v8 04/10] mm: thp: introduce CONFIG_ARCH_ENABLE_THP_MIGRATION Zi Yan
2017-07-01 13:40 ` [PATCH v8 05/10] mm: thp: enable thp migration in generic path Zi Yan
2017-07-02 17:57 ` Kirill A. Shutemov
2017-07-03 1:26 ` Zi Yan [this message]
2017-07-11 6:47 ` Naoya Horiguchi
2017-07-11 14:00 ` Zi Yan
2017-07-13 9:30 ` Naoya Horiguchi
2017-07-13 11:28 ` Zi Yan
2017-07-14 0:06 ` Naoya Horiguchi
2017-07-01 13:40 ` [PATCH v8 06/10] mm: thp: check pmd migration entry in common path Zi Yan
2017-07-14 9:29 ` Naoya Horiguchi
2017-07-14 18:29 ` Zi Yan
2017-07-01 13:40 ` [PATCH v8 07/10] mm: soft-dirty: keep soft-dirty bits over thp migration Zi Yan
2017-07-01 13:40 ` [PATCH v8 08/10] mm: mempolicy: mbind and migrate_pages support " Zi Yan
2017-07-01 13:40 ` [PATCH v8 09/10] mm: migrate: move_pages() supports " Zi Yan
2017-07-01 13:40 ` [PATCH v8 10/10] mm: memory_hotplug: memory hotremove " Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C4F49980-32D7-4888-A5BE-7B0B1977AACC@sent.com \
--to=zi.yan@sent.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=dnellans@nvidia.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).