From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3255C2BA19 for ; Thu, 16 Apr 2020 01:30:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A34522076D for ; Thu, 16 Apr 2020 01:30:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iQ/+6uUC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A34522076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3F0B18E0069; Wed, 15 Apr 2020 21:30:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 379828E0001; Wed, 15 Apr 2020 21:30:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 269608E0069; Wed, 15 Apr 2020 21:30:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id 0B9038E0001 for ; Wed, 15 Apr 2020 21:30:18 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B2819824556B for ; Thu, 16 Apr 2020 01:30:17 +0000 (UTC) X-FDA: 76711987674.15.grade00_59d7adb0faa39 X-HE-Tag: grade00_59d7adb0faa39 X-Filterd-Recvd-Size: 4467 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Apr 2020 01:30:17 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id j3so5552742ljg.8 for ; Wed, 15 Apr 2020 18:30:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o8xFtf2O/rL/WIr7oyJJuxQp2aXJgl2Dd99kFiXV1KM=; b=iQ/+6uUCtwZyZ//JZbSuMrVBoG/GZ+Ft7Oh2SIRBGKS5hDeftNDSiNz7IpIBW6QS9D vn3TCpvcsHORaxFOWrL3OqWKA1eMM50ueicfcEgsESuml6duhm3MmYPGLsoWG3qzRXkT y+wvTrZqfTXqeEPT+pOGEmJDwCU1sdIJT6Hz92lEZu5oPNbESXZJjp1MpHfsTbZfdakc HHVj2UMQi1sPAsGK/t/crNDl38nfWZ7cWoOi7UveAnPKioPit4TvDe8FqKCxxHrvGHjM FhU4/kmt0i1K9E3XSp5glB64T15x+kKnz0X57HmxN9/ng2us9lyD8Bg17kwTFWMBKqVQ hFiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o8xFtf2O/rL/WIr7oyJJuxQp2aXJgl2Dd99kFiXV1KM=; b=EzXwoE9B7gH8Sb6NA4UCcs0H7FJ/KamcFvPzUclaluc3Q5wbbkh4GO8vHS1cAQeh0j gC/Q5onImCs3RJ1lKlpYSWzkA2GMgelx0OnT9KszLVP6LNsKxQ2mOPOALrDGJRL85dQ/ B1U2maT8Td87Sl7HZdYvBonETV8UW9nLvE/QIcT4tZX85Ha/EK9M0t3NYPBDRFmm0/dL vZ+j/0PuujWDgUfh2WGDQDypzzNMGdQQyj8bSMBEMptWEFpUlEbshacd9ErWIDTLU+N1 NHZpHp20OrRRAIYrWCBbDKd2RO9TGUMnbl1KQ3ltCf1OPXcB9cXwONEgZJCeU45H9SDX iGnQ== X-Gm-Message-State: AGi0PuZAZoQ6wnrXFH/OuwTnvK/O/xjzQQ4kyd79GIziBaFl1KauNhkp N0wyi9116BQplHF3D1kHK09yX5fImHXjGVmY1iM= X-Google-Smtp-Source: APiQypJCxdBT41q9hezBo1+xLbB9VsfBygbJ6hE/4CS5ylv1NnFddxHOcliaLALk9a+tsO0Yrrm8xTBV1OwgUnWU3Lo= X-Received: by 2002:a2e:7807:: with SMTP id t7mr4918437ljc.203.1587000615751; Wed, 15 Apr 2020 18:30:15 -0700 (PDT) MIME-Version: 1.0 References: <20200412090919.GA19580@open-light-1.localdomain> <64985d09-d11e-5fc0-64b0-b56ef514448a@linux.intel.com> In-Reply-To: <64985d09-d11e-5fc0-64b0-b56ef514448a@linux.intel.com> From: Liang Li Date: Thu, 16 Apr 2020 09:30:04 +0800 Message-ID: Subject: Re: [RFC PATCH 3/4] mm: add sys fs configuration for page reporting To: Alexander Duyck Cc: Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrea Arcangeli , Dan Williams , Dave Hansen , David Hildenbrand , Michal Hocko , Andrew Morton , Alex Williamson Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 13, 2020 at 11:02 PM Alexander Duyck wrote: > > On 4/12/2020 2:09 AM, liliangleo wrote: > > This patch add 'delay_millisecs', 'mini_order', 'batch_size', > > in '/sys/kernel/mm/page_report/'. Usage: > > > > "delay_millisecs": > > Time delay interval between page free and work start to run. > > > > "mini_order": > > Only pages with order equal or greater than mini_order will be > > reported. > > > > "batch_size" > > Wake up the worker only when free pages total size are greater > > than 'batch_size'. > > > > Cc: Alexander Duyck > > Cc: Mel Gorman > > Cc: Andrea Arcangeli > > Cc: Dan Williams > > Cc: Dave Hansen > > Cc: David Hildenbrand > > Cc: Michal Hocko > > Cc: Andrew Morton > > Cc: Alex Williamson > > Signed-off-by: liliangleo > > I am not really a fan of making these configurable globally. Especially > since the existing virtio-balloon is relying on some of this being > configured the way it is. > > It would make much more sense to push these configuration options out to > the registration interface so that the thing that is registering for > page reporting can configure them when it is registered. > Agree, that's better. Thanks!