From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 004B5C433E7 for ; Wed, 2 Sep 2020 12:54:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B5C3C206F0 for ; Wed, 2 Sep 2020 12:54:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="HVouhgUe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5C3C206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6995D8E0001; Wed, 2 Sep 2020 08:54:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 649DB6B006E; Wed, 2 Sep 2020 08:54:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 512698E0001; Wed, 2 Sep 2020 08:54:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 3929B6B0062 for ; Wed, 2 Sep 2020 08:54:27 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E4B33181AEF09 for ; Wed, 2 Sep 2020 12:54:26 +0000 (UTC) X-FDA: 77218114932.15.jeans67_4416b1a270a1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id A26BE1814B0C8 for ; Wed, 2 Sep 2020 12:54:26 +0000 (UTC) X-HE-Tag: jeans67_4416b1a270a1 X-Filterd-Recvd-Size: 4483 Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Sep 2020 12:54:26 +0000 (UTC) Received: by mail-ed1-f67.google.com with SMTP id g4so499310edk.0 for ; Wed, 02 Sep 2020 05:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jguf1LcpzdLbnb6m9J0BP0vWI/LKfE1Jts6BiXQTOXA=; b=HVouhgUe0h/dT/d25fmAt8+AdYkGMgTHsNTj5v0ofRuKkDS632pxM+ScRs+0Hy3nLB DQg3t5tY2PHuwD4M3USyJMU5+lCGOBjBvWIRfCYDvR1uXAoRV/weUz2gSAW/YzaPNURa bdfxgPpU+zKvGI07WPyDNuiDG/hb9hQI2afHwcrREBe+XMU2rqLo+5ZmdyRNMNgtNnAq bemfPQgUfLIOfyN9sCqvTNSP6TbOhP7odrcAnsvG82RdBk1oU7lD2QZd7LfgMPMz485Z Vgnwbx9hyLy6RbBIBo2AtdkOVIvPpzojlLk71ifI/7XXL+r1pLdsrmvR7tu76psXNaoT 1e8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jguf1LcpzdLbnb6m9J0BP0vWI/LKfE1Jts6BiXQTOXA=; b=SqY9+7GafYNZuN+Z3lp69udDKsBsjD/5HQ6s9kLj6sO9l1yj3CmrYMQnJws8QZdNB7 PvrA7EsKCDcbqGz+ZmBSU/+okCGc0p9bUJpJFPBGVMWf9bnF8VcwG/6X2OBXZWmFUOop pcEMYzyJIvjK5qBd7UreVvbVtIf4+tuY+TIjvEKgKsOV7FUqKtz+uYugL87++goJGM63 NwARvB9fgAd8WkQS9Wb56I8Zne5uhf6PNojI2IeRHQ1Dw5Gy6+u+ZPwByFoBBIckFvYh 1UWG7ogH3WY27wvvQNjie0cC0AjNrALBrvFmpc/N0MlXDJ8931c0idg2OghVmoK/vJbJ aM5w== X-Gm-Message-State: AOAM533OK00AsuT64hN/QBWxnBxFLHwNh0VyuP4bizoJa6Afs0CxQD5T nlDUwZhmnil8RtxhAEXV98Vd6OpExh0nk5hDMIcuug== X-Google-Smtp-Source: ABdhPJyaN78gS/ZUa0KTrLX84zGJiMFwqPH7s7EsAhv3YTCXunsjJ0gi6JjMwMbqDGXOC126EP7OpX0Pk8dwY/z8JZ4= X-Received: by 2002:a05:6402:1d0f:: with SMTP id dg15mr6629378edb.342.1599051265010; Wed, 02 Sep 2020 05:54:25 -0700 (PDT) MIME-Version: 1.0 References: <20200127173453.2089565-1-guro@fb.com> <20200130020626.GA21973@in.ibm.com> <20200130024135.GA14994@xps.DHCP.thefacebook.com> <20200813000416.GA1592467@carbon.dhcp.thefacebook.com> <6469324e-afa2-18b4-81fb-9e96466c1bf3@suse.cz> <20200902113204.GD4617@dhcp22.suse.cz> In-Reply-To: <20200902113204.GD4617@dhcp22.suse.cz> From: Pavel Tatashin Date: Wed, 2 Sep 2020 08:53:49 -0400 Message-ID: Subject: Re: [PATCH v2 00/28] The new cgroup slab memory controller To: Michal Hocko Cc: Vlastimil Babka , Roman Gushchin , Bharata B Rao , "linux-mm@kvack.org" , Andrew Morton , Johannes Weiner , Shakeel Butt , Vladimir Davydov , "linux-kernel@vger.kernel.org" , Kernel Team , Yafang Shao , stable , Linus Torvalds , Sasha Levin , Greg Kroah-Hartman , David Hildenbrand Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: A26BE1814B0C8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 2, 2020 at 7:32 AM Michal Hocko wrote: > > On Wed 02-09-20 11:53:00, Vlastimil Babka wrote: > > >> > > Thread #2: ccs killer kthread > > >> > > css_killed_work_fn > > >> > > cgroup_mutex <- Grab this Mutex > > >> > > mem_cgroup_css_offline > > >> > > memcg_offline_kmem.part > > >> > > memcg_deactivate_kmem_caches > > >> > > get_online_mems > > >> > > mem_hotplug_lock <- waits for Thread#1 to get read access > > And one more thing. THis has been brought up several times already. > Maybe I have forgoten but why do we take hotplug locks in this path in > the first place? Memory hotplug notifier takes slab_mutex so this > shouldn't be really needed. Good point, it seems this lock can be completely removed from memcg_deactivate_kmem_caches Pasha > -- > Michal Hocko > SUSE Labs