From: Pavel Tatashin <pasha.tatashin@soleen.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "James Morris" <jmorris@namei.org>,
"Sasha Levin" <sashal@kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux MM" <linux-mm@kvack.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Michal Hocko" <mhocko@suse.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Keith Busch" <keith.busch@intel.com>,
"Vishal L Verma" <vishal.l.verma@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Ross Zwisler" <zwisler@kernel.org>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Huang, Ying" <ying.huang@intel.com>,
"Fengguang Wu" <fengguang.wu@intel.com>,
"Borislav Petkov" <bp@suse.de>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Yaowei Bai" <baiyaowei@cmss.chinamobile.com>,
"Takashi Iwai" <tiwai@suse.de>,
"Jérôme Glisse" <jglisse@redhat.com>,
"David Hildenbrand" <david@redhat.com>
Subject: Re: [v4 2/2] device-dax: "Hotremove" persistent memory that is used like normal RAM
Date: Thu, 2 May 2019 12:47:52 -0400 [thread overview]
Message-ID: <CA+CK2bB3G_tO04M1eXPdm4b=OojD6QpYkW51YArj6z44RhQo+g@mail.gmail.com> (raw)
In-Reply-To: <CAPcyv4iPzpP-gzuDtPB2ixd6_uTuO8-YdVSfGw_Dq=igaKuOEg@mail.gmail.com>
> Currently the kmem driver can be built as a module, and I don't see a
> need to drop that flexibility. What about wrapping these core
> routines:
>
> unlock_device_hotplug
> __remove_memory
> walk_memory_range
> lock_device_hotplug
>
> ...into a common exported (gpl) helper like:
>
> int try_remove_memory(int nid, struct resource *res)
>
> Because as far as I can see there's nothing device-dax specific about
> this "try remove iff offline" functionality outside of looking up the
> related 'struct resource'. The check_devdax_mem_offlined_cb callback
> can be made generic if the callback argument is the resource pointer.
Makes sense, I will do both things that you suggested.
Thank you,
Pasha
next prev parent reply other threads:[~2019-05-02 16:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 19:18 [v4 0/2] "Hotremove" persistent memory Pavel Tatashin
2019-05-01 19:18 ` [v4 1/2] device-dax: fix memory and resource leak if hotplug fails Pavel Tatashin
2019-05-01 19:18 ` [v4 2/2] device-dax: "Hotremove" persistent memory that is used like normal RAM Pavel Tatashin
2019-05-02 14:14 ` David Hildenbrand
2019-05-02 14:16 ` Pavel Tatashin
2019-05-02 15:54 ` Dan Williams
2019-05-02 16:47 ` Pavel Tatashin [this message]
2019-05-02 17:34 ` Sasha Levin
2019-05-02 17:44 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+CK2bB3G_tO04M1eXPdm4b=OojD6QpYkW51YArj6z44RhQo+g@mail.gmail.com' \
--to=pasha.tatashin@soleen.com \
--cc=akpm@linux-foundation.org \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=jglisse@redhat.com \
--cc=jmorris@namei.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mhocko@suse.com \
--cc=sashal@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=tiwai@suse.de \
--cc=vishal.l.verma@intel.com \
--cc=ying.huang@intel.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).