From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6084C433DB for ; Mon, 25 Jan 2021 19:08:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 56E4A2067B for ; Mon, 25 Jan 2021 19:08:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56E4A2067B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D66796B0095; Mon, 25 Jan 2021 14:08:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CEF368D001B; Mon, 25 Jan 2021 14:08:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDD778D0001; Mon, 25 Jan 2021 14:08:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id A4E026B0095 for ; Mon, 25 Jan 2021 14:08:17 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 61B4A181AEF3F for ; Mon, 25 Jan 2021 19:08:17 +0000 (UTC) X-FDA: 77745233034.11.cast01_550b08a27588 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 3D249180F8B81 for ; Mon, 25 Jan 2021 19:08:17 +0000 (UTC) X-HE-Tag: cast01_550b08a27588 X-Filterd-Recvd-Size: 4345 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Jan 2021 19:08:16 +0000 (UTC) Received: by mail-ed1-f41.google.com with SMTP id j13so16846441edp.2 for ; Mon, 25 Jan 2021 11:08:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hdLQs9YhUyBlZb0691w21OoM7gQzX66C67jTFkr/mjs=; b=PhrOFTqhSD76Or0F7QbEfxqm+BbqNn9iOEQYgXFGi3uCzXbCuJkk0zDu9CLjb4Jzsf zqeSh0g5FZ7bMnwp1o5HMnJL7m/cdVT/mDKnzwAG/5wEQjlMnB9+sP9uhPqFmCkw80z0 iU7/aSx2UVj67ovkxa1RfIQ+MHYel0wPyW1HLyzMdWzY6JGwgZFIs3B8dSkcB7tSiGm1 R5cUo3I42gUHtEfPqI/VDiOk0j+Wsubjr68RY2aG72aFksiuefjkV0ea62QfDBG7HZer Ra/p/gJIIvRMMZ8eICr2Q9PA+qnd09AZTfzC9LF2PftRdM2cpsEuriDE+V7SuGGe1RMC iMUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hdLQs9YhUyBlZb0691w21OoM7gQzX66C67jTFkr/mjs=; b=dmBBNNdOsi9jgJjV1iMLw9pUzqmT/zRzYiyoKsdxfjD8UPGk0ziqBslvbN37mrX7mC 5asbmc4Payc1RHnxtILbIzAWuKOVITD/lD5pB5IjWDS/CVivEHE43qVQgpmrce+pqPB8 iyTbCpOtq0AFpiMBz4zFtHl3RD3FZidMrjV5XVajCKBgN38+CbuJjqHfy1p9pu4kx6Qi tDoivV/2rZut9zYsYtjvzdr0Hdy4IEajz7Fcp8aZH/wJSRwb6Kri+wssdpQMKp9P8j7H VTivTBrocxeXDr+dcdK3atlxyCUxtKKNSIhfFrPr2JbadzMM8CAxT6ZMUd+b2KBcdnXZ 9zuQ== X-Gm-Message-State: AOAM531pI6PpzY0CvZGxNmIvtfXUx2jWL6h0VOV+K7DJ/rxdHyG/XSbp oIjlYMraczzre/g7Om9kSd7XAqS/jsmAh8+9visy/g== X-Google-Smtp-Source: ABdhPJy7Z4G9Po21L2Y3F0cRzdLntpiU/TxO1jJY1JOninMHxU5vtKQjvNzuJY5pAljmUmwR4FFdEU8DIfMQD9V/9mI= X-Received: by 2002:aa7:cd87:: with SMTP id x7mr1802740edv.210.1611601695344; Mon, 25 Jan 2021 11:08:15 -0800 (PST) MIME-Version: 1.0 References: <20200326032420.27220-1-pasha.tatashin@soleen.com> <20200326032420.27220-16-pasha.tatashin@soleen.com> In-Reply-To: From: Pavel Tatashin Date: Mon, 25 Jan 2021 14:07:39 -0500 Message-ID: Subject: Re: [PATCH v9 15/18] arm64: kexec: kexec EL2 vectors To: Marc Zyngier Cc: James Morris , Sasha Levin , "Eric W. Biederman" , kexec mailing list , LKML , Jonathan Corbet , Catalin Marinas , Will Deacon , Linux ARM , James Morse , Vladimir Murzin , Matthias Brugger , Bhupesh Sharma , linux-mm , Mark Rutland , steve.capper@arm.com, rfontana@redhat.com, Thomas Gleixner , Selin Dag Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > +.macro el1_sync_64 > > + br x4 /* Jump to new world from el2 */ > > + .fill 31, 4, 0 /* Set other 31 instr to zeroes */ > > +.endm > > The common idiom to write this is to align the beginning of the > macro, and not to bother about what follows: > > .macro whatever > .align 7 > br x4 > .endm > > Specially given that 0 is an undefined instruction, and I really hate to > see > those in the actual text. On the contrary, .align generates NOPs. Fixed that. > > > + > > +.macro invalid_vector label > > +\label: > > + b \label > > + .fill 31, 4, 0 /* Set other 31 instr to zeroes */ > > +.endm > > + > > +/* el2 vectors - switch el2 here while we restore the memory image. */ > > + .align 11 > > +ENTRY(kexec_el2_vectors) > > Please see commit 617a2f392c92 ("arm64: kvm: Annotate assembly using > modern > annoations"), and follow the same pattern. Fixed that as well. Thank you, Pasha