From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 426B4C0044D for ; Wed, 11 Mar 2020 17:45:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AA06120734 for ; Wed, 11 Mar 2020 17:45:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="hP0KGGjq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA06120734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A97A26B0003; Wed, 11 Mar 2020 13:45:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A46BC6B0005; Wed, 11 Mar 2020 13:45:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 936406B0006; Wed, 11 Mar 2020 13:45:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id 76EE76B0003 for ; Wed, 11 Mar 2020 13:45:17 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3ADAB4DDF for ; Wed, 11 Mar 2020 17:45:17 +0000 (UTC) X-FDA: 76583807874.02.wool60_68546ab9faf4a X-HE-Tag: wool60_68546ab9faf4a X-Filterd-Recvd-Size: 8067 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Mar 2020 17:45:16 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id a13so3937077edh.3 for ; Wed, 11 Mar 2020 10:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g0bFqwsXkUukHh8ZfDKot08BOWer+gFninhmoUg4N4E=; b=hP0KGGjqaMgRA4J7UQgYmOlx7VkzP0/sjYdfJ/2GmHapvrqjnyoyHI8+DQQfzi6xf/ nNCLkXm17Dfa5oVtbfCkrKT0PvAFyNKjn7Rf9P9jyrorKlGVigawlGZ93mmvCLR1tGpk DwwNenl0Av3HBTOa4oVJsOk9fVK1C6sFYAgA5XZR80mOTseCDx47FLomQnGOecrSvwXW 0tSbUvndpYS30PHYZe4LenZnmzs7CYwSn1Rvw1EmgMdLWkZALLdlD3pVTOV58AEbz9K7 15L1g4d4KWQUnINWXZ5jmf/zb0MquJw7Ab+Qn0Orfx0JZaJJsp4zOjlNngJFaLSCv+h+ AJ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g0bFqwsXkUukHh8ZfDKot08BOWer+gFninhmoUg4N4E=; b=mKylNC7upFNBxxV09DO4TdqISwAdwaWtSdFO2nG5/N0UgVa//HzOl302Aa0v0GjSdi ydAUg3dWic0thbN+DpeXzJPcJd7AOoFQP+KOJDYYjHcbNMnchrGy1J3ekUBMKe/T0tQd s4hgTHqQ4jUITQfw4dnVK6ehe3l8NKsp8GKZuaHLk3kf5F2JQih3zarF0DRS0WjOHDHp ygHe2gVimXY6yEPLEJutyOfsGA66TLlQ9sL1Qqn5RD9nqhu/HueyOuCqo/MiLzyBNNVd +5SfO3JKcPloMXzXiHveICffmuT4G4gjRk0hPwPLliOyL4XwNAnE3YiEQFnNyRP42C+E td9w== X-Gm-Message-State: ANhLgQ3ZvdnxSf5L/QtZRwy3kpHcuIUyEtaybmH+sORctporFTfxFZb9 Es2qx5Sj9H7PLgkfIMSuhbxDtVrNwRJR8/f7BfCqWw== X-Google-Smtp-Source: ADFU+vs4v81YY4ntsRiC9uQ5T2bWwhpBnVGb0EQlXIiP8t3Yqxk6E6nEPOpjSBZQv735hW2J0pKr2DfPMLgvPQ49Gc4= X-Received: by 2002:a05:6402:343:: with SMTP id r3mr2781292edw.85.1583948715601; Wed, 11 Mar 2020 10:45:15 -0700 (PDT) MIME-Version: 1.0 References: <20200311123848.118638-1-shile.zhang@linux.alibaba.com> In-Reply-To: <20200311123848.118638-1-shile.zhang@linux.alibaba.com> From: Pavel Tatashin Date: Wed, 11 Mar 2020 13:45:04 -0400 Message-ID: Subject: Re: [PATCH v3] mm: fix tick timer stall during deferred page init To: Shile Zhang Cc: Andrew Morton , Kirill Tkhai , linux-mm , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 11, 2020 at 8:39 AM Shile Zhang wrote: > > When 'CONFIG_DEFERRED_STRUCT_PAGE_INIT' is set, 'pgdatinit' kthread will > initialise the deferred pages with local interrupts disabled. It is > introduced by commit 3a2d7fa8a3d5 ("mm: disable interrupts while > initializing deferred pages"). > > On machine with NCPUS <= 2, the 'pgdatinit' kthread could be bound to > the boot CPU, which could caused the tick timer long time stall, system > jiffies not be updated in time. > > The dmesg shown that: > > [ 0.197975] node 0 initialised, 32170688 pages in 1ms > > Obviously, 1ms is unreasonable. > > Now, fix it by restore in the pending interrupts for every 32*1204 pages > (128MB) initialized, give the chance to update the systemd jiffies. > The reasonable demsg shown likes: > > [ 1.069306] node 0 initialised, 32203456 pages in 894ms Sorry for joining late to this thread. I wonder if we could use sched_clock() to print this statistics. Or not to print statistics at all? ============== diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 3c4eb750a199..5958f599aced 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1770,7 +1770,7 @@ static int __init deferred_init_memmap(void *data) const struct cpumask *cpumask = cpumask_of_node(pgdat->node_id); unsigned long spfn = 0, epfn = 0, nr_pages = 0; unsigned long first_init_pfn, flags; - unsigned long start = jiffies; + unsigned long start = sched_clock(); struct zone *zone; int zid; u64 i; @@ -1817,8 +1817,8 @@ static int __init deferred_init_memmap(void *data) /* Sanity check that the next zone really is unpopulated */ WARN_ON(++zid < MAX_NR_ZONES && populated_zone(++zone)); - pr_info("node %d initialised, %lu pages in %ums\n", - pgdat->node_id, nr_pages, jiffies_to_msecs(jiffies - start)); + pr_info("node %d initialised, %lu pages in %lldns\n", + pgdat->node_id, nr_pages, sched_clock() - start); pgdat_init_report_one_done(); return 0; ============== [ 1.245331] node 0 initialised, 10256176 pages in 373565742ns Pasha > Fixes: 3a2d7fa8a3d5 ("mm: disable interrupts while initializing deferred pages"). > > Co-developed-by: Kirill Tkhai > Signed-off-by: Kirill Tkhai > Signed-off-by: Shile Zhang > --- > mm/page_alloc.c | 25 ++++++++++++++++++++++--- > 1 file changed, 22 insertions(+), 3 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3c4eb750a199..a3a47845e150 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1763,12 +1763,17 @@ deferred_init_maxorder(u64 *i, struct zone *zone, unsigned long *start_pfn, > return nr_pages; > } > > +/* > + * Release the pending interrupts for every TICK_PAGE_COUNT pages. > + */ > +#define TICK_PAGE_COUNT (32 * 1024) > + > /* Initialise remaining memory on a node */ > static int __init deferred_init_memmap(void *data) > { > pg_data_t *pgdat = data; > const struct cpumask *cpumask = cpumask_of_node(pgdat->node_id); > - unsigned long spfn = 0, epfn = 0, nr_pages = 0; > + unsigned long spfn = 0, epfn = 0, nr_pages = 0, prev_nr_pages = 0; > unsigned long first_init_pfn, flags; > unsigned long start = jiffies; > struct zone *zone; > @@ -1779,6 +1784,7 @@ static int __init deferred_init_memmap(void *data) > if (!cpumask_empty(cpumask)) > set_cpus_allowed_ptr(current, cpumask); > > +again: > pgdat_resize_lock(pgdat, &flags); > first_init_pfn = pgdat->first_deferred_pfn; > if (first_init_pfn == ULONG_MAX) { > @@ -1790,7 +1796,6 @@ static int __init deferred_init_memmap(void *data) > /* Sanity check boundaries */ > BUG_ON(pgdat->first_deferred_pfn < pgdat->node_start_pfn); > BUG_ON(pgdat->first_deferred_pfn > pgdat_end_pfn(pgdat)); > - pgdat->first_deferred_pfn = ULONG_MAX; > > /* Only the highest zone is deferred so find it */ > for (zid = 0; zid < MAX_NR_ZONES; zid++) { > @@ -1809,9 +1814,23 @@ static int __init deferred_init_memmap(void *data) > * that we can avoid introducing any issues with the buddy > * allocator. > */ > - while (spfn < epfn) > + while (spfn < epfn) { > nr_pages += deferred_init_maxorder(&i, zone, &spfn, &epfn); > + /* > + * Release the interrupts for every TICK_PAGE_COUNT pages > + * (128MB) to give tick timer the chance to update the > + * system jiffies. > + */ > + if ((nr_pages - prev_nr_pages) > TICK_PAGE_COUNT) { > + prev_nr_pages = nr_pages; > + pgdat->first_deferred_pfn = spfn; > + pgdat_resize_unlock(pgdat, &flags); > + goto again; > + } > + } > + > zone_empty: > + pgdat->first_deferred_pfn = ULONG_MAX; > pgdat_resize_unlock(pgdat, &flags); > > /* Sanity check that the next zone really is unpopulated */ > -- > 2.24.0.rc2 >