From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB9CDC2D0F3 for ; Wed, 1 Apr 2020 16:52:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4684E2082F for ; Wed, 1 Apr 2020 16:52:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="iQ8P0o5L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4684E2082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D16778E0005; Wed, 1 Apr 2020 12:52:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC69C8E0001; Wed, 1 Apr 2020 12:52:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDCA18E0005; Wed, 1 Apr 2020 12:52:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id A23878E0001 for ; Wed, 1 Apr 2020 12:52:09 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 59A2F181AEF09 for ; Wed, 1 Apr 2020 16:52:09 +0000 (UTC) X-FDA: 76659878778.03.boat88_873141a021f55 X-HE-Tag: boat88_873141a021f55 X-Filterd-Recvd-Size: 3830 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Wed, 1 Apr 2020 16:52:08 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id i16so685704edy.11 for ; Wed, 01 Apr 2020 09:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zxAHZMB3P7yemdxIkt4vzJJqSZh7+SRQmJTgBhu3ZC4=; b=iQ8P0o5Lcw3JW6EArdliAxxbSUsS53/a5RuXf6cPfLAgAB3HtdBre2hHs9UVqpeY+8 Ls7Xo6o2CkvGoZeX9P9GymfYDZu/XQiV6feOl9/iKR5+dP5RI68em61mqQEaO07tO/xF DhjBHgnb+eSXwn3bqvdtEKt1WCdXQlX9StQDkAQqSGPR4/Rq9pE40qYhwj69RYWYOuqH hhYojVv/EPXQ6dX6rSacTwnYRnjGQS7st1sPiuh4/tRAcaxGhVUud9sxV7gI1yF/t8Zq KyOb9hR8h5nrjs+7+gSJbmX88/nfQfHhvZzKSkhKyZP6n5/8OPw4N5VUT1hvGt+k4JRM NaaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zxAHZMB3P7yemdxIkt4vzJJqSZh7+SRQmJTgBhu3ZC4=; b=FqqPcBDKK+0I7DspW1xB+f7xNawpOsk/UMykkzOZIAXwmp7clJvyfiBDdVe1DCTabr C1BctqqlW8Yjz5rAQLLPJ28UZa/y9oqK7L1mG7op3ypPs1okNCIYFlsPaUF8yj4kK4eF qVbC/X8owtETNtlAncMA6ze+acyErvxh/rTpFlh8vdhVOWM1kDpSgJ4Q5wAwRucp8nFr KFSvDvfX8W1P3lkagBgf41zT7/bh1HaNmnCFfsRpR8LyV0MI2p/kJKgs9uTdRt7PQo1h NKJdV3JllfpOPM+DNCfoCFEBMxipg5zOe+QSMDR0euNzkNTQtQrehvtA/k6D8LyjEK3V Bo8w== X-Gm-Message-State: ANhLgQ21b39C7wTnNZ22dkORc2Gxj2/SB3lN1MsNkkqB4YOLo7wnHjDO j7Lc/jD6SPsQf1VX+aK7lmC3o2QShjYAHw9jpR6QKQ== X-Google-Smtp-Source: ADFU+vuVpMe/hjYycPBUcJTSJrMd3zMxZKNcPfopDiEvgMF/laDQbj3sNMjztAxqNc/bUeFitH6ag3fui6K9vZtu0Zc= X-Received: by 2002:a17:906:65ca:: with SMTP id z10mr20461333ejn.368.1585759927596; Wed, 01 Apr 2020 09:52:07 -0700 (PDT) MIME-Version: 1.0 References: <20200311123848.118638-1-shile.zhang@linux.alibaba.com> <20200401154217.GQ22681@dhcp22.suse.cz> <20200401160048.GU22681@dhcp22.suse.cz> <20200401160929.jwekhr24tb44odea@ca-dmjordan1.us.oracle.com> <20200401161243.GW22681@dhcp22.suse.cz> <20200401161810.xvqikca2x46yqrlx@ca-dmjordan1.us.oracle.com> <20200401162655.GX22681@dhcp22.suse.cz> <20200401164654.GY22681@dhcp22.suse.cz> In-Reply-To: <20200401164654.GY22681@dhcp22.suse.cz> From: Pavel Tatashin Date: Wed, 1 Apr 2020 12:51:56 -0400 Message-ID: Subject: Re: [PATCH v3] mm: fix tick timer stall during deferred page init To: Michal Hocko Cc: Daniel Jordan , Vlastimil Babka , David Hildenbrand , Shile Zhang , Andrew Morton , Kirill Tkhai , linux-mm , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > I do not remember seeing any real failures, this was a theoretical > > window. So, we could potentially simply remove these locks until we > > see a real boot failure in some interrupt thread. The allocation has > > to be rather large as well. > > Yes please! We are really great at over complicating and over > engineering stuff based on theoretical issues and build on top of that > and make the code even more complex because nobody dares to re-evaluate > and so on. I will submit a patch (or revert) whichever is cleaner. Pasha