From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2261C433F5 for ; Tue, 26 Oct 2021 22:23:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 064C7610A0 for ; Tue, 26 Oct 2021 22:23:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 064C7610A0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 651B2940008; Tue, 26 Oct 2021 18:23:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 600A3940007; Tue, 26 Oct 2021 18:23:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EF33940008; Tue, 26 Oct 2021 18:23:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 40727940007 for ; Tue, 26 Oct 2021 18:23:24 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0055618092DF9 for ; Tue, 26 Oct 2021 22:23:23 +0000 (UTC) X-FDA: 78740015928.33.BCDB680 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf12.hostedemail.com (Postfix) with ESMTP id A1CA510003D4 for ; Tue, 26 Oct 2021 22:23:23 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id e2so1272423ljg.13 for ; Tue, 26 Oct 2021 15:23:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5yAbsSDTyXKCbmRqx6GfGJ70j5TRIGVZvHi15gEjZWk=; b=WwJ04lDbV4WtjPG362zKNVes5Zgq6jhK5f+cv5F1qrZSm9cyeJ5Bmf3Pe0QyNKWyKQ qCPtT9ZuZGN28UcLHc5snwkn329H1tWgqF2HU56yvDBNRbWd8ae/ihD6sAClbDOknFwn TEuDKdG9/a+G6HhT5Z/GreNwRGKds+QFkrWneycisHf14Jwr1SfSGL590J8qulBw7ZLO C3KAEfcs6p3zs8gMdDvzY+JhTF7AsBGoZai7H6OZ/PE4SbZYb7LQh4ynZS1Ab3nMhmsR zckHHJm2gjCUG5UcpUl5+bEBJHvVY6H7R4jJ+CSOP/7GU1uDljeKqcw+NJf6WnNr90C8 bQDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5yAbsSDTyXKCbmRqx6GfGJ70j5TRIGVZvHi15gEjZWk=; b=XflB4by7hRsRbwCWbXeJSORvztzGwRS28YZYPcqnFCWO6QWsGdrBEgeJQK6juJX1Wb 5XwjyqTdjMOVdIr/DTC6IoW+ou6xbpHKS2nS8QIXSWKhXMM3BpWj2HILaQTVc7aFXlw0 pmPh7PiCVdmMvnHGiT2Ai7oOLnr9Pg8O8WB2UJ06b6rssK8plcbQL+tTWl2D+jDJPjPR kOp2yc5SCZSWaJxDb7k8Lam/vOCjZGoleHy2PN71JCTzsMpCyI5h26cWgrl+GnhXJtQ9 5/6TggJ7W8o4gicLslPwKptm7J19xzde4wgKcNR0ODUl4F+Uf5sGtmYJxqBI+AoH7tmB oMYw== X-Gm-Message-State: AOAM530gZfx98fbg5LER4Takml4LTyL2subjbBx2aLgDwFErk7SyUXd8 M3G8CbFVUtWzxcYpk0GuomKj8M96M3qiCSaSK0BRrQ== X-Google-Smtp-Source: ABdhPJxXnc1aAE8cvYRQfGD1NVe+gcg9BWkSLoFndt3NsWEOhwj2NAPZEpVXct6hSZ4d6c+wt4EyHAHK0yGxguSvD9c= X-Received: by 2002:a2e:8ed0:: with SMTP id e16mr9323697ljl.171.1635287002099; Tue, 26 Oct 2021 15:23:22 -0700 (PDT) MIME-Version: 1.0 References: <20211026220635.35187-1-mike.kravetz@oracle.com> In-Reply-To: <20211026220635.35187-1-mike.kravetz@oracle.com> From: Pasha Tatashin Date: Tue, 26 Oct 2021 18:22:45 -0400 Message-ID: Subject: Re: [PATCH] hugetlb: remove unnecessary set_page_count in prep_compound_gigantic_page To: Mike Kravetz Cc: linux-mm , LKML , Matthew Wilcox , Muchun Song , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: A1CA510003D4 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=WwJ04lDb; spf=pass (imf12.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none X-Stat-Signature: t8tsbfuebg4749kxhywfi6485j1snwwg X-Rspamd-Server: rspam06 X-HE-Tag: 1635287003-627604 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 26, 2021 at 6:06 PM Mike Kravetz wrote: > > In commit 7118fc2906e29 ("hugetlb: address ref count racing in > prep_compound_gigantic_page"), page_ref_freeze is used to atomically > zero the ref count of tail pages iff they are 1. The unconditional > call to set_page_count(0) was left in the code. This call is after > page_ref_freeze so it is really a noop. > > Remove redundant and unnecessary set_page_count call. > > Fixes: 7118fc2906e29 ("hugetlb: address ref count racing in prep_compound_gigantic_page") > Suggested-by: Pasha Tatashin > Signed-off-by: Mike Kravetz Reviewed-by: Pasha Tatashin Thanks, Pasha