From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A4F5C433E0 for ; Sat, 23 Jan 2021 01:15:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ED1CD23B2A for ; Sat, 23 Jan 2021 01:15:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED1CD23B2A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E6BE16B0005; Fri, 22 Jan 2021 20:15:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF6556B0007; Fri, 22 Jan 2021 20:15:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE5476B0008; Fri, 22 Jan 2021 20:15:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id B87256B0005 for ; Fri, 22 Jan 2021 20:15:26 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7B8AA181AF5C4 for ; Sat, 23 Jan 2021 01:15:26 +0000 (UTC) X-FDA: 77735271852.15.need24_2215c2727570 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 577A71814B0CC for ; Sat, 23 Jan 2021 01:15:26 +0000 (UTC) X-HE-Tag: need24_2215c2727570 X-Filterd-Recvd-Size: 4684 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Sat, 23 Jan 2021 01:15:25 +0000 (UTC) Received: by mail-ej1-f53.google.com with SMTP id ke15so10199111ejc.12 for ; Fri, 22 Jan 2021 17:15:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aZHWC0QZZA37dcKrvB+jA2eMe/FYFoxrvp88RR54inU=; b=a2niozalS5x3ybbQChS+nPD+2ab6W0/kt0PFw46W1AX+wreKDIEfNPpr5Zj9lOcF+q nC2/oUSgvc976KUmJSIeLtrOQjtRqmloROV2AypxhQg+hwFAFMtW2xLiauW44AEUUBiF hqXn3dj4jQ5kvRsie+iEc1dnVD+pn3+DuO9fCEdZWEo81leY7mAk4Cx6Moxuh8V+XrmI XxgfHHGW3RJazwFFiCy2xfbua/KA4gLR/tjJ0mIGxAyexDL649yOZ+ArNgq88o25sLpw DdCK0x9a0chUuwCzclGE21GM+/fZ31LlbfIZ4ABbK16Qx/3fLiJRXvJuyzFIiBeOl8hu JbqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aZHWC0QZZA37dcKrvB+jA2eMe/FYFoxrvp88RR54inU=; b=iKjIKHxve/nfNJjXQxlpagB+mk1MHVl/Wfn+zxACmKZuHto5D484VCunoiEA6HD3sj i8fls/MBaJRbWzEZf4cTqHMFMmmpZvsJLu7qX0dd3WUf3A0vs1bqY8piEA8mSjC4M/5+ 5Ii2aYPapL9YR1LnNNyto89Qg1jlspOGx/Kd3i7+EDmABl8TcLpfE1SwcwbMNvASrUWH SLZv0Mab0dpWODq0FdMkUXpJXm2oPKS6+ikUxOH75F7ZOZ9g9fOWm0mVCMS1FN0ZxVm6 OKG1O+1Ag3Q5OVGNOoX8CBA97oJ9Z+uGj3nHmco6krKDJ0ptKflLEREM+TSHEB3op5r2 DuWw== X-Gm-Message-State: AOAM5313umxi4bcs/yTmbWu++DQ025+n739R4UiJu6LHbey2khEFslLr st20Oogwsexu26wT+IJSQaYUHf/oYWo+t/SkMF7lfg== X-Google-Smtp-Source: ABdhPJwcM5QQPYi/sgWHIWgDz4u3w27IDZzkKokmBVapf4JwhJZ/P1/Dbfiwu5YNNk0+Bg+9VIWUvMUFFqXOuhMG3RE= X-Received: by 2002:a17:906:eb95:: with SMTP id mh21mr4823614ejb.175.1611364524697; Fri, 22 Jan 2021 17:15:24 -0800 (PST) MIME-Version: 1.0 References: <20200326032420.27220-1-pasha.tatashin@soleen.com> <20200326032420.27220-11-pasha.tatashin@soleen.com> In-Reply-To: From: Pavel Tatashin Date: Fri, 22 Jan 2021 20:14:49 -0500 Message-ID: Subject: Re: [PATCH v9 10/18] arm64: kexec: cpu_soft_restart change argument types To: James Morse Cc: James Morris , Sasha Levin , "Eric W. Biederman" , kexec mailing list , LKML , Jonathan Corbet , Catalin Marinas , Will Deacon , Linux ARM , Marc Zyngier , Vladimir Murzin , Matthias Brugger , Bhupesh Sharma , linux-mm , Mark Rutland , steve.capper@arm.com, rfontana@redhat.com, Thomas Gleixner , Selin Dag Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 29, 2020 at 1:01 PM James Morse wrote: > > Hi Pavel, > > On 26/03/2020 03:24, Pavel Tatashin wrote: > > Change argument types from unsigned long to a more descriptive > > phys_addr_t. > > For 'entry', which is a physical addresses, sure... > > > diff --git a/arch/arm64/kernel/cpu-reset.h b/arch/arm64/kernel/cpu-reset.h > > index ed50e9587ad8..38cbd4068019 100644 > > --- a/arch/arm64/kernel/cpu-reset.h > > +++ b/arch/arm64/kernel/cpu-reset.h > > @@ -10,17 +10,17 @@ > > > > #include > > > > -void __cpu_soft_restart(unsigned long el2_switch, unsigned long entry, > > - unsigned long arg0, unsigned long arg1, unsigned long arg2); > > > +void __cpu_soft_restart(phys_addr_t el2_switch, phys_addr_t entry, > > + phys_addr_t arg0, phys_addr_t arg1, phys_addr_t arg2); > > This looks weird because its re-using the hyp-stub API, because it might call the hyp-stub > from the idmap. entry is passed in, so this isn't tied to kexec. Without tying it to > kexec, how do you know arg2 is a physical address? > I think it tried to be re-usable because 32bit has more users for this. I will drop this patch. It was intended as a cleanup from suggestions in earlier versions of this series, but I see it is not really needed. Thank you, Pasha