From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76A6DC636C8 for ; Thu, 15 Jul 2021 18:11:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DB2656128D for ; Thu, 15 Jul 2021 18:11:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB2656128D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 290E88D00F0; Thu, 15 Jul 2021 14:11:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 241618D00EC; Thu, 15 Jul 2021 14:11:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E20F8D00F0; Thu, 15 Jul 2021 14:11:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id D93898D00EC for ; Thu, 15 Jul 2021 14:11:29 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B9510185B02A5 for ; Thu, 15 Jul 2021 18:11:28 +0000 (UTC) X-FDA: 78365614656.08.07A6060 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf19.hostedemail.com (Postfix) with ESMTP id 6B19DB000191 for ; Thu, 15 Jul 2021 18:11:28 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id hd33so10750278ejc.9 for ; Thu, 15 Jul 2021 11:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xFNcy37c+BnJmbGuVLgBOx81eX2e2c/KJb9k8Y2Otp4=; b=KM/X5+2FdDaB+GeERQSAkF2pO4RsG3QXA+s39Eut0Wy4eYIF8KVO+vM4tDdpJm5mZ2 sL6jpjuL92+pP6d7x8aUW/1RsWoZrVr/tDzuttsoiBsdA11B1VdDFDqkY8VCnfkBd1ZQ mzKz6IuD4fYuPbPlCGvN+i8sO1l5kVVanwMfmWxJ2FRK+ZeYY2aHVTAWz28dD2zxrmvB 4i7Y7RGFm63mwaipFdUCyea2doWi5l4JcQK6GSrV0dub7ISBNtSjiB8CHxQWv55pJ9mV yi7mAxXcj6ruq+lGocXldjSyg8zn9APwMfsU1bCAc+5bhjgiSdRvnplgBHZCEilqQQLN ZQgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xFNcy37c+BnJmbGuVLgBOx81eX2e2c/KJb9k8Y2Otp4=; b=Hln6qSR0PGaeYHXTwetc3nRoLZ1rPHHL3bO6b83YywubQGsMsMmmIPp1hxMd/Allhv HPKL4+eM2/NQsfI3I4I6lhcs1c4tJtGJ6Qxdjisy3ofGmXZULcVoyDCWWktbLA71A66P AXOX9WIveQ2+fo21xTPHu+7IP6sMZlCYg0yAfdrG59mAJTwbn+xojcGUKOaHDPV4C7QZ CN3rpdO7OvGVeaTigwcCgKsqWAobEmLen3lE5nC290NxyHpDyd0mNyoThhxA1IqMNI+/ CQc2Wcw7A92BodbFqmpuhm0ODdFRE8O1TULfHixJTi3z+MSE3LUWFvi77aLNQfj1jE5Z /5ng== X-Gm-Message-State: AOAM530F04YlmBsqWBmAcYIeduk4D8xYElXgyIywCbDQggamH4ykVSn6 pvrT3K67yYiCz7pDFstiJeVIZoXaHkE3afhiXTC1Fg== X-Google-Smtp-Source: ABdhPJw20x8zM9yk0v6py5sxnw1GfLqy7pUfvhYM1HI/OSIxyiJ+BqGcVW7bi0WRGjmMuAfSCpW6oa+KgojFjhu4Z04= X-Received: by 2002:a17:906:c14a:: with SMTP id dp10mr7112755ejc.426.1626372687355; Thu, 15 Jul 2021 11:11:27 -0700 (PDT) MIME-Version: 1.0 References: <343394260f599d940cacc37f1dcc0309239ae220.1626371112.git.zhansayabagdaulet@gmail.com> In-Reply-To: <343394260f599d940cacc37f1dcc0309239ae220.1626371112.git.zhansayabagdaulet@gmail.com> From: Pavel Tatashin Date: Thu, 15 Jul 2021 14:10:51 -0400 Message-ID: Subject: Re: [PATCH 1/2] mm: KSM: fix ksm_run data type To: Zhansaya Bagdauletkyzy Cc: Andrew Morton , Tyler Hicks , linux-mm , LKML Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b="KM/X5+2F"; spf=pass (imf19.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none X-Rspamd-Server: rspam02 X-Stat-Signature: xqb7ddhktbeibwbfxss8o6zdz5rqkoqw X-Rspamd-Queue-Id: 6B19DB000191 X-HE-Tag: 1626372688-590914 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021 at 2:01 PM Zhansaya Bagdauletkyzy wrote: > > ksm_run is declared as unsigned long but in run_store(), it is converted > to unsigned int. Change its type to unsigned int. > > Signed-off-by: Zhansaya Bagdauletkyzy > --- > mm/ksm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 3fa9bc8a67cf..057d0c245bf4 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -289,7 +289,7 @@ static int ksm_nr_node_ids = 1; > #define KSM_RUN_MERGE 1 > #define KSM_RUN_UNMERGE 2 > #define KSM_RUN_OFFLINE 4 > -static unsigned long ksm_run = KSM_RUN_STOP; > +static unsigned int ksm_run = KSM_RUN_STOP; > static void wait_while_offlining(void); > > static DECLARE_WAIT_QUEUE_HEAD(ksm_thread_wait); > @@ -2874,7 +2874,7 @@ KSM_ATTR(pages_to_scan); > static ssize_t run_show(struct kobject *kobj, struct kobj_attribute *attr, > char *buf) > { > - return sysfs_emit(buf, "%lu\n", ksm_run); > + return sysfs_emit(buf, "%u\n", ksm_run); Reviewed-by: Pavel Tatashin