From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89087C4741F for ; Wed, 30 Sep 2020 22:42:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E86FA2074A for ; Wed, 30 Sep 2020 22:42:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VQAtApKt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E86FA2074A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 204A76B0068; Wed, 30 Sep 2020 18:42:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13DB56B006C; Wed, 30 Sep 2020 18:42:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 079DD6B006E; Wed, 30 Sep 2020 18:42:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0149.hostedemail.com [216.40.44.149]) by kanga.kvack.org (Postfix) with ESMTP id E17856B0068 for ; Wed, 30 Sep 2020 18:42:30 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B23851810780D for ; Wed, 30 Sep 2020 22:42:30 +0000 (UTC) X-FDA: 77321203260.07.rat36_241675627196 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 9249C1812C29A for ; Wed, 30 Sep 2020 22:42:30 +0000 (UTC) X-HE-Tag: rat36_241675627196 X-Filterd-Recvd-Size: 5717 Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Wed, 30 Sep 2020 22:42:30 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id y74so4309376iof.12 for ; Wed, 30 Sep 2020 15:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=weXqoR5W7pMz/Wlact2MjKFoSWb9gtGm8NYhMTne0Q8=; b=VQAtApKtw+J+bOGAB2Gj+wwZD9R7fUMLw2yf62MxjMzL4gj8Fke7JTzZ0KPkYi0AWp PekMhLzMoNGufs16UQ6duvgRLBQRbFjE7tWb5RNEJtCTVsEExWOh3PRpedBMvdkQ89mZ Y8lz3aeibSPo4298ucrz0JWgm53AvevXqozHoLlVbeBkTCv0Ysj+/Tb2BcXc+1z5O9z8 JaiXZ3tuzOl00t5EsIifnuU093RtR10+pbJDJnKH4eaLSUs/ynjWlDuY9OHU+QrZopgy Euc0BFhq7GEfn4Dau5owRNA70E9XB1K1/2YeHOSeshcDd//KMLVykIsv+2DhFd0dEi0I JzDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=weXqoR5W7pMz/Wlact2MjKFoSWb9gtGm8NYhMTne0Q8=; b=mJVeA2voJy4wtGGD8bIGII/5iLUBYqeOJjnPWdj03P6gaIt2eiSdhnsoSSUdi4dagi kpsAkhaoejbAEzF0NIRZGIwUT+xKmP+0eMd4+SjPe5c95vkTRxLa7+olfYAvIe1RaDf4 7PXzUUUDFY7k4aADvbYMAb9+uDt84v44yWE0NZXjZR1AKjt+48OLkXhTdNwh9tXTrF/p AIsQ8Tn5NMqUaah/bvHCk8LvzWfD1HYilFHfdxjWKu/KjM7b+TSxQY0hFYOg33kZhFJT XBAnyeySyiBJn8XX2Z868cDzYe32OLxH489Ts+6K6FVD2ThpEuh+o+PonPMdTiAnDzut oOPA== X-Gm-Message-State: AOAM5327jZqU6FS8AcxcHBFk6qIp8+muO18gU82Ft3VDu576gZ6r67Vg 5m+O1FQ067WS3fUjK0SqdpiYRRCnKe3h4ieS54LUMQ== X-Google-Smtp-Source: ABdhPJyv1YGmG80gB4Wo4k/IiqYQGwjginXohHeUXbbMCtYivyoxkrASPmTKl+GKgfiJnYks1ERRGxjCA7yaWVoD9qc= X-Received: by 2002:a02:c914:: with SMTP id t20mr3714423jao.117.1601505749184; Wed, 30 Sep 2020 15:42:29 -0700 (PDT) MIME-Version: 1.0 References: <20200930222130.4175584-1-kaleshsingh@google.com> <20200930223207.5xepuvu6wr6xw5bb@black.fi.intel.com> In-Reply-To: <20200930223207.5xepuvu6wr6xw5bb@black.fi.intel.com> From: Lokesh Gidra Date: Wed, 30 Sep 2020 15:42:17 -0700 Message-ID: Subject: Re: [PATCH 0/5] Speed up mremap on large regions To: "Kirill A. Shutemov" Cc: Kalesh Singh , Suren Baghdasaryan , Minchan Kim , Joel Fernandes , kernel-team@android.com, Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , Shuah Khan , "Aneesh Kumar K.V" , Kees Cook , Peter Zijlstra , Sami Tolvanen , Masahiro Yamada , Arnd Bergmann , Frederic Weisbecker , Krzysztof Kozlowski , Hassan Naveed , Christian Brauner , Mark Rutland , Mike Rapoport , Gavin Shan , Zhenyu Ye , Jia He , John Hubbard , William Kucharski , Sandipan Das , Ralph Campbell , Mina Almasry , Ram Pai , Dave Hansen , Kamalesh Babulal , Masami Hiramatsu , Brian Geffon , SeongJae Park , linux-kernel , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 30, 2020 at 3:32 PM Kirill A. Shutemov wrote: > > On Wed, Sep 30, 2020 at 10:21:17PM +0000, Kalesh Singh wrote: > > mremap time can be optimized by moving entries at the PMD/PUD level if > > the source and destination addresses are PMD/PUD-aligned and > > PMD/PUD-sized. Enable moving at the PMD and PUD levels on arm64 and > > x86. Other architectures where this type of move is supported and known to > > be safe can also opt-in to these optimizations by enabling HAVE_MOVE_PMD > > and HAVE_MOVE_PUD. > > > > Observed Performance Improvements for remapping a PUD-aligned 1GB-sized > > region on x86 and arm64: > > > > - HAVE_MOVE_PMD is already enabled on x86 : N/A > > - Enabling HAVE_MOVE_PUD on x86 : ~13x speed up > > > > - Enabling HAVE_MOVE_PMD on arm64 : ~ 8x speed up > > - Enabling HAVE_MOVE_PUD on arm64 : ~19x speed up > > > > Altogether, HAVE_MOVE_PMD and HAVE_MOVE_PUD > > give a total of ~150x speed up on arm64. > > Is there a *real* workload that benefit from HAVE_MOVE_PUD? > We have a Java garbage collector under development which requires moving physical pages of multi-gigabyte heap using mremap. During this move, the application threads have to be paused for correctness. It is critical to keep this pause as short as possible to avoid jitters during user interaction. This is where HAVE_MOVE_PUD will greatly help. > -- > Kirill A. Shutemov