From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7572C433E1 for ; Tue, 28 Jul 2020 14:36:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9E6CA206D4 for ; Tue, 28 Jul 2020 14:36:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LhfgIFjP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E6CA206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3E54A6B0078; Tue, 28 Jul 2020 10:36:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 395E26B007D; Tue, 28 Jul 2020 10:36:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2842E6B0093; Tue, 28 Jul 2020 10:36:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id 0E3536B0078 for ; Tue, 28 Jul 2020 10:36:22 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AE687181AC9B6 for ; Tue, 28 Jul 2020 14:36:21 +0000 (UTC) X-FDA: 77087734962.23.mice84_3a179ce26f6a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 87B63377A6 for ; Tue, 28 Jul 2020 14:35:29 +0000 (UTC) X-HE-Tag: mice84_3a179ce26f6a X-Filterd-Recvd-Size: 4385 Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Tue, 28 Jul 2020 14:35:28 +0000 (UTC) Received: by mail-io1-f67.google.com with SMTP id l17so20956772iok.7 for ; Tue, 28 Jul 2020 07:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wE63hykpdOWCKf+hJ+uo4tJ4NmzeI9PTAqJH7wvSMlc=; b=LhfgIFjPN1Zt6pM27TDwc0D9sQ3LgHFulpPO2SX5S88mG/mDfs8otJIYAkvnkswxld 9pGQRB5MX9+c/pNc/D2jvjcUfkcaX+O+bWMi/ZdZWSGCZgEcirUgpaGCBHTTFwLDeXxm blFwenzn7yqD2djWtvbrpRZs6R2NA61KUwTMx0D/r9/j+IuKq9D9CivCPsM5HlRumsun 8SeaeatA922UsvA+t5ljvF60Q6rxHuH9aAmjAJ5nqq0yc8rdtO4PxA+a9Y5/pkBdStPf L/JGt34i7DNkTsg+8boIo3khF5Q26aC+wBgUC+PHLlS8m0uSQi46IDgH+/15eUls3L+F tp9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wE63hykpdOWCKf+hJ+uo4tJ4NmzeI9PTAqJH7wvSMlc=; b=be1DQMCQAfIJI+GvlOD/FxABpgjWruqM9iLjEaXzMl55cWig+DH16W9DUMk0fSMZ1G OMdDwtXYzOsWMiRaVUDVy+tnj8CNYrOVq5Npnhc2+S54XuK/Rl0h3NVZuRRoOIxSbKw6 ADRsqhxYkIEmelMtHYZTBf6ZnqS0yt20kjmnR/7zKeF+iscg8y6jvMaeXXJJchYk94FP NWrZNP1D988MFXZW8Cm1K1mFk9bguAgW94bHPu2oxX/PGcXK5Og8cP+cBrD8OahBZAHG yL2Ynbnj11VgPQO9rWtUxqPYLzPCFaCC+VQGMdATCM1Yb3hKrSgchoV57wDQDRlZm5r3 22Bg== X-Gm-Message-State: AOAM531CTJibSvkJGFh1Gn6RvD/VN1GNccxJJhZ59JRXyHvT5Dp5NuzT K64KQqGv55F9XNNGMKTsObsHq3WRkUnsr6I/oGUPYQ== X-Google-Smtp-Source: ABdhPJy2WEagQVK01W1PoJL3TtsswctQA4jC85OF1eYxNmME8rZTNY5/2CM7uNz/FDIzfpS1C5VvpAW+f52j5jGXddQ= X-Received: by 2002:a05:6638:134a:: with SMTP id u10mr6463616jad.35.1595946928305; Tue, 28 Jul 2020 07:35:28 -0700 (PDT) MIME-Version: 1.0 References: <20200727134914.312934924@linuxfoundation.org> In-Reply-To: From: Naresh Kamboju Date: Tue, 28 Jul 2020 20:05:16 +0530 Message-ID: Subject: Re: [External] Re: [PATCH 4.19 00/86] 4.19.135-rc1 review To: Muchun Song Cc: Greg Kroah-Hartman , open list , Linus Torvalds , Andrew Morton , Guenter Roeck , Shuah Khan , patches@kernelci.org, Ben Hutchings , linux- stable , Hugh Dickins , Christoph Lameter , Roman Gushchin , Joonsoo Kim , linux-mm , mm-commits@vger.kernel.org, Pekka Enberg , David Rientjes , Shakeel Butt , Vlastimil Babka , Arnd Bergmann , lkft-triage@lists.linaro.org, clang-built-linux@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 87B63377A6 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 28 Jul 2020 at 18:33, Muchun Song wrote: > > Thanks for your test. I have reviewed the patch: > > [PATCH 4.19 76/86] mm: memcg/slab: fix memory leak at non-root > kmem_cache destroy > > There is a backport problem and I have pointed out the problem in that email. Thanks for your suggestions on the other email thread. I have made changes as you said and boot test pass on x86 now. diff --git a/mm/slab_common.c b/mm/slab_common.c index 9c5eb4b08fc3..65bc49f19504 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -842,9 +842,7 @@ static int shutdown_memcg_caches(struct kmem_cache *s) static void memcg_set_kmem_cache_dying(struct kmem_cache *s) { - mutex_lock(&slab_mutex); s->memcg_params.dying = true; - mutex_unlock(&slab_mutex); } static void flush_memcg_workqueue(struct kmem_cache *s) - Naresh