From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFDD6C433E3 for ; Thu, 13 Aug 2020 09:17:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8771020781 for ; Thu, 13 Aug 2020 09:17:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KBgg1LCh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8771020781 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EB54F8D0001; Thu, 13 Aug 2020 05:17:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3EE96B0006; Thu, 13 Aug 2020 05:17:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D079D8D0001; Thu, 13 Aug 2020 05:17:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id B72C16B0003 for ; Thu, 13 Aug 2020 05:17:04 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 60331824805A for ; Thu, 13 Aug 2020 09:17:04 +0000 (UTC) X-FDA: 77144991168.17.snake60_5201ebb26ff3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 36953180D0184 for ; Thu, 13 Aug 2020 09:17:04 +0000 (UTC) X-HE-Tag: snake60_5201ebb26ff3 X-Filterd-Recvd-Size: 7320 Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Thu, 13 Aug 2020 09:17:03 +0000 (UTC) Received: by mail-il1-f196.google.com with SMTP id t4so4976740iln.1 for ; Thu, 13 Aug 2020 02:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AVVK701BmMx0nOUeszXW5DOWYJuKUEBlmJUyUmBXonw=; b=KBgg1LChIJzojq8wCoeBtwucYMjlQp1QRp2wmwPAM1zKPNUxxR3/5bSVizhTzk6G44 npUXrcnyRvP3lRa9ULHZykC+QGgP49O13LGemQfktRZo0AwGCTZxu1Ja45c7yx18xNv1 muca13rZx62UlS4IYGcPmIkoylmr5XPcDhItlD5VtS/lOEzd/55M7WX/jCSGZlcxiQI+ xvnTzujx3DLUkky5EGUiKdsM2s3jPLVW09TCdy6GQnvkfys69duwnup2xrOpSZ4dzgrb MtdejXgoIja4ZEo0YCTAljx1ZieNdcHRbla7np/JOHNAUDYiXq7g/vRLdZ5Giy7MIEkC pJKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AVVK701BmMx0nOUeszXW5DOWYJuKUEBlmJUyUmBXonw=; b=ZuKBD7tc9ipJHvZPTkuQV8iWag7uhVCtDylKzPLCOn6FQDAaxOKjvPebLN7MzbVJ3e 3YyaAwv3yYUf35f/T5T+uTXmWlSPFOUhy3z3SgpK1iv1t6xakcEYly+XpFvBq4nJRC0D orzLiBkWE9uIy71QGMLimM5ZFDxV48+uBZwMk4lS+RusP8GlDr4aUHtt5+IroDdtk+E8 yHsLKdhybJIlL3sjWXIfLQZCfP/nLHq4D5eX3dSwts2UcDte70A1Ivy/9dmq4fQesxNZ BS8cahFQsi0LdkLNrqSC8aNvkuZLnsVTXX3yS/t7bEArpqcbQfJAkA2h9vgWxX4JDkJc LPNw== X-Gm-Message-State: AOAM5324Dhuxd5lJFYhVzGWme9ybDspmwjaO5RQGTKltPdWaQibuESPo V1/XmthuOqkUXRM8vt8dhwPJJaSsH3F/yx4ep/u9Sg== X-Google-Smtp-Source: ABdhPJxRPXxN0U59d/h40YvTBY16ELyNZJXxcUBHQUGymL9OOd1KXfE1MSjnoyNb6ubpiCdMHTv5+ANAII49M9IQehI= X-Received: by 2002:a92:d5ca:: with SMTP id d10mr3686682ilq.216.1597310222851; Thu, 13 Aug 2020 02:17:02 -0700 (PDT) MIME-Version: 1.0 References: <20200623184515.4132564-1-guro@fb.com> <20200623184515.4132564-5-guro@fb.com> <20200811152737.GB650506@cmpxchg.org> <20200811170611.GB1507044@carbon.DHCP.thefacebook.com> In-Reply-To: <20200811170611.GB1507044@carbon.DHCP.thefacebook.com> From: Naresh Kamboju Date: Thu, 13 Aug 2020 14:46:51 +0530 Message-ID: Subject: Re: [PATCH v3 4/5] mm: memcg: charge memcg percpu memory to the parent cgroup To: Roman Gushchin , Linux-Next Mailing List , open list , linux-mm , Cgroups Cc: Johannes Weiner , Andrew Morton , Dennis Zhou , Tejun Heo , Christoph Lameter , Michal Hocko , Shakeel Butt , Kernel Team , lkft-triage@lists.linaro.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 36953180D0184 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The kernel warnings were noticed on linux next 20200813 while booting on arm64, arm, x86_64 and i386. metadata: git branch: master git repo: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git commit: e6d113aca646fb6a92b237340109237fd7a9c770 git describe: next-20200813 make_kernelversion: 5.8.0 kernel-config: https://builds.tuxbuild.com/YQHc_PpEV-DF8rU7N9tlIQ/kernel.config > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 130093bdf74b..e25f2db7e61c 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5137,6 +5137,9 @@ static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) > if (!pn) > return 1; > > + /* We charge the parent cgroup, never the current task */ > + WARN_ON_ONCE(!current->active_memcg); > + > pn->lruvec_stat_local = alloc_percpu_gfp(struct lruvec_stat, > GFP_KERNEL_ACCOUNT); > if (!pn->lruvec_stat_local) { > @@ -5219,6 +5222,9 @@ static struct mem_cgroup *mem_cgroup_alloc(void) > goto fail; > } > > + /* We charge the parent cgroup, never the current task */ > + WARN_ON_ONCE(!current->active_memcg); [ 0.217404] ------------[ cut here ]------------ [ 0.218038] WARNING: CPU: 0 PID: 0 at mm/memcontrol.c:5226 mem_cgroup_css_alloc+0x680/0x740 [ 0.219188] Modules linked in: [ 0.219597] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.8.0-next-20200813 #1 [ 0.220187] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014 [ 0.221190] EIP: mem_cgroup_css_alloc+0x680/0x740 [ 0.222190] Code: d6 17 5d ff 8d 65 f4 89 d8 5b 5e 5f 5d c3 8d 74 26 00 b8 58 39 6a d1 e8 fe 94 55 ff 8d 65 f4 89 d8 5b 5e 5f 5d c3 8d 74 26 00 <0f> 0b e9 01 fa ff ff 8d b4 26 00 00 00 00 66 90 bb f4 ff ff ff ba [ 0.223188] EAX: 00000000 EBX: d13666c0 ECX: 00000cc0 EDX: 0000ffff [ 0.224187] ESI: 00000000 EDI: f4c11000 EBP: d1361f50 ESP: d1361f40 [ 0.225188] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068 EFLAGS: 00210246 [ 0.226190] CR0: 80050033 CR2: ffd19000 CR3: 115f8000 CR4: 00040690 [ 0.227195] Call Trace: [ 0.227882] ? _cond_resched+0x17/0x30 [ 0.228195] cgroup_init_subsys+0x66/0x12a [ 0.229193] cgroup_init+0x118/0x323 [ 0.230194] start_kernel+0x43c/0x47d [ 0.231193] i386_start_kernel+0x48/0x4a [ 0.232194] startup_32_smp+0x164/0x168 [ 0.233195] ---[ end trace dfcf9be7b40caf05 ]--- [ 0.2342# 08] ------------[ cut here ]------------ [ 0.235192] WARNING: CPU: 0 PID: 0 at mm/memcontrol.c:5141 mem_cgroup_css_alloc+0x718/0x740 [ 0.236187] Modules linked in: [ 0.236590] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W 5.8.0-next-20200813 #1 [ 0.237190] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014 [ 0.238194] EIP: mem_cgroup_css_alloc+0x718/0x740 [ 0.239191] Code: 48 ff e9 7c fd ff ff 8d 76 00 a1 b0 14 40 d1 e9 53 fc ff ff 8d b6 00 00 00 00 0f 0b 8d b6 00 00 00 00 0f 0b 8d b6 00 00 00 00 <0f> 0b e9 df f9 ff ff 90 89 f8 e8 29 0c 5c ff 89 f2 b8 10 f4 40 d1 [ 0.240190] EAX: 00000000 EBX: f4c0c800 ECX: 00000000 EDX: d0eab660 [ 0.241189] ESI: 00000000 EDI: f4c11000 EBP: d1361f50 ESP: d1361f40 [ 0.242189] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068 EFLAGS: 00210246 [ 0.243190] CR0: 80050033 CR2: ffd19000 CR3: 115f8000 CR4: 00040690 [ 0.244188] Call Trace: [ 0.245191] ? _cond_resched+0x17/0x30 [ 0.245686] cgroup_init_subsys+0x66/0x12a [ 0.246189] cgroup_init+0x118/0x323 [ 0.246654] start_kernel+0x43c/0x47d [ 0.247189] i386_start_kernel+0x48/0x4a [ 0.247697] startup_32_smp+0x164/0x168 [ 0.248188] ---[ end trace dfcf9be7b40caf06 ]--- [ 0.248990] Last level iTLB entries: 4KB 512, 2MB 255, 4MB 127 [ 0.249187] Last level dTLB entries: 4KB 512, 2MB 255, 4MB 127, 1GB 0 Full test log, https://qa-reports.linaro.org/lkft/linux-next-oe/build/next-20200813/testrun/3061112/suite/linux-log-parser/test/check-kernel-warning-1665815/log -- Linaro LKFT https://lkft.linaro.org