From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CAE9C2BA19 for ; Mon, 13 Apr 2020 11:21:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DEB8C20732 for ; Mon, 13 Apr 2020 11:21:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y88rwGl/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEB8C20732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6034B8E0100; Mon, 13 Apr 2020 07:21:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B27B8E00FA; Mon, 13 Apr 2020 07:21:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C9E48E0100; Mon, 13 Apr 2020 07:21:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 367CA8E00FA for ; Mon, 13 Apr 2020 07:21:41 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F06762488 for ; Mon, 13 Apr 2020 11:21:40 +0000 (UTC) X-FDA: 76702591560.13.maid13_830a3f42d463e X-HE-Tag: maid13_830a3f42d463e X-Filterd-Recvd-Size: 5291 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Apr 2020 11:21:39 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id q17so4727376ljm.6 for ; Mon, 13 Apr 2020 04:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TfybxCS9KvV17UPheJnqSM+e/cLRrV8TeDHR7AgRiYw=; b=y88rwGl/RjfrMbIPOK7+s+NQx1aoXwZDd8G3Aln6CMeD6UrIUasDet6IZZcqT9dOg3 l4Nv3vQFImsFKN8Wer2g6roOIKKoWwGPTIPRR2BDmBgiuGNzPbldm5GlyKxYeioexKSM oGygbWZZ+ma2QaheiQrXtpCSqLrG1Ue+y1CEC5+cpb5b2ujPN3zfjQNxtDr5KIgCSYPo +Rj0dQk0vBVucBeDXA94ZYtSYVmc7M6iasr8XMAVU7DJ08AjFPmtZGSbwo7oeH4C6MtN W/eUnnA5mlK8b3G1nJCBEJp7l89bzD+tCMbv/jN17QQ5fXLGWtDv4POsulXDupmsSIlP SEqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TfybxCS9KvV17UPheJnqSM+e/cLRrV8TeDHR7AgRiYw=; b=tRqxB0Xod6tJowTGOnIA0kImy6zRdwIwsnZOZfcNaymV70s2Z2lpuxNSX5Do2BfAvd KumTtRfR2OA5tuLttf9MUZeDWiqojbN2LOJTAYoWHBJcjiEB1wCmJT/HtRmYlhklaOJ9 f6BLIL6OTWZ3JNj7/lulvbeXTO6qXkLV0quoXAH5A2r7mvasViaY1h5jCHQo57hynAI5 b3B4qdliIfRkudWEA3pKkrZyvcno7UMYdxrLlybVvaqvoOFXqZqKOvG+sEZwchfnP1E4 xsQgK8PcH65v1XPGWc4q30CZ+EcTY0bKmkak3ImQ07wljHEmpEKz2cz5Emw3zCe4FxFS 3dfQ== X-Gm-Message-State: AGi0PuYB/fuRd7m5Rdz0k2nCNoEOo46cdwModIythECkJ8/ZdAsaLX1x PCPS7fnOmwYc1v5I3ncD8+aUlzahGwik9rxmK8OTxA== X-Google-Smtp-Source: APiQypKZxajlMe0BodxfJkVJg9NJCcYeXNTqOwy0OQAXKiMOpmeX9tR3Jo8ny+juQeVyUWeXVPsZc/KvhmVF+uDhGws= X-Received: by 2002:a2e:a495:: with SMTP id h21mr10092859lji.123.1586776897822; Mon, 13 Apr 2020 04:21:37 -0700 (PDT) MIME-Version: 1.0 References: <20200412214150.GB38470@xz-x1> In-Reply-To: <20200412214150.GB38470@xz-x1> From: Naresh Kamboju Date: Mon, 13 Apr 2020 16:51:25 +0530 Message-ID: Subject: Re: i386: selftests: vm: compaction_test: BUG: kernel NULL pointer dereference, address: 00000000 To: Peter Xu Cc: open list , "open list:KERNEL SELFTEST FRAMEWORK" , linux-mm , lkft-triage@lists.linaro.org, Shuah Khan , Anders Roxell , Christophe Leroy , Andrew Morton , Leonardo Bras , Michael Ellerman , Mike Rapoport , Arnd Bergmann , Jules Irenge , "Huang, Ying" , Pankaj Gupta , Rik van Riel , Hugh Dickins , Minchan Kim , Mel Gorman , Dave Hansen , Mateusz Nosek , Sebastian Andrzej Siewior , Kees Cook , Vlastimil Babka , Hillf Danton Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 13 Apr 2020 at 03:12, Peter Xu wrote: > And since this one is very easy to reproduce, I finally noticed that > we have wrongly enabled uffd-wp on x86_32, which is definely not going > to work... Because we'll use bit 2 of swap entry assuming that's the > uffd-wp bit, while that's part of swp offset on 32bit systems. > > Naresh, could you try whether below change fixes the issue for you? > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 8d078642b4be..7ac524d1316e 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -149,7 +149,7 @@ config X86 > select HAVE_ARCH_TRACEHOOK > select HAVE_ARCH_TRANSPARENT_HUGEPAGE > select HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD if X86_64 > - select HAVE_ARCH_USERFAULTFD_WP if USERFAULTFD > + select HAVE_ARCH_USERFAULTFD_WP if X86_64 && USERFAULTFD > select HAVE_ARCH_VMAP_STACK if X86_64 > select HAVE_ARCH_WITHIN_STACK_FRAMES > select HAVE_ASM_MODVERSIONS > Tested-by: Naresh Kamboju The above patch tested and did not notice the crash. + cd /opt/kselftests/default-in-kernel/vm/ + ./compaction_test No of huge pages allocated = 297 + ./compaction_test [ 46.059785] kauditd_printk_skb: 15 callbacks suppressed [ 46.059786] audit: type=1334 audit(1586776582.927:25): prog-id=17 op=UNLOAD [ 46.071997] audit: type=1334 audit(1586776582.927:26): prog-id=16 op=UNLOAD No of huge pages allocated = 160 Full test log, https://lkft.validation.linaro.org/scheduler/job/1362495#L1308 Build artifacts. https://builds.tuxbuild.com/w0ol7cCsGan0wzPp7bNqkg/ - Naresh