From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14101C433E3 for ; Tue, 25 Aug 2020 07:34:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B759820578 for ; Tue, 25 Aug 2020 07:34:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Apqc+J7z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B759820578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3196A6B00A2; Tue, 25 Aug 2020 03:34:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C9D46B00A3; Tue, 25 Aug 2020 03:34:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B8278E0011; Tue, 25 Aug 2020 03:34:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by kanga.kvack.org (Postfix) with ESMTP id 059EB6B00A2 for ; Tue, 25 Aug 2020 03:34:08 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B0811180AD80F for ; Tue, 25 Aug 2020 07:34:07 +0000 (UTC) X-FDA: 77188277334.27.glue09_63016ce2705a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 043D43D668 for ; Tue, 25 Aug 2020 07:34:06 +0000 (UTC) X-HE-Tag: glue09_63016ce2705a X-Filterd-Recvd-Size: 7476 Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com [209.85.222.67]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Tue, 25 Aug 2020 07:34:06 +0000 (UTC) Received: by mail-ua1-f67.google.com with SMTP id v24so1702199uaj.7 for ; Tue, 25 Aug 2020 00:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Nv6CSGIbCknVAshl07j/5xGDdqtleXXUaO2AgALOcBQ=; b=Apqc+J7zJjLt7HIY9LJFORqtLChLWyXyW9OPPAm2IWuGKCEajOMJOtXt10DCqIEofM xvvHt+AE/VOWITfgJLQESVHUSXbl5SlmedCTjvNoU6i4abY1JLQs5mDoynT8Fpan7Hve URdOCRAMTN7YlABeKlRlIHyHB9fb7JRo8O2x66tNawMGyqBwQm9OQ4U9+CljGwOgEEum pN53ulxBMNpATD0T+DEUnY3jpR0IPiAa1DOZ2AtxLPw3InU5Wx2J0fgKInN09ExID/3P LkyET0zqDcSGBHVmedmDFcAy5zPKkEh8SiTsqt2rEpCJDplMY23oKHlDSsiyyxM6WRIa Cmcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Nv6CSGIbCknVAshl07j/5xGDdqtleXXUaO2AgALOcBQ=; b=VHNSPRuTsP7sCNbKwCWONEZytwx3b5kU6lSDP2UBDnK0ZJcWwsZRXpoIhtQxQ6Q/Nt UzFgV7RAW9I6W3Vmkt9y9xE3FeI38paZ9nR1BEkY3hcK6Zl10N0abGIhFuuGeOY7yVnw JAsiCFxwUs+SIFxzYXkq26MWwciJ+31cvGIp1kaMU42VKAzitI3huoajG0e8Yl/EBcXF ey9++Pu8tMJp3w56YAbI/cWcYGkZXGqNej/s0xVpQQP9ndgJHaC/hT+CngnLE2KI4H/Q 3Fc3IjW1s1QMmar+7doGXP12ZCND1778BlIQVmqXbhRbqHOHk4JpX8K0J1QNl1Dw3xO9 CRSw== X-Gm-Message-State: AOAM532N7V/BwQMCejQTUUYDm4nxDf0LGYHcp9+baZHshK1J9BfLWB8/ hoABmqjrZGHNU0uVpSacSVx7ZrPt4HL876g3GwQkog== X-Google-Smtp-Source: ABdhPJzaForEfiwBwHGNvHwRx3BWRXpyG8wDtoenb+p3GP/dDIygv4Sf8WgzvnHPl3pAkzXAJYtywlXsz8c7R9LZ5dk= X-Received: by 2002:ab0:462:: with SMTP id 89mr4776164uav.34.1598340845625; Tue, 25 Aug 2020 00:34:05 -0700 (PDT) MIME-Version: 1.0 References: <20200824110645.GC17456@casper.infradead.org> In-Reply-To: <20200824110645.GC17456@casper.infradead.org> From: Naresh Kamboju Date: Tue, 25 Aug 2020 13:03:53 +0530 Message-ID: Subject: Re: BUG: Bad page state in process true pfn:a8fed on arm To: Matthew Wilcox Cc: linux-mm , Linux-Next Mailing List , open list , lkft-triage@lists.linaro.org, Andrew Morton , LTP List , Arnd Bergmann , Russell King - ARM Linux , Mike Rapoport , Stephen Rothwell , Catalin Marinas , Christoph Hellwig , Andy Lutomirski , Peter Xu , opendmb@gmail.com, Linus Walleij , afzal.mohd.ma@gmail.com, Will Deacon , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 043D43D668 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 24 Aug 2020 at 16:36, Matthew Wilcox wrote: > > On Mon, Aug 24, 2020 at 03:14:55PM +0530, Naresh Kamboju wrote: > > [ 67.545247] BUG: Bad page state in process true pfn:a8fed > > [ 67.550767] page:9640c0ab refcount:0 mapcount:-1024 > > Somebody freed a page table without calling __ClearPageTable() on it. After running git bisect on this problem, The first suspecting of this problem on arm architecture this patch. 424efe723f7717430bec7c93b4d28bba73e31cf6 ("mm: account PMD tables like PTE tables ") Reported-by: Naresh Kamboju Reported-by: Anders Roxell Additional information: We have tested linux next by reverting this patch and confirmed that the reported BUG is not reproduced. These configs enabled on the running device, CONFIG_TRANSPARENT_HUGEPAGE=y CONFIG_TRANSPARENT_HUGEPAGE_MADVISE=y -- Suspecting patch -- commit 424efe723f7717430bec7c93b4d28bba73e31cf6 Author: Matthew Wilcox Date: Thu Aug 20 10:01:30 2020 +1000 mm: account PMD tables like PTE tables We account the PTE level of the page tables to the process in order to make smarter OOM decisions and help diagnose why memory is fragmented. For these same reasons, we should account pages allocated for PMDs. With larger process address spaces and ASLR, the number of PMDs in use is higher than it used to be so the inaccuracy is starting to matter. Link: http://lkml.kernel.org/r/20200627184642.GF25039@casper.infradead.org Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Mike Rapoport Cc: Abdul Haleem Cc: Andy Lutomirski Cc: Arnd Bergmann Cc: Christophe Leroy Cc: Joerg Roedel Cc: Max Filippov Cc: Peter Zijlstra Cc: Satheesh Rajendran Cc: Stafford Horne Signed-off-by: Andrew Morton Signed-off-by: Stephen Rothwell diff --git a/include/linux/mm.h b/include/linux/mm.h index b0a15ee77b8a..a4e5b806347c 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2239,7 +2239,7 @@ static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) return ptlock_ptr(pmd_to_page(pmd)); } -static inline bool pgtable_pmd_page_ctor(struct page *page) +static inline bool pmd_ptlock_init(struct page *page) { #ifdef CONFIG_TRANSPARENT_HUGEPAGE page->pmd_huge_pte = NULL; @@ -2247,7 +2247,7 @@ static inline bool pgtable_pmd_page_ctor(struct page *page) return ptlock_init(page); } -static inline void pgtable_pmd_page_dtor(struct page *page) +static inline void pmd_ptlock_free(struct page *page) { #ifdef CONFIG_TRANSPARENT_HUGEPAGE VM_BUG_ON_PAGE(page->pmd_huge_pte, page); @@ -2264,8 +2264,8 @@ static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) return &mm->page_table_lock; } -static inline bool pgtable_pmd_page_ctor(struct page *page) { return true; } -static inline void pgtable_pmd_page_dtor(struct page *page) {} +static inline bool pmd_ptlock_init(struct page *page) { return true; } +static inline void pmd_ptlock_free(struct page *page) {} #define pmd_huge_pte(mm, pmd) ((mm)->pmd_huge_pte) @@ -2278,6 +2278,22 @@ static inline spinlock_t *pmd_lock(struct mm_struct *mm, pmd_t *pmd) return ptl; } +static inline bool pgtable_pmd_page_ctor(struct page *page) +{ + if (!pmd_ptlock_init(page)) + return false; + __SetPageTable(page); + inc_zone_page_state(page, NR_PAGETABLE); + return true; +} + +static inline void pgtable_pmd_page_dtor(struct page *page) +{ + pmd_ptlock_free(page); + __ClearPageTable(page); + dec_zone_page_state(page, NR_PAGETABLE); +} + /* * No scalability reason to split PUD locks yet, but follow the same pattern * as the PMD locks to make it easier if we decide to. The VM should not be - Naresh