From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A8C6C432C0 for ; Tue, 26 Nov 2019 14:33:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3C7DE20722 for ; Tue, 26 Nov 2019 14:33:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oHPKKvkK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C7DE20722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C04696B0318; Tue, 26 Nov 2019 09:33:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB45E6B0319; Tue, 26 Nov 2019 09:33:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF32B6B031A; Tue, 26 Nov 2019 09:33:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0146.hostedemail.com [216.40.44.146]) by kanga.kvack.org (Postfix) with ESMTP id 9B3D76B0318 for ; Tue, 26 Nov 2019 09:33:24 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 653C33499 for ; Tue, 26 Nov 2019 14:33:24 +0000 (UTC) X-FDA: 76198671528.18.fear51_7501e24b31c4b X-HE-Tag: fear51_7501e24b31c4b X-Filterd-Recvd-Size: 4060 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Nov 2019 14:33:23 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id c124so11829893qkg.0 for ; Tue, 26 Nov 2019 06:33:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DjnyXfd1sXqy76Rl/2RI6nQAzOQl8OUc6HlCs+augLw=; b=oHPKKvkKVSmxQfinMzMb/jmZs40ROg9NeyjOuhqcq/rUzUOlE+EkGLCJkepiPnfyaO c3C2TlvFA6RfZ5gj7QGUaLQSS6N2qt2vN5HeHVbo68NHnxkGGC5kIVZlsklLBa/rn2ug rJSqzldezGu0VQvCqad3UaJyktyRF4dDhj06AHvRNKBIU3ZCDNnmkx8o/pWgmaBULysM 3AMXgaOTHFzMFmF8/VcvbeyiXTLJXS1ugk2/I5P9zN8QCbxBCoGyoXQ0MUp7OzfVcwws DYzHGGIO6Tb5sr1SsoRD+7J/YJB3ZNcsX8S3ozmPy+U7vlBNaCAihblIEynWCyJnmW33 QGDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DjnyXfd1sXqy76Rl/2RI6nQAzOQl8OUc6HlCs+augLw=; b=qRw1UylnmaSkvG0RdBs3XeGZrY6k2uTS1/URa7HzFQ0w6k+uy7pNPm17Ml3wYcbQFL 0YunB5lxmnIOb0t4K537mwnofM4jvevxhRNwrUpqARsWTWnTKpgLh1jT/9aY7ltBg/p/ GEasPy4T8VHVXldH6IXgH5U09Miea+adsw75Mwcu01sFhtheXc5WCV/drg6mhLQKKtRg 2EEgdxrvu2TY5d+W2ikn7QbdHCil65BZEbDnY8IWjfLpeNvttvgbABxFaXlJBcOhiKUb PQxl2abSkDW4//wNJTFyhjIppPaKguAHBXnIQ0PxzyGjeF2Ei6w6BTBGSFzj4EMejn93 xHAg== X-Gm-Message-State: APjAAAXdIU7fQ0PH+vOU+VmVwie/CLT4HH3iRJ0Yn/gUsiqUcNlYmh6t jdkyuSogdIHo3Mc7g1peZa12iCatJFBPGH0p8nk= X-Google-Smtp-Source: APXvYqzQydA1nBxmTnlE8Tl07A2lWJFWOnZxLriEvtWkXodkE5i5/U9SzP2Ak3CfGGV2exb9K6rHd4zV1D/pvAo0Vfo= X-Received: by 2002:a37:7305:: with SMTP id o5mr24672397qkc.120.1574778803438; Tue, 26 Nov 2019 06:33:23 -0800 (PST) MIME-Version: 1.0 References: <20191125145320.GA21484@haolee.github.io> In-Reply-To: From: Hao Lee Date: Tue, 26 Nov 2019 22:33:10 +0800 Message-ID: Subject: Re: [PATCH] mm: use the existing variable instead of a duplicate statement To: David Hildenbrand Cc: akpm@linux-foundation.org, Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 26 Nov 2019 at 20:13, David Hildenbrand wrote: > > On 25.11.19 15:53, Hao Lee wrote: > > The address of zone has been stored in variable 'zone', so there is no need > > to get it again with a duplicate statement. > > > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -363,22 +363,21 @@ unsigned long lruvec_lru_size(struct lruvec *lruvec, enum lru_list lru, int zone > > for (zid = zone_idx + 1; zid < MAX_NR_ZONES; zid++) { > > struct zone *zone = &lruvec_pgdat(lruvec)->node_zones[zid]; > > unsigned long size; > > > > if (!managed_zone(zone)) > > continue; > > > > if (!mem_cgroup_disabled()) > > size = mem_cgroup_get_zone_lru_size(lruvec, lru, zid); > > else > > - size = zone_page_state(&lruvec_pgdat(lruvec)->node_zones[zid], > > - NR_ZONE_LRU_BASE + lru); > > + size = zone_page_state(zone, NR_ZONE_LRU_BASE + lru); > > lru_size -= min(size, lru_size); > > } > > > > return lru_size; > > > > } > > Maybe tweak the subject to something meaningful: > > "mm/vmscan: reuse stored zone in lruvec_lru_size()" > > Reviewed-by: David Hildenbrand > Thanks. I get it! Regards, Hao Lee