From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 699EFC2B9F4 for ; Tue, 22 Jun 2021 15:13:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ED9C7611BF for ; Tue, 22 Jun 2021 15:13:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED9C7611BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DF4986B0070; Tue, 22 Jun 2021 11:13:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCBB16B0071; Tue, 22 Jun 2021 11:13:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C95E16B0074; Tue, 22 Jun 2021 11:13:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8BBB36B0070 for ; Tue, 22 Jun 2021 11:13:39 -0400 (EDT) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve04.hostedemail.com (Postfix) with ESMTP id 3209210F4E for ; Tue, 22 Jun 2021 13:54:38 +0000 (UTC) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E1ED38249980 for ; Tue, 22 Jun 2021 13:54:36 +0000 (UTC) X-FDA: 78281504952.14.FE1C335 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf24.hostedemail.com (Postfix) with ESMTP id A3E4DA0021D8 for ; Tue, 22 Jun 2021 13:54:36 +0000 (UTC) Received: by mail-ej1-f41.google.com with SMTP id gn32so7264189ejc.2 for ; Tue, 22 Jun 2021 06:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FByLAh6Nf6CrO0CmfvZoHDR68Ruso4bZUuWvxrdb7+g=; b=tA5vW637kCakI7hlfEOyVaNxytSpmD41CBKAyDpRHd4Nn3k0+ZOuUy4ktkdPl1/o62 P+dR7c0sevpmjUYfYJL03s+RVXxoH8OjCLZnvrA9iibyuUPgCllBgCyDKYuVeZ0+XBrg TWGcLxJPYLoXL9c17cezS9A2eVBZVnfY8tO5BCG1XwIwj/oCs+dekgk5yel8P2qPaAnw S7g3Xkr+GY7P/VEoaR9DljrLM+euVjfN1bu2FzbOvQBjjdqMjGm1kC+onLxtNjs2aEdp 4QSwPemSPqTKNGJMGn5YQEyTFYebMUjFjZYlfhczM2OPyFwDUaL/iKO6JiRPrZw78FjM dFDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FByLAh6Nf6CrO0CmfvZoHDR68Ruso4bZUuWvxrdb7+g=; b=QSTplxuI0adPKVxOHIwcrfyxujU65Eexz1LvwYv+M1wMxGCgmebNy1chHx1cU4pxez LKguaiC9p921+6sccTEMU13n8vuqcjkpExPydkImQSREtYlYn8fTkGkIJBe9WKKQWs9C yn0LT59TCV1lexPUvMC1LlcjHnPSxfYkpMyugTeUVZmgP9COpPejt6QJ1FAerkyaUswS wnW5iv/WNHgiCv/LzPg/5zY+KAe3ALifOHQEM83221f+FmhdKbGzFvQ22nNB1QWTefN0 RQwU7Z+ZPJMxwgw5ICJF5H1Pv40s/bsUSlQ9WAXWQ31Mw5+/WkoNHZDFURLZBSj67QW/ RwEw== X-Gm-Message-State: AOAM530qNy0vjkf6EXKeKz/X1xdP+h/Qeg8/cXL/zR98BnuGcYLYRw/x t/PtysgNIusdYOBPSq9WALoa3jF5A17JfNJDBvo= X-Google-Smtp-Source: ABdhPJx/V5oszBpwip0SxZHN++QihYaRpmfEKLkSDaCjMEhM4cmOUiXuiBz3yinojddOmwomdd+B4Q2fYeZRyy2KxAU= X-Received: by 2002:a17:906:2f91:: with SMTP id w17mr4164114eji.443.1624370074257; Tue, 22 Jun 2021 06:54:34 -0700 (PDT) MIME-Version: 1.0 References: <20210620114756.31304-1-Kuan-Ying.Lee@mediatek.com> <20210620114756.31304-2-Kuan-Ying.Lee@mediatek.com> In-Reply-To: <20210620114756.31304-2-Kuan-Ying.Lee@mediatek.com> From: Andrey Konovalov Date: Tue, 22 Jun 2021 16:54:14 +0300 Message-ID: Subject: Re: [PATCH v3 1/3] kasan: rename CONFIG_KASAN_SW_TAGS_IDENTIFY to CONFIG_KASAN_TAGS_IDENTIFY To: Kuan-Ying Lee Cc: Andrey Ryabinin , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , Matthias Brugger , kasan-dev , LKML , Linux Memory Management List , Linux ARM , linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com, chinwen.chang@mediatek.com, nicholas.tang@mediatek.com Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=tA5vW637; spf=pass (imf24.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A3E4DA0021D8 X-Stat-Signature: bi9e1uo5k6ez5fwpgosc9c4yrto37dqq X-HE-Tag: 1624370076-929753 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 20, 2021 at 2:48 PM Kuan-Ying Lee wrote: > > This patch renames CONFIG_KASAN_SW_TAGS_IDENTIFY to > CONFIG_KASAN_TAGS_IDENTIFY in order to be compatible > with hardware tag-based mode. > > Signed-off-by: Kuan-Ying Lee > Suggested-by: Marco Elver > Cc: Andrey Ryabinin > Cc: Alexander Potapenko > Cc: Andrey Konovalov > Cc: Dmitry Vyukov > Cc: Andrew Morton > --- > lib/Kconfig.kasan | 2 +- > mm/kasan/kasan.h | 4 ++-- > mm/kasan/report_sw_tags.c | 2 +- > mm/kasan/sw_tags.c | 4 ++-- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > index cffc2ebbf185..6f5d48832139 100644 > --- a/lib/Kconfig.kasan > +++ b/lib/Kconfig.kasan > @@ -155,7 +155,7 @@ config KASAN_STACK > CONFIG_COMPILE_TEST. On gcc it is assumed to always be safe > to use and enabled by default. > > -config KASAN_SW_TAGS_IDENTIFY > +config KASAN_TAGS_IDENTIFY > bool "Enable memory corruption identification" > depends on KASAN_SW_TAGS > help > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index 8f450bc28045..b0fc9a1eb7e3 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -153,7 +153,7 @@ struct kasan_track { > depot_stack_handle_t stack; > }; > > -#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > +#ifdef CONFIG_KASAN_TAGS_IDENTIFY > #define KASAN_NR_FREE_STACKS 5 > #else > #define KASAN_NR_FREE_STACKS 1 > @@ -170,7 +170,7 @@ struct kasan_alloc_meta { > #else > struct kasan_track free_track[KASAN_NR_FREE_STACKS]; > #endif > -#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > +#ifdef CONFIG_KASAN_TAGS_IDENTIFY > u8 free_pointer_tag[KASAN_NR_FREE_STACKS]; > u8 free_track_idx; > #endif > diff --git a/mm/kasan/report_sw_tags.c b/mm/kasan/report_sw_tags.c > index 3d20d3451d9e..821a14a19a92 100644 > --- a/mm/kasan/report_sw_tags.c > +++ b/mm/kasan/report_sw_tags.c > @@ -31,7 +31,7 @@ > > const char *kasan_get_bug_type(struct kasan_access_info *info) > { > -#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > +#ifdef CONFIG_KASAN_TAGS_IDENTIFY > struct kasan_alloc_meta *alloc_meta; > struct kmem_cache *cache; > struct page *page; > diff --git a/mm/kasan/sw_tags.c b/mm/kasan/sw_tags.c > index 9362938abbfa..dd05e6c801fa 100644 > --- a/mm/kasan/sw_tags.c > +++ b/mm/kasan/sw_tags.c > @@ -177,7 +177,7 @@ void kasan_set_free_info(struct kmem_cache *cache, > if (!alloc_meta) > return; > > -#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > +#ifdef CONFIG_KASAN_TAGS_IDENTIFY > idx = alloc_meta->free_track_idx; > alloc_meta->free_pointer_tag[idx] = tag; > alloc_meta->free_track_idx = (idx + 1) % KASAN_NR_FREE_STACKS; > @@ -196,7 +196,7 @@ struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > if (!alloc_meta) > return NULL; > > -#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > +#ifdef CONFIG_KASAN_TAGS_IDENTIFY > for (i = 0; i < KASAN_NR_FREE_STACKS; i++) { > if (alloc_meta->free_pointer_tag[i] == tag) > break; > -- > 2.18.0 > Reviewed-by: Andrey Konovalov