From: Andrey Konovalov <andreyknvl@gmail.com>
To: Marco Elver <elver@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Dmitry Vyukov <dvyukov@google.com>,
Alexander Potapenko <glider@google.com>,
Linux Memory Management List <linux-mm@kvack.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
mm-commits@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch 05/16] kasan: fix hwasan build for gcc
Date: Mon, 12 Apr 2021 14:54:45 +0200 [thread overview]
Message-ID: <CA+fCnZcnyp26oWKz8rEZya6kxWLWro_7yNyDCTmt84yx5Y-qZg@mail.gmail.com> (raw)
In-Reply-To: <YHQZVfVVLE/LDK2v@elver.google.com>
On Mon, Apr 12, 2021 at 11:56 AM Marco Elver <elver@google.com> wrote:
>
> On Fri, Apr 09, 2021 at 01:58PM -0700, Andrew Morton wrote:
> > On Fri, 9 Apr 2021 22:39:46 +0200 Andrey Konovalov <andreyknvl@gmail.com> wrote:
> >
> > > >
> > > > endif # CONFIG_KASAN_SW_TAGS
> > > > _
> > >
> > > Hi,
> > >
> > > As I commented on the patch, this breaks SW_TAGS build with Clang for me with:
> > >
> > > arch/arm64/include/asm/current.h:19: undefined reference to `__hwasan_tls'
> > >
> > > The reason for this is that cc-param is only defined for
> > > KASAN_GENERIC, the definition needs to be moved.
> > >
> >
> > Oh. I thought that had been fixed.
> >
> > Please send a patch?
>
> I think we need something like the below.
>
> Unless a fixed version has already been sent, feel free to squash
> (applies immediately after "kasan: fix hwasan build for gcc", and before
> the conflicting "kasan: remove redundant config option").
>
> Thanks,
> -- Marco
>
> ------ >8 ------
>
> From: Marco Elver <elver@google.com>
> Date: Sun, 11 Apr 2021 21:32:01 +0200
> Subject: [PATCH] fixup for "kasan: fix hwasan build for gcc"
>
> Signed-off-by: Marco Elver <elver@google.com>
> ---
> scripts/Makefile.kasan | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/Makefile.kasan b/scripts/Makefile.kasan
> index 0a2789783d1b..127012f45166 100644
> --- a/scripts/Makefile.kasan
> +++ b/scripts/Makefile.kasan
> @@ -2,6 +2,8 @@
> CFLAGS_KASAN_NOSANITIZE := -fno-builtin
> KASAN_SHADOW_OFFSET ?= $(CONFIG_KASAN_SHADOW_OFFSET)
>
> +cc-param = $(call cc-option, -mllvm -$(1), $(call cc-option, --param $(1)))
> +
> ifdef CONFIG_KASAN_GENERIC
>
> ifdef CONFIG_KASAN_INLINE
> @@ -12,8 +14,6 @@ endif
>
> CFLAGS_KASAN_MINIMAL := -fsanitize=kernel-address
>
> -cc-param = $(call cc-option, -mllvm -$(1), $(call cc-option, --param $(1)))
> -
> # -fasan-shadow-offset fails without -fsanitize
> CFLAGS_KASAN_SHADOW := $(call cc-option, -fsanitize=kernel-address \
> -fasan-shadow-offset=$(KASAN_SHADOW_OFFSET), \
> --
> 2.31.1.295.g9ea45b61b8-goog
>
This fix-up looks good to me.
Thank you, Marco!
next prev parent reply other threads:[~2021-04-12 12:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 20:26 incoming Andrew Morton
2021-04-09 20:27 ` [patch 01/16] MAINTAINERS: update CZ.NIC's Turris information Andrew Morton
2021-04-09 20:27 ` [patch 02/16] treewide: change my e-mail address, fix my name Andrew Morton
2021-04-09 20:27 ` [patch 03/16] mailmap: update email address for Jordan Crouse Andrew Morton
2021-04-09 20:27 ` [patch 04/16] .mailmap: fix old email addresses Andrew Morton
2021-04-09 20:27 ` [patch 05/16] kasan: fix hwasan build for gcc Andrew Morton
2021-04-09 20:39 ` Andrey Konovalov
2021-04-09 20:58 ` Andrew Morton
2021-04-12 9:56 ` Marco Elver
2021-04-12 12:54 ` Andrey Konovalov [this message]
2021-04-09 21:55 ` Linus Torvalds
2021-04-09 20:27 ` [patch 06/16] kasan: remove redundant config option Andrew Morton
2021-04-09 20:27 ` [patch 07/16] mm/gup: check page posion status for coredump Andrew Morton
2021-04-09 20:27 ` [patch 08/16] nds32: flush_dcache_page: use page_mapping_file to avoid races with swapoff Andrew Morton
2021-04-09 20:27 ` [patch 09/16] gcov: re-fix clang-11+ support Andrew Morton
2021-04-09 20:27 ` [patch 10/16] ocfs2: fix deadlock between setattr and dio_end_io_write Andrew Morton
2021-04-09 20:27 ` [patch 11/16] ia64: fix user_stack_pointer() for ptrace() Andrew Morton
2021-04-09 20:27 ` [patch 12/16] fs: direct-io: fix missing sdio->boundary Andrew Morton
2021-04-09 20:27 ` [patch 13/16] kasan: fix conflict with page poisoning Andrew Morton
2021-04-09 20:27 ` [patch 14/16] lib/test_kasan_module.c: suppress unused var warning Andrew Morton
2021-04-09 20:27 ` [patch 15/16] kfence, x86: fix preemptible warning on KPTI-enabled systems Andrew Morton
2021-04-09 20:27 ` [patch 16/16] lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+fCnZcnyp26oWKz8rEZya6kxWLWro_7yNyDCTmt84yx5Y-qZg@mail.gmail.com \
--to=andreyknvl@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=linux-mm@kvack.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mm-commits@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ryabinin.a.a@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).