From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 632D3C433EF for ; Wed, 16 Feb 2022 20:42:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA88C6B0071; Wed, 16 Feb 2022 15:42:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A58776B0075; Wed, 16 Feb 2022 15:42:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91FFC6B0078; Wed, 16 Feb 2022 15:42:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 840E96B0071 for ; Wed, 16 Feb 2022 15:42:35 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 31555181AC9C6 for ; Wed, 16 Feb 2022 20:42:35 +0000 (UTC) X-FDA: 79149816270.17.3A37F38 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by imf01.hostedemail.com (Postfix) with ESMTP id 99B1C40008 for ; Wed, 16 Feb 2022 20:42:34 +0000 (UTC) Received: by mail-io1-f52.google.com with SMTP id x13so1216266iop.4 for ; Wed, 16 Feb 2022 12:42:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vkHFJYvYVkKYBcB7iK0KWU7QvRr9ZBff0a6WbJBCpHQ=; b=l5ABOM2nj9+mns6PKN+jKYIK1X4cEIhbWdWpZDho+hWH+SUK5JBh24RapaHjKyB345 smKzpit9wOYzv/3WQSNpJyo+Pr26BhWAahMPpenMpHS91V7d0oUDJW4XnqZP6rhHAr8M ingqBYI+4zRkNrBTOhbEhnfUM8Ff7Wlmk+Nsd0M4ErJjmOG7e3ymLE+GBAgVZ0dpmGEt Tv1iZanyVJqp95/KK8n0lxH9c6z5hgb2TQhC53YX7y55hBN4f+mDygaXeSP0PFCmMr7x TZfo8Y3zOKRdhcN/r0D3N4eLazM7boBurOsOs/mkzj84LClMZ+JhM/bu6Uk2uxbbroVK uJvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vkHFJYvYVkKYBcB7iK0KWU7QvRr9ZBff0a6WbJBCpHQ=; b=V9lfxq47W/veOf1ZBJTBmsoz9n6vhE9tGnfQeuVDmywHA1wSGH6noz7iaKReqDu5ed AknXrQGntJ+J/WM0BzfCz9XC3YjXGo+2ivyNKAT8LxNPXWCWAN5O/feRJzIny7ujrS+q InnwchkWBtxmdTzcUkPOwOr8M7LLMWKLx/L8C9bw2F+yaQgSMOw87MhOSPmhjpCXzt9x sKYgaKFnd9aTxkNc4RfZA3ankO7wt6vOEJI6vkwpXYGX/F/aI4EtNeHgaDamDwXSh/EN GViX2ZVrIfVulu3jB2D0Ix56aqkzj+hBM/I15IJfep2F2gaih8bOP2ryiH39u15SNjYZ VymA== X-Gm-Message-State: AOAM531ozpjSvGRPSiC9NRu1YvPcjHZZzbmVLfwRg3VN8bW9OXeKpejw bFMODcC/RYLKQ1kybTf5Wn01J1uEweftHSBpEKc= X-Google-Smtp-Source: ABdhPJzmsdyC0hQQB7IFocQsue8DyUPQjEaRe5d+gseybDvolIfDUHELU0Uus9DTI0fM+LpC981cDxlRh3kE7ZKdmTE= X-Received: by 2002:a05:6638:13c5:b0:313:f0f6:2346 with SMTP id i5-20020a05663813c500b00313f0f62346mr2833881jaj.218.1645044153997; Wed, 16 Feb 2022 12:42:33 -0800 (PST) MIME-Version: 1.0 References: <5b120f7cadcc0e0d8d5f41fd0cff35981b3f7f3a.1645038022.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Wed, 16 Feb 2022 21:42:23 +0100 Message-ID: Subject: Re: [PATCH mm] kasan: print virtual mapping info in reports To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Andrew Morton , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Vincenzo Frascino , Catalin Marinas , Linux Memory Management List , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 99B1C40008 X-Stat-Signature: kntah1fis4goad1wde5oo6w9kenfwc7u X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=l5ABOM2n; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.52 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-HE-Tag: 1645044154-450823 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 16, 2022 at 8:31 PM Marco Elver wrote: > > On Wed, 16 Feb 2022 at 20:01, wrote: > > > > From: Andrey Konovalov > > > > Print virtual mapping range and its creator in reports affecting virtual > > mappings. > > > > Also get physical page pointer for such mappings, so page information > > gets printed as well. > > > > Signed-off-by: Andrey Konovalov > > > > --- > > > > Note: no need to merge this patch into any of the KASAN vmalloc patches > > that are already in mm, better to keep it separate. > > --- > > mm/kasan/report.c | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > > index 137c2c0b09db..8002fb3c417d 100644 > > --- a/mm/kasan/report.c > > +++ b/mm/kasan/report.c > > @@ -260,8 +260,18 @@ static void print_address_description(void *addr, u8 tag) > > pr_err(" %pS\n", addr); > > } > > > > + if (is_vmalloc_addr(addr)) { > > + struct vm_struct *va = find_vm_area(addr); > > + > > + pr_err("The buggy address belongs to the virtual mapping at\n" > > + " [%px, %px) created by:\n" > > + " %pS\n", va->addr, va->addr + va->size, va->caller); > > Can you show an example of what this looks like? [ 20.883723] The buggy address belongs to the virtual mapping at [ 20.883723] [ffff8000081c9000, ffff8000081cb000) created by: [ 20.883723] vmalloc_oob+0xd8/0x4dc > It's not showing a stack trace, No, only a single frame. > so why not continue the line and just say "... created by: %pS\n" Putting it on a separate line makes the line lengths looks more balanced. Also, printing a frame on a separate line is consistent with the rest of KASAN reporting code.