From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D8CFC54EE9 for ; Tue, 20 Sep 2022 19:21:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA96F940008; Tue, 20 Sep 2022 15:21:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A58DD940007; Tue, 20 Sep 2022 15:21:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92068940008; Tue, 20 Sep 2022 15:21:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7FB69940007 for ; Tue, 20 Sep 2022 15:21:10 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 57A1E16034E for ; Tue, 20 Sep 2022 19:21:10 +0000 (UTC) X-FDA: 79933431900.04.0C7F243 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) by imf19.hostedemail.com (Postfix) with ESMTP id 16B421A000E for ; Tue, 20 Sep 2022 19:21:09 +0000 (UTC) Received: by mail-qv1-f54.google.com with SMTP id s13so2754672qvq.10 for ; Tue, 20 Sep 2022 12:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=2fFnFfvF7l44JixGUwp4lrsIFX8DjQoBBv2Lr/mkNP0=; b=DaxAZMRn+z6gfdx54XhmmOabl6/upL90LxgL1FK8rbacRTFR0nR/b0jkn9rQuqcNHH VC03c8be4EAT+gxtRTYGpq/z445948cfhsxbH5A8EQJEZc/RTUad0n/6cbCtNUcq2JK7 p6/35WU4J8P+6ntQuZc8Q2UR2Tk27B4azbT1QB1D6b42M2KtFfbYkwOrxqbSRCq0LzsJ OFHXCOX1WGRaga6kEXKt/Upm+J1AlLJvwAnEOmfB8NuKUUY9qT6PoL4kl3QRtfJaP+HF YMEprrDWix/vV1KLF1B3e/tWYv2KldXwXDMbVeS11Z9d9AjM2TKArxgE/2VhEyufhKbM JtWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=2fFnFfvF7l44JixGUwp4lrsIFX8DjQoBBv2Lr/mkNP0=; b=wfCQ+c4cJrO7LujIMarhCKi02rORt9C0efCv39mrmqGuwETCNCd4A6nyBwfYzyScem 8zxGAnISx+orDuSFKgd2u6Isk3chJZEf4fi+GQrVk9o0LCT0XrVgzNZbMzd2/P/7ANug QuZVzN0wvj3aoY/H6kTZo1JOFtVGrjJhPabADHaQZ2dCO10aKlOnxIDONO0zbo0UZRco 2Xk7dhky6KXcnMGI/QDD/X3mQ+gWdlQ3EqERcSK5+ZIaMzOJP9ACIsfrhLjR+q2xQdFs I2Mq6umrPzsY3x/BMwYbAu/SsE11OFbsqJv6t+s5wP9lLyFspBiFCtkTszQ0jf4n4i+0 SSfQ== X-Gm-Message-State: ACrzQf00I8bg+g/YZCMC3sQean4XLHR6vl+cSA8JiTGE4Op+ua2xxEnu zxEUJFf5ktj8VCQLhhmrXC6YO2kvXpP/DeXZ8dk= X-Google-Smtp-Source: AMsMyM6nElpG8fYLz4yWt+NdcHYGKiIqfT0ZO7yO5Telew+swSrzQgXJVCjrR9Ry4q2bGmgXHWltSuDRcKorZaXIG5o= X-Received: by 2002:a05:6214:c48:b0:4ac:b18d:c101 with SMTP id r8-20020a0562140c4800b004acb18dc101mr20513445qvj.107.1663701669341; Tue, 20 Sep 2022 12:21:09 -0700 (PDT) MIME-Version: 1.0 References: <20220913065423.520159-1-feng.tang@intel.com> <20220913065423.520159-4-feng.tang@intel.com> In-Reply-To: <20220913065423.520159-4-feng.tang@intel.com> From: Andrey Konovalov Date: Tue, 20 Sep 2022 21:20:58 +0200 Message-ID: Subject: Re: [PATCH v6 3/4] mm: kasan: Add free_meta size info in struct kasan_cache To: Feng Tang Cc: Andrew Morton , Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Dmitry Vyukov , Jonathan Corbet , Dave Hansen , Linux Memory Management List , LKML , kasan-dev , kernel test robot Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663701670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2fFnFfvF7l44JixGUwp4lrsIFX8DjQoBBv2Lr/mkNP0=; b=7uNN5nAHduxoJTyXoDpmj0vYwM/y+Gz56WLCQ3pPjBzSA99HGeIcGSEw4ilvQcURnzqdEs HJ9oKh+a0v/HyeSP7s24aTFStsDn2HZs/KfqtbYg3YtFH4SA8cKGR4VLEdQmzD9xK6kO5D NE7eE0Mm9Fj34I8KyDNwXHcPs4yAIos= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DaxAZMRn; spf=pass (imf19.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.219.54 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663701670; a=rsa-sha256; cv=none; b=4z/Y+9etLf3TNg/exW5qPuprCrhn8Q43Ivy00D5gEvKTnLA53IHBL4wbHf3wHLoxQHDcls hnwj6yekbSIEZvZMbfiIAYY8xCAxuju0Kbg3zgNyhNIauokf4cDmjozqT6B5SD6/LYLbcM n9h9Ua+0PAD5dhFkeplSqnLOgzx7Wro= X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DaxAZMRn; spf=pass (imf19.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.219.54 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: 16c5urchpan3wt4ze1hbujfgd3te7hhd X-Rspamd-Queue-Id: 16B421A000E X-HE-Tag: 1663701669-355593 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 13, 2022 at 8:54 AM Feng Tang wrote: > > When kasan is enabled for slab/slub, it may save kasan' free_meta > data in the former part of slab object data area in slab object's > free path, which works fine. > > There is ongoing effort to extend slub's debug function which will > redzone the latter part of kmalloc object area, and when both of > the debug are enabled, there is possible conflict, especially when > the kmalloc object has small size, as caught by 0Day bot [1] > > For better information for slab/slub, add free_meta's data size > into 'struct kasan_cache', so that its users can take right action > to avoid data conflict. > > [1]. https://lore.kernel.org/lkml/YuYm3dWwpZwH58Hu@xsang-OptiPlex-9020/ > Reported-by: kernel test robot > Signed-off-by: Feng Tang > Acked-by: Dmitry Vyukov > --- > include/linux/kasan.h | 2 ++ > mm/kasan/common.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index b092277bf48d..49af9513e8ed 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -100,6 +100,8 @@ static inline bool kasan_has_integrated_init(void) > struct kasan_cache { > int alloc_meta_offset; > int free_meta_offset; > + /* size of free_meta data saved in object's data area */ > + int free_meta_size; > bool is_kmalloc; > }; > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 69f583855c8b..0cb867e92524 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -201,6 +201,8 @@ void __kasan_cache_create(struct kmem_cache *cache, unsigned int *size, > cache->kasan_info.free_meta_offset = KASAN_NO_FREE_META; > *size = ok_size; > } > + } else { > + cache->kasan_info.free_meta_size = sizeof(struct kasan_free_meta); Hi Feng, I just realized that we already have a function that exposes a similar functionality: kasan_metadata_size. However, this function returns the size of metadata that is stored in the redzone. I think, instead of adding free_meta_size, a better approach would be to: 1. Rename kasan_metadata_size to kasan_metadata_size_in_redzone (or something like that). 2. Add kasan_metadata_size_in_object with appropriate implementation and use that in your patches. This allows avoiding exposing KASAN-internal details such as what kind of fields the kasan_cache struct has to the common code. Sorry for nor realizing this straight away. (Note that there's an upcoming patch that fixes a bug in kasan_metadata_size' implementation [1].) Thanks! [1] https://lore.kernel.org/linux-mm/c7b316d30d90e5947eb8280f4dc78856a49298cf.1662411799.git.andreyknvl@google.com/ > } > > /* Calculate size with optimal redzone. */ > -- > 2.34.1 >