From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE9C3ECAAD3 for ; Sat, 10 Sep 2022 23:15:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79A578D0001; Sat, 10 Sep 2022 19:15:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 721F66B0072; Sat, 10 Sep 2022 19:15:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C3068D0001; Sat, 10 Sep 2022 19:15:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 46E6E6B0071 for ; Sat, 10 Sep 2022 19:15:07 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1D342AB114 for ; Sat, 10 Sep 2022 23:15:07 +0000 (UTC) X-FDA: 79897733454.23.4D24329 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf05.hostedemail.com (Postfix) with ESMTP id C5D3B100098 for ; Sat, 10 Sep 2022 23:15:06 +0000 (UTC) Received: by mail-qt1-f179.google.com with SMTP id a20so1200186qtw.10 for ; Sat, 10 Sep 2022 16:15:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=w2iwfAfjmm20Z/nVGluOZ//otBXBhnUx+0kh6uIL9eU=; b=iSX3eG5Hl5kGjfusxIiWlcV4NhikAleW1R5zSBUe+WjlKp9VsK2uWUEaUsdt25nY/j LHR3Zd9NkjBKs8WBMRFvG33yi35iWNfpnh+G2LNdkL7rXtSqQ0rQt5Z7tD90eka6KC4X AwmaOvvuAT4pb7T4tz2Nv2sMbFvq5BZ6WBGUqsRSoCChKNRNK4pbNLT2OSvfisHi62F+ oVhVvePn8EM1KVY78zjZGBx2q7WtJyRH2Dg9aDp4/nMu7+n9oVk5TzBuRSJini5LlOyJ 1L+7B7D1q2ye/WXp9+GFF8X2IMWIAFhqLVqHxqM0eaDaCnVpA+NId0CnHm5+tJeEG/dm NIvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=w2iwfAfjmm20Z/nVGluOZ//otBXBhnUx+0kh6uIL9eU=; b=0uBWRafSs3rsP5RHle9Xs5kGKMSUsOe8wCNCKr04kjY8NPR67UJnRsTcGF2dAxWq6t dVDcrn8u1HPzPUns49flUR/M05O1IFRVE058N91Cd9dWBq5ESoPjSrEcDgtmYPaU7jXB cv+aRJtiE3DMjx4RsK+49JcuiiF28Q5FJjHN6KGAtjBb26MqPB/gwJ9Bw4OnxyvH6+31 0/liuKaAhxhNpGSHebD82VLLCEo2QLF3rl8yd5n+hMh8QcY9Ysicc+NtVSuJ6NO12mVg ZHE/y2D6cT6Js7PjlPofwqhruO/FGQ06S4YGjgbnph8UFjIleI8NU+AH4coyqtGn7KHf 2w8g== X-Gm-Message-State: ACgBeo01sQ68Cm4sx9ZZ4dg9fSpOUP4sKzzWGEwK0s3c+QGTntW3AJ7q xOAFaYbc4j6eM6D80VA2KuX2DjQyXUh8TxjR+pY= X-Google-Smtp-Source: AA6agR50c6VuB0iUAz7cjL6BCPfhd8Qxt1aoqMkHA4aCvJRxKKiv8jZ8eFphXQLzIzrSnzKHfA9pK8iS+wAUSlW8zzU= X-Received: by 2002:a05:622a:14d1:b0:344:b14a:b22a with SMTP id u17-20020a05622a14d100b00344b14ab22amr17595430qtx.203.1662851706097; Sat, 10 Sep 2022 16:15:06 -0700 (PDT) MIME-Version: 1.0 References: <20220907071023.3838692-1-feng.tang@intel.com> <20220907071023.3838692-4-feng.tang@intel.com> In-Reply-To: <20220907071023.3838692-4-feng.tang@intel.com> From: Andrey Konovalov Date: Sun, 11 Sep 2022 01:14:55 +0200 Message-ID: Subject: Re: [PATCH v5 3/4] mm: kasan: Add free_meta size info in struct kasan_cache To: Feng Tang Cc: Andrew Morton , Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Dmitry Vyukov , Jonathan Corbet , Dave Hansen , Linux Memory Management List , LKML , kasan-dev , kernel test robot Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662851706; a=rsa-sha256; cv=none; b=mu2sdeWeD/q9WT9fCii1u5ofHshO/vXexh4/Vgqrvk0+y0h4CHDVBLKdpowdg4z99inRp1 Tr4KQBvGcY8f356t0Y1VZLacW6BUpUy7kIrfuUB4SneLQsJ+dX0O5AfJT2+MqfKH2IHx1N I6B9QYPRn9jpxSFLxbxbqcbhF/mSO9w= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iSX3eG5H; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662851706; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w2iwfAfjmm20Z/nVGluOZ//otBXBhnUx+0kh6uIL9eU=; b=N4NYnEXadwqBdbLwNBMPgtoiWvcFElAZX0j3wBBAzgdwC7EQgOsNJ9UxxWaWcFqBt3/WLz KIIJnubZGfUqxW9U9t7igq48PxLR+Gt44Fvm4l5+JFLCMkAfl/6vU8+Is5oDSz+liCefFf HmzAq3CAsCbdp0Wgqyl95BxVQbkKkSg= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C5D3B100098 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iSX3eG5H; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-Stat-Signature: dktjcyu8jcgi8xnzjpi546buskzu4kjp X-Rspam-User: X-HE-Tag: 1662851706-291731 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 7, 2022 at 9:11 AM Feng Tang wrote: > > When kasan is enabled for slab/slub, it may save kasan' free_meta > data in the former part of slab object data area in slab object > free path, which works fine. > > There is ongoing effort to extend slub's debug function which will > redzone the latter part of kmalloc object area, and when both of > the debug are enabled, there is possible conflict, especially when > the kmalloc object has small size, as caught by 0Day bot [1] > > For better information for slab/slub, add free_meta's data size > into 'struct kasan_cache', so that its users can take right action > to avoid data conflict. > > [1]. https://lore.kernel.org/lkml/YuYm3dWwpZwH58Hu@xsang-OptiPlex-9020/ > Reported-by: kernel test robot > Signed-off-by: Feng Tang > Acked-by: Dmitry Vyukov > --- > include/linux/kasan.h | 2 ++ > mm/kasan/common.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index b092277bf48d..293bdaa0ba09 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -100,6 +100,8 @@ static inline bool kasan_has_integrated_init(void) > struct kasan_cache { > int alloc_meta_offset; > int free_meta_offset; > + /* size of free_meta data saved in object's data area */ > + int free_meta_size_in_object; I thinks calling this field free_meta_size is clear enough. Thanks! > bool is_kmalloc; > }; > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 69f583855c8b..762ae7a7793e 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -201,6 +201,8 @@ void __kasan_cache_create(struct kmem_cache *cache, unsigned int *size, > cache->kasan_info.free_meta_offset = KASAN_NO_FREE_META; > *size = ok_size; > } > + } else { > + cache->kasan_info.free_meta_size_in_object = sizeof(struct kasan_free_meta); > } > > /* Calculate size with optimal redzone. */ > -- > 2.34.1 > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20220907071023.3838692-4-feng.tang%40intel.com.