From: Lorenzo Stoakes <lstoakes@gmail.com> To: Andrey Konovalov <andreyknvl@google.com> Cc: Qian Cai <cai@redhat.com>, syzbot <syzbot+2d6f3dad1a42d86a5801@syzkaller.appspotmail.com>, Andrew Morton <akpm@linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Linux Memory Management List <linux-mm@kvack.org>, Linux-Next Mailing List <linux-next@vger.kernel.org>, Stephen Rothwell <sfr@canb.auug.org.au>, syzkaller-bugs <syzkaller-bugs@googlegroups.com>, Dmitry Vyukov <dvyukov@google.com>, Alexander Potapenko <glider@google.com>, Marco Elver <elver@google.com> Subject: Re: linux-next boot error: BUG: unable to handle kernel NULL pointer dereference in mempool_init_node Date: Wed, 11 Nov 2020 19:26:47 +0000 [thread overview] Message-ID: <CAA5enKY8mBicpc7kZKKLG5LeVFhVJtRQ73MYVFM0Az2bbiGv8g@mail.gmail.com> (raw) In-Reply-To: <CAAeHK+yLgDYOS35sWT8=4_d-gZKU_B10D9ZEBPZDC1P6MO2D6Q@mail.gmail.com> On Wed, 11 Nov 2020 at 17:44, Andrey Konovalov <andreyknvl@google.com> wrote: > I'll try to reproduce this and figure out the issue. Thanks for letting us know! I hope you don't mind me diving in here, I was taking a look just now and managed to reproduce this locally - I bisected the issue to 105397399 ("kasan: simplify kasan_poison_kfree"). If I stick a simple check in as below it fixes the issue, so I'm guessing something is violating the assumptions in 105397399? diff --git a/mm/kasan/common.c b/mm/kasan/common.c index 7a94cebc0324..16163159a017 100644 --- a/mm/kasan/common.c +++ b/mm/kasan/common.c @@ -387,6 +387,11 @@ void __kasan_slab_free_mempool(void *ptr, unsigned long ip) struct page *page; page = virt_to_head_page(ptr); + + if (!PageSlab(page)) { + return; + } + ____kasan_slab_free(page->slab_cache, ptr, ip, false); } -- Lorenzo Stoakes https://ljs.io
next prev parent reply other threads:[~2020-11-11 19:27 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-11 7:45 syzbot 2020-11-11 16:25 ` Qian Cai 2020-11-11 17:43 ` Andrey Konovalov 2020-11-11 19:26 ` Lorenzo Stoakes [this message] 2020-11-11 19:44 ` Andrey Konovalov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAA5enKY8mBicpc7kZKKLG5LeVFhVJtRQ73MYVFM0Az2bbiGv8g@mail.gmail.com \ --to=lstoakes@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=andreyknvl@google.com \ --cc=cai@redhat.com \ --cc=dvyukov@google.com \ --cc=elver@google.com \ --cc=glider@google.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-next@vger.kernel.org \ --cc=sfr@canb.auug.org.au \ --cc=syzbot+2d6f3dad1a42d86a5801@syzkaller.appspotmail.com \ --cc=syzkaller-bugs@googlegroups.com \ --subject='Re: linux-next boot error: BUG: unable to handle kernel NULL pointer dereference in mempool_init_node' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).