From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9779C4332F for ; Wed, 27 Apr 2022 16:07:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DAC06B008A; Wed, 27 Apr 2022 12:07:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43B646B008C; Wed, 27 Apr 2022 12:07:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28EF46B0092; Wed, 27 Apr 2022 12:07:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 168816B008A for ; Wed, 27 Apr 2022 12:07:53 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 78F7D28D77 for ; Wed, 27 Apr 2022 16:07:52 +0000 (UTC) X-FDA: 79403139984.26.5D2A04E Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf17.hostedemail.com (Postfix) with ESMTP id 8BF2440098 for ; Wed, 27 Apr 2022 16:07:33 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id r9so1868840pjo.5 for ; Wed, 27 Apr 2022 09:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=no2dRxhaPo5kKkkNtYDviUL8aWZxcIpM0ihWfE784Qo=; b=QSugq2x0W9ZgFZS2awb0WG1lP1D6yw+gw1IeXAl14ic+8y8v4p/ptpenf+qyKnO/aP PtDMqmvYgNp7f5ji3XOX9KSZBcjjTH1W5s29F16RqsAhYBzAw/173R2GBEnaGHKabzk7 LRa74Ag+maLLZ7cOva724Wvu+fNrrndGJodwNBSWsFT9yrqQqQH4CQkib7hs74qVqrZV wjgyIY/DvcbYflbFFz/soFDlXspEu6X7kJt84WRQy/eEoermUy4a8BoMc6MFlRD/9Cpw YMfJdMNn4IKO++kv9ylkRPfmy6LF8MYM13x46HIax9NIIQv6j1cNB2SHJr6Uq6KYAXyR icJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=no2dRxhaPo5kKkkNtYDviUL8aWZxcIpM0ihWfE784Qo=; b=p4Ei0OLagze23GlCc2a1yLjcrdpUYz/T3W0R3EPtW7DwEe6065x1JwT+lysJpPY8ry Dp/V15/d9p4YyrZQ5tx2TmmmtTrIzEVFT4BmuUew4zOKN/d4S5RgOMmFam8dqCutmNA0 6NjPv5UCwujqbt4CTe0CfFq84cnh8j5eau7Je+YVT+t14DupD6z2xieaXHnV3rNdDk90 1l+5fZbaHy/SKd+1gP20bhJvKuZWQRpshxqp2MZ5OC+Hp36bMPSEVs5NQI7rE0njSN2n bROveT83+JflVcM4aCdui+Uq6ocTLBC6FnpZrP2VjDjWvfYClqZiPQjkPkpGWAtmzDvb SYCA== X-Gm-Message-State: AOAM530Q2KyC+0jWVz3Uk1z+ZAqHN3o5nTdA+sNdp9TqgjuZ34scQUME OPqu5buFV+ATHQOz4VKb5zMb1gMvuk3v8nQjohU= X-Google-Smtp-Source: ABdhPJyJiYeFLo2KCPfmWmqXn3NYPJKWYK4GgiOxpR72sCQj0AxvJmSjoEeR1qTP7EuM8zgMlcNrDZq5Rz4ueQkrbQ8= X-Received: by 2002:a17:90a:8591:b0:1b9:da10:2127 with SMTP id m17-20020a17090a859100b001b9da102127mr44674409pjn.13.1651075660046; Wed, 27 Apr 2022 09:07:40 -0700 (PDT) MIME-Version: 1.0 References: <202204271656.OTIj2QNJ-lkp@intel.com> In-Reply-To: From: Alexei Starovoitov Date: Wed, 27 Apr 2022 09:07:29 -0700 Message-ID: Subject: Re: [PATCH] libbpf: fix returnvar.cocci warnings To: kernel test robot , Julia Lawall Cc: Andrii Nakryiko , kbuild-all@lists.01.org, Linux Memory Management List , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Network Development , bpf , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 8BF2440098 X-Stat-Signature: hn1gfzfaj5zpngdxepmy8crocehqthck X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QSugq2x0; spf=pass (imf17.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam09 X-HE-Tag: 1651075653-72982 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 27, 2022 at 1:04 AM kernel test robot wrote: > > From: kernel test robot > > tools/lib/bpf/relo_core.c:1064:8-11: Unneeded variable: "len". Return "0" on line 1086 > > > Remove unneeded variable used to store return value. > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > Fixes: b58af63aab11 ("libbpf: Refactor CO-RE relo human description formatting routine") > CC: Andrii Nakryiko > Reported-by: kernel test robot > Signed-off-by: kernel test robot > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: f02ac5c95dfd45d2f50ecc68d79177de326c668c > commit: b58af63aab11e4ae00fe96de9505759cfdde8ee9 [6746/7265] libbpf: Refactor CO-RE relo human description formatting routine > :::::: branch date: 2 hours ago > :::::: commit date: 9 hours ago > > tools/lib/bpf/relo_core.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > --- a/tools/lib/bpf/relo_core.c > +++ b/tools/lib/bpf/relo_core.c > @@ -1061,7 +1061,7 @@ static int bpf_core_format_spec(char *bu > const struct btf_enum *e; > const char *s; > __u32 type_id; > - int i, len = 0; > + int i; > > #define append_buf(fmt, args...) \ > ({ \ > @@ -1083,7 +1083,7 @@ static int bpf_core_format_spec(char *bu > type_id, btf_kind_str(t), str_is_empty(s) ? "" : s); > > if (core_relo_is_type_based(spec->relo_kind)) > - return len; > + return 0; cocci is wrong. It missed append_buf() macro. Please fix cocci so we don't have to manually deal with broken patches like this one.