From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23EF9C4727E for ; Wed, 7 Oct 2020 14:12:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 65DAA212CC for ; Wed, 7 Oct 2020 14:12:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="d8LN7dGO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65DAA212CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6B6166B006E; Wed, 7 Oct 2020 10:12:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 665666B0070; Wed, 7 Oct 2020 10:12:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52DC88E0001; Wed, 7 Oct 2020 10:12:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id 277B76B006E for ; Wed, 7 Oct 2020 10:12:16 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B4F2C3620 for ; Wed, 7 Oct 2020 14:12:15 +0000 (UTC) X-FDA: 77345319030.09.peace91_0701da5271cf Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 8505B180AD806 for ; Wed, 7 Oct 2020 14:12:15 +0000 (UTC) X-HE-Tag: peace91_0701da5271cf X-Filterd-Recvd-Size: 8607 Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Wed, 7 Oct 2020 14:12:14 +0000 (UTC) Received: by mail-ej1-f65.google.com with SMTP id a3so3143306ejy.11 for ; Wed, 07 Oct 2020 07:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YFB+tdyXOtCPNmNlbyeGl25fBeChj1S+VT6tzzLEZ78=; b=d8LN7dGO3Ag/inP5rvlWv5j43byrHe3f2u6a2r5SiIA/iuBN1VvbkR0plJSfSgqBlh Xu6ol8DY8sIaLVYX8C/ptKWjmAW3b06V+W6maw4cEpyWOcxb/M9F7iw98CO5YNTALD0W RHBCozGcvxlKPGX6uoYJpCQxNytt1WigBKfUE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YFB+tdyXOtCPNmNlbyeGl25fBeChj1S+VT6tzzLEZ78=; b=T7h8O7Hm6jcihukYb++tZKAUgjDJbPdJ43YakGLlD48F69H6LPXiwpLvqGrwy1ZUYf R+DEdDGDflpMkrNbfG8pE9X/pSJseAR6c5wWuLGTG9LIeCveeAc6tAd9ykj9hJFokseo dgGG2XH0SjIj/YRn7QfTBzwniBCRt/u+pyBIhuiZ+7+nE1ECxacQho2dZGJRXT5hVIHR GD7sGizTpDej2ZUUyjSrksRBWRfB097WX1un/z9DokxTxFDdPPaV1N2uhLsSeH/8dQkv ElCUIChJw76AbAoiGJxNN+rSy8EiWmwvJbjTbY+tJHvgAl4JszSwaEzaLpbGgdPyMlYN d5nw== X-Gm-Message-State: AOAM530VlcgooZfpQebFnfwtoNUKtA3+0CkYV2hditoSQGef16yGazo/ xakTq67u4DIbWWmlaaD4ZpDuZ+SBpGVMbA== X-Google-Smtp-Source: ABdhPJwCjIInIhE9WoIjdcbryUHUEJafTT2Cnw5j+TlqXyyy/D1hO3EEwZiSHEaq7yT89gKXiKnkRw== X-Received: by 2002:a17:906:a988:: with SMTP id jr8mr3530343ejb.508.1602079933411; Wed, 07 Oct 2020 07:12:13 -0700 (PDT) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com. [209.85.128.51]) by smtp.gmail.com with ESMTPSA id 59sm1584703ede.73.2020.10.07.07.12.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Oct 2020 07:12:13 -0700 (PDT) Received: by mail-wm1-f51.google.com with SMTP id d81so2491196wmc.1 for ; Wed, 07 Oct 2020 07:12:12 -0700 (PDT) X-Received: by 2002:a1c:8057:: with SMTP id b84mr3494264wmd.116.1602079932144; Wed, 07 Oct 2020 07:12:12 -0700 (PDT) MIME-Version: 1.0 References: <20201002233118.GM9916@ziepe.ca> <725819e9-4f07-3f04-08f8-b6180406b339@samsung.com> <20201007124409.GN5177@ziepe.ca> <20201007130610.GP5177@ziepe.ca> In-Reply-To: From: Tomasz Figa Date: Wed, 7 Oct 2020 16:11:59 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM To: Daniel Vetter Cc: Jason Gunthorpe , Marek Szyprowski , DRI Development , LKML , Daniel Vetter , Andrew Morton , John Hubbard , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jan Kara , Dan Williams , Linux MM , Linux ARM , Pawel Osciak , Kyungmin Park , Inki Dae , Joonyoung Shim , Seung-Woo Kim , linux-samsung-soc , "open list:DMA BUFFER SHARING FRAMEWORK" , Oded Gabbay Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 7, 2020 at 4:09 PM Daniel Vetter wrote: > > On Wed, Oct 7, 2020 at 3:34 PM Tomasz Figa wrote: > > > > On Wed, Oct 7, 2020 at 3:06 PM Jason Gunthorpe wrote: > > > > > > On Wed, Oct 07, 2020 at 02:58:33PM +0200, Daniel Vetter wrote: > > > > On Wed, Oct 7, 2020 at 2:48 PM Tomasz Figa wrote: > > > > > > > > > > On Wed, Oct 7, 2020 at 2:44 PM Jason Gunthorpe wrote: > > > > > > > > > > > > On Wed, Oct 07, 2020 at 02:33:56PM +0200, Marek Szyprowski wrote: > > > > > > > Well, it was in vb2_get_vma() function, but now I see that it has been > > > > > > > lost in fb639eb39154 and 6690c8c78c74 some time ago... > > > > > > > > > > > > There is no guarentee that holding a get on the file says anthing > > > > > > about the VMA. This needed to check that the file was some special > > > > > > kind of file that promised the VMA layout and file lifetime are > > > > > > connected. > > > > > > > > > > > > Also, cloning a VMA outside the mm world is just really bad. That > > > > > > would screw up many assumptions the drivers make. > > > > > > > > > > > > If it is all obsolete I say we hide it behind a default n config > > > > > > symbol and taint the kernel if anything uses it. > > > > > > > > > > > > Add a big comment above the follow_pfn to warn others away from this > > > > > > code. > > > > > > > > > > Sadly it's just verbally declared as deprecated and not formally noted > > > > > anyway. There are a lot of userspace applications relying on user > > > > > pointer support. > > > > > > > > userptr can stay, it's the userptr abuse for zerocpy buffer sharing > > > > which doesn't work anymore. At least without major surgery (you'd need > > > > an mmu notifier to zap mappings and recreate them, and that pretty > > > > much breaks the v4l model of preallocating all buffers to make sure we > > > > never underflow the buffer queue). And static mappings are not coming > > > > back I think, we'll go ever more into the direction of dynamic > > > > mappings and moving stuff around as needed. > > > > > > Right, and to be clear, the last time I saw a security flaw of this > > > magnitude from a subsystem badly mis-designing itself, Linus's > > > knee-jerk reaction was to propose to remove the whole subsystem. > > > > > > Please don't take status-quo as acceptable, V4L community has to work > > > to resolve this, uABI breakage or not. The follow_pfn related code > > > must be compiled out of normal distro kernel builds. > > > > I think the userptr zero-copy hack should be able to go away indeed, > > given that we now have CMA that allows having carveouts backed by > > struct pages and having the memory represented as DMA-buf normally. > > Not sure whether there's a confusion here: dma-buf supports memory not > backed by struct page. > That's new to me. The whole API relies on sg_tables a lot, which in turn rely on struct page pointers to describe the physical memory. > > How about the regular userptr use case, though? > > > > The existing code resolves the user pointer into pages by following > > the get_vaddr_frames() -> frame_vector_to_pages() -> > > sg_alloc_table_from_pages() / vm_map_ram() approach. > > get_vaddr_frames() seems to use pin_user_pages() behind the scenes if > > the vma is not an IO or a PFNMAP, falling back to follow_pfn() > > otherwise. > > Yeah pin_user_pages is fine, it's just the VM_IO | VM_PFNMAP vma that > don't work. Ack. > > > > Is your intention to drop get_vaddr_frames() or we could still keep > > using it and if vec->is_pfns is true: > > a) if CONFIG_VIDEO_LEGACY_PFN_USERPTR is set, taint the kernel > > b) otherwise just undo and fail? > > I'm typing that patch series (plus a pile more) right now. Cool, thanks! We also need to bring back the vma_open() that somehow disappeared around 4.2, as Marek found. Best regards, Tomasz