From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 716F8C47095 for ; Fri, 2 Oct 2020 18:23:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 022D920758 for ; Fri, 2 Oct 2020 18:23:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="BoHELb4S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 022D920758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 46EE96B005C; Fri, 2 Oct 2020 14:23:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F8356B005D; Fri, 2 Oct 2020 14:23:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BF606B0062; Fri, 2 Oct 2020 14:23:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id EB3F16B005C for ; Fri, 2 Oct 2020 14:23:10 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 750D63634 for ; Fri, 2 Oct 2020 18:23:10 +0000 (UTC) X-FDA: 77327807340.03.pain26_480b0c1271a6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 4D68A28A4E8 for ; Fri, 2 Oct 2020 18:23:10 +0000 (UTC) X-HE-Tag: pain26_480b0c1271a6 X-Filterd-Recvd-Size: 7410 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Fri, 2 Oct 2020 18:23:09 +0000 (UTC) Received: by mail-ej1-f66.google.com with SMTP id qp15so3247620ejb.3 for ; Fri, 02 Oct 2020 11:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4bzPIab4VFKjJVRS8nUYS5ckBsBdN2UEpwZV//i/pfs=; b=BoHELb4SMe2EXLTnmM7crMW7z4e5rCSlUGYMOrIAdjXmRa3XEtuHqpDmH9BXvnlB4K FYNksaqBSlgCn4zswwkJWAcIh4aB3l6sw6PQ7aZlBMWf+vEZvvhTe1LzhF2w+hgsLdUs 9CCEQOqi7ooFv0hOakm61xTH7y/mUb3L2/qlk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4bzPIab4VFKjJVRS8nUYS5ckBsBdN2UEpwZV//i/pfs=; b=My37iWVmHlH5ZdeLb4ysn+W98W2vTKdd3Zya1DCjtJcuExbLF/EC1+zNsTP/+QSJ7y DDCcm9LUkRIk7leKRlPcWqizfYrVJ7m8mLBxoEiIkq9HH0+ht0IXHDgBIN0d8CaiVgfX +9ACxVDUWGel46RH5iCKNMVkzYZ8ZLhDICbPwuwla9f6gR6PSS/nc8JWVXaHUspPiNPu W/QW4vnyyk4u2YmhryPkNr2w7eQ2atddTDVCOJUk3m2299d+QNj5LIm5Hn7rzIUyTIp9 VJ+2UelYSFxNQuzDpaHFEq+nxqsWDW61r7BQSar6vjbn3Y9ZIPqkUGFEtffaJeKxMyb8 BKzg== X-Gm-Message-State: AOAM530ztTEn4VgtE6CG7loayI8UGLIDtZZ836zmOMbTxQQXDKpsDDDi kmcutJ2TfRzyxCtV4RhOtUk9YQpMwfEEyg== X-Google-Smtp-Source: ABdhPJyY+MiPKYSnybuGfbCjV4jEoPXGv+huLg6RUaDJMGp/yCv2JGzggMZmFXYKp+cxY6ZfQp7VTA== X-Received: by 2002:a17:906:2a50:: with SMTP id k16mr3469618eje.191.1601662988333; Fri, 02 Oct 2020 11:23:08 -0700 (PDT) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com. [209.85.128.41]) by smtp.gmail.com with ESMTPSA id k23sm1609406ejs.100.2020.10.02.11.23.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Oct 2020 11:23:07 -0700 (PDT) Received: by mail-wm1-f41.google.com with SMTP id y15so2693336wmi.0 for ; Fri, 02 Oct 2020 11:23:06 -0700 (PDT) X-Received: by 2002:a1c:a5c8:: with SMTP id o191mr4341034wme.127.1601662986038; Fri, 02 Oct 2020 11:23:06 -0700 (PDT) MIME-Version: 1.0 References: <20201002175303.390363-1-daniel.vetter@ffwll.ch> In-Reply-To: <20201002175303.390363-1-daniel.vetter@ffwll.ch> From: Tomasz Figa Date: Fri, 2 Oct 2020 20:22:49 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] mm/frame-vec: Drop gup_flags from get_vaddr_frames() To: Daniel Vetter Cc: DRI Development , LKML , Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Pawel Osciak , Marek Szyprowski , Andrew Morton , Oded Gabbay , Omer Shpigelman , Tomer Tayar , Greg Kroah-Hartman , Pawel Piskorski , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , linux-samsung-soc , Linux Media Mailing List , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 2, 2020 at 7:53 PM Daniel Vetter wrote: > > FOLL_WRITE | FOLL_FORCE is really the only reasonable thing to do for > simple dma device that can't guarantee write protection. Which is also > what all the callers are using. > > So just simplify this. > > Signed-off-by: Daniel Vetter > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Pawel Osciak > Cc: Marek Szyprowski > Cc: Tomasz Figa > Cc: Andrew Morton > Cc: Oded Gabbay > Cc: Omer Shpigelman > Cc: Tomer Tayar > Cc: Greg Kroah-Hartman > Cc: Pawel Piskorski > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-media@vger.kernel.org > Cc: linux-mm@kvack.org > --- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 +-- > drivers/media/common/videobuf2/videobuf2-memops.c | 3 +-- > drivers/misc/habanalabs/common/memory.c | 3 +-- > include/linux/mm.h | 2 +- > mm/frame_vector.c | 4 ++-- > 5 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > index 967a5cdc120e..ac452842bab3 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > @@ -480,8 +480,7 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struct g2d_data *g2d, > goto err_free; > } > > - ret = get_vaddr_frames(start, npages, FOLL_FORCE | FOLL_WRITE, > - g2d_userptr->vec); > + ret = get_vaddr_frames(start, npages, g2d_userptr->vec); > if (ret != npages) { > DRM_DEV_ERROR(g2d->dev, > "failed to get user pages from userptr.\n"); > diff --git a/drivers/media/common/videobuf2/videobuf2-memops.c b/drivers/media/common/videobuf2/videobuf2-memops.c > index 6e9e05153f4e..9dd6c27162f4 100644 > --- a/drivers/media/common/videobuf2/videobuf2-memops.c > +++ b/drivers/media/common/videobuf2/videobuf2-memops.c > @@ -40,7 +40,6 @@ struct frame_vector *vb2_create_framevec(unsigned long start, > unsigned long first, last; > unsigned long nr; > struct frame_vector *vec; > - unsigned int flags = FOLL_FORCE | FOLL_WRITE; > > first = start >> PAGE_SHIFT; > last = (start + length - 1) >> PAGE_SHIFT; > @@ -48,7 +47,7 @@ struct frame_vector *vb2_create_framevec(unsigned long start, > vec = frame_vector_create(nr); > if (!vec) > return ERR_PTR(-ENOMEM); > - ret = get_vaddr_frames(start & PAGE_MASK, nr, flags, vec); > + ret = get_vaddr_frames(start & PAGE_MASK, nr, vec); > if (ret < 0) > goto out_destroy; > /* We accept only complete set of PFNs */ For drivers/media/common/videobuf2/: Acked-by: Tomasz Figa Best regards, Tomasz