From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7C65C678D4 for ; Thu, 2 Mar 2023 01:41:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2E836B0071; Wed, 1 Mar 2023 20:41:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EDEAB6B0073; Wed, 1 Mar 2023 20:41:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCD856B0074; Wed, 1 Mar 2023 20:41:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C9B936B0071 for ; Wed, 1 Mar 2023 20:41:25 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9DE2D80EEC for ; Thu, 2 Mar 2023 01:41:25 +0000 (UTC) X-FDA: 80522255730.04.56C1029 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf06.hostedemail.com (Postfix) with ESMTP id E459C180015 for ; Thu, 2 Mar 2023 01:41:23 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=M1faUwzF; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of dionnaglaze@google.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=dionnaglaze@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677721284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nQ/k+I6vg3DIpuQkWsbGXKaDuFnWAPV+R/MRhIWgerE=; b=5RXoELx8HKY2DhMRFPqflqeK9R17bikxB17gXTMSVoan4TE+cHhx/UM9ViwNZS08Bs8hGA v+zwGrYZpNBd3/VN4vsg48nsI6TxYTXhFmSDY7wuy8/sW9NwQVfp9PbEoc9Chsw5U/8i3u M2Fye7zqVUy62USYv0ZnAzq/KWBNhBc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=M1faUwzF; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of dionnaglaze@google.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=dionnaglaze@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677721284; a=rsa-sha256; cv=none; b=1b7E4bp3NjjCSmb0Xz1rbUa8fiKkk6WPvuHUcSSAVXFzxiTB9GsxrLbikCD/nha9Ze2hDu EEPniHd1QKmEUlIq3TrTYAseQp80HHJvo/BWcT1Uf+Hd9Est4gXF7om57438kaIFwmFKhh E/hlTL9s9gnbl+7r45Xh5AGKohXle7I= Received: by mail-pj1-f50.google.com with SMTP id q31-20020a17090a17a200b0023750b69614so1177989pja.5 for ; Wed, 01 Mar 2023 17:41:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nQ/k+I6vg3DIpuQkWsbGXKaDuFnWAPV+R/MRhIWgerE=; b=M1faUwzF8K9LVMgFawTxpJg0odDzVyBttN0AF69uG9guWjiSvbhav1cNgD35gDMKu0 j1niW9n0QqE3EKJ1dLgwNzvMTsr/XSuX4cXlnqhLDSoEXOlwHLpg/HIGgMwqwQFoKLTY /3p1wvO6ecQ1YgClypzXuo5Z+9McY/e//LJVhv3UX6Kpq0CIXJKrgmeQRoYvzMI1gJrs GhDh8QtNI7ubX9ks3+BO7j6DV36t9q0rMBQcG43GtBzfzhnaGmfxqQjy6q1mxlVc/mvD dmoYB0/AEPJc7ihdJU3WdhAsnYUJK781v7iYPrrNrt88tgTT5g7Myt5GjBx8YtQisLfu 4ZrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nQ/k+I6vg3DIpuQkWsbGXKaDuFnWAPV+R/MRhIWgerE=; b=cDH3Jyc9ir3Tca6P7AzaL+A53gTpKY6/e0LvtxVeMc+HQLbJ9wtbo5W75SOe79FZBk qp21srsi5Puy4BU1Xk1KGu5insLspBZQgS/itnpd17J/8ABKk01Dum9suKrkt+NAqa+3 BG9VuLcbcxdc6YX/HMKQxkQwQ+9oIJ5ucuOhfJxTOGKVsGpKdQsYsdQmktyS8yijWYkA coyvFlGFwS0Cj8u3fsI/VbpiSZ5mrZ9xCTCdZeMn+sdDd9KaxEZWA1CyyNUU+ULHVZi8 r5QZczy2O5PKzt+yBh5THStwpHkHj5pEnwrpBG0puB+KtVkuiZfSKdNDhNvbilmfjqdM Wgbg== X-Gm-Message-State: AO0yUKW3iWh11egPoD/+lFxbCEzqUnUjTpRSersAP2/bzzLonwr5ttvJ 9W3mwVU//uSIh8fNYmVRNAOrCDDiIVXG7Z58FNYV+g== X-Google-Smtp-Source: AK7set96nV5WxVAFJCuff1YfyXG1LVejzmkonDIYcfNUk89kau/aG+VyPFxYaHWrc+2i5u58w4j88wEOxo3FDLY30SQ= X-Received: by 2002:a17:902:7841:b0:19d:1dfe:eac6 with SMTP id e1-20020a170902784100b0019d1dfeeac6mr3274257pln.1.1677721282551; Wed, 01 Mar 2023 17:41:22 -0800 (PST) MIME-Version: 1.0 References: <20230220183847.59159-1-michael.roth@amd.com> <20230220183847.59159-55-michael.roth@amd.com> <20230302020245.00006f57@gmail.com> In-Reply-To: <20230302020245.00006f57@gmail.com> From: Dionna Amalie Glaze Date: Wed, 1 Mar 2023 17:41:11 -0800 Message-ID: Subject: Re: [PATCH RFC v8 54/56] x86/sev: Add KVM commands for instance certs To: Zhi Wang Cc: Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E459C180015 X-Stat-Signature: dk87ba1f8my4tpaeh1rscfkjis6toio5 X-HE-Tag: 1677721283-586211 X-HE-Meta: U2FsdGVkX1/nrUxHXV+Foh9ziP5kGSDNTHnEeBnPcI/Fmhstfq2oV0NpksV8hDOvzw8GtUWIUp2+wDb3Vcp3lXHXxWexQhKbwPcSpm9bbZFQGaAYn7iodYlaL+Neq5Y2EYlEGcHMYFJ1OUUK6Q1QL7WY+ZI3Iqb/T6uUKkZYRjaZ6RnddhfNuefH/e9lq/lvcrDHKOCb7gsAFTTt7ELSvhXNpDouH+TX3HD4v1NciCnkuGh721REoaSxl5jiSKTN2GIbBjaHXCNF+mZ1rXgcpgzsnp2ygy6LixFXagsOq8GsONlIlPemdEWtjondY059rXW440I57nE6Io1CN9wuRynij0eDKOZW1ImqdmmzfFSMONyOh9PM8DYthBczbdyidSVDPwp2Eu34MZvlv1rk7bq2UO11J3SY24JqqpqJVfHC0IC0uUIHU9mrotfYe5Idtk+X/Q13t8G6dO1SApxIVNPRVwyvVAjkbxazwhmGzYHG90+eQLnHiqFb0PUCbd9PAu+QeEiH3rjHVvvKw/aP/rYDXmFVNEQKwuDyf38Ce2Lc5bBA9lVoJYQSEnnJyKJ8NbFYfLADFzCnQ18ui4GDG1eQqCmQO9idWxyOlZZNlBL3OyxSlnaYO0zhkHgI5l3SxTUU9V5VMNS1dprFYvBfo48z/OjDB/6jSvj39NCAJo/ZjMIqGdUyl6KXwoFwkoz5AVfExzIIxiRogc4X1suSeqv9uP8c9IiC5PEgPwSZ961HsP8slR2nTw9h+H4vgoBVB9chEAWgfFBvuU71QMyiX9WCTIIlSu3XjxlaWt1ULU19l35Aga2Z+MdxjFMo+FWYjFRLhBsERH085YxwiVbiMnjDUNHkbhoxC4DRK8sI7PFX9nh1kcfj1zs3Hc7eGCSRhijxPPCbIGlXJl/TLqTHoUduue5rQvnFPx6Rqq1QRbMxwPuLbmsnvuSxC8qYC2qTzaV5Dt4VeXsOBvVZTKX kYLeWOom 6ak2eEjrzhs/G0SSueoa8QuPbwpUOxvPCSsoDNEDUy3v3YMol84mANb7EZScs6riMj8ew2carBpDI/7cbmGauJOqilrThRxr3VmcPr8QaTB78CJXNcSAKNqYAtckdAzkKqRT8mwq7zKz1DAQtxPF1zj2tQwsVDWn6kvopiPnA7itpJJesjA6MGd8hdAeTF+V9PoZdyemD7GO716fFVNxKAruKimHWTUKvrWotnt7AJAOxolrfb3OMuywhe3DVYmOikvMZejgFHBNikAsedLBIXwBUUx2NYM9a6VSjpAPWGGGxc6cEdm0SiRqp/37lPf3S0aoU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > @@ -2089,6 +2089,7 @@ static void *snp_context_create(struct kvm *kvm, struct kvm_sev_cmd *argp) > > goto e_free; > > > > sev->snp_certs_data = certs_data; > > + sev->snp_certs_len = 0; > > > > return context; > > > > Better to move the fix to PATCH 45. > This part isn't a fix, but part of the implementation since snp_certs_len is added in this patch here > > diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h > > index 221b38d3c845..dced46559508 100644 > > --- a/arch/x86/kvm/svm/svm.h > > +++ b/arch/x86/kvm/svm/svm.h > > @@ -94,6 +94,7 @@ struct kvm_sev_info { > > u64 snp_init_flags; > > void *snp_context; /* SNP guest context page */ > > void *snp_certs_data; > > + unsigned int snp_certs_len; /* Size of instance override for certs */ > > struct mutex guest_req_lock; /* Lock for guest request handling */ > > > > u64 sev_features; /* Features set at VMSA creation */ -- -Dionna Glaze, PhD (she/her)