From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37570C433ED for ; Fri, 9 Apr 2021 18:47:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A365A61056 for ; Fri, 9 Apr 2021 18:47:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A365A61056 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0D46E6B006C; Fri, 9 Apr 2021 14:47:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 071946B006E; Fri, 9 Apr 2021 14:47:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2CE76B0070; Fri, 9 Apr 2021 14:47:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id C6F096B006C for ; Fri, 9 Apr 2021 14:47:44 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 74B63184B4333 for ; Fri, 9 Apr 2021 18:47:44 +0000 (UTC) X-FDA: 78013712448.25.DF98277 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by imf22.hostedemail.com (Postfix) with ESMTP id 879B5C0007CA for ; Fri, 9 Apr 2021 18:47:41 +0000 (UTC) Received: by mail-il1-f181.google.com with SMTP id c15so5556783ilj.1 for ; Fri, 09 Apr 2021 11:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QCxgqS+GIdc01GAi2BBY4vi+QbypofN8DAcQ//bJP/A=; b=eOj02iuOehaMaoynUqQfooPaxBNWHAp8bTG5A5IkhvUsfdX+T9CPj4hjEqgDJ7+WMG ZWsSHEo0iBr4B+wXExLqUV+UA2y/QJlBU3JXdMEWkORJYpzQa0DRh3L9LuuGRRduwrV/ fu0AhAbfhSLTNybayB+jVi0xaS4FR3kgy967zTXD2G52cv1GeJvOSmy+XsVzZFqoavmw KETq52CpzMokakz0kLs2S+BcpxqQmHETgOwsoIG6qknhQ8/9BZEXeq69ZYlWP6yZf/m6 DIksoQG14xqmX0uDRdhDpR8Uz2xKPrY6BI9P3dWwDiLsiDmz9UtQH/4PNGbLTTU1K9Mg V7ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QCxgqS+GIdc01GAi2BBY4vi+QbypofN8DAcQ//bJP/A=; b=qYTnyZj+z+DOS0cFgCNqhVYnV9xxqO76OYcMVOkUjJJrCZxckFHxmanRUZgZcn6ElB 1BNF7SLUExcxsdGYSNrKFiBNe20jnIt+JDPCrfaV6TGbTNQ+DlBfIbRQn9UPYO7+lkNy RpRuNlu5Nbpdr26zfyU0CX7KRmW6/fS4Q4F/WrJ7vpdFNSyItcds2Hwz2xd5KQsF3NZO Oc1PM1S4vMvRlDo1cFONj2zfE2JY/V4uLN8i87E1V9R+w92kw/kAZo8PaxuvmO2cle4T sT9otVRzajepzNR0JASlryDl9wIOFoLQpi2+lVh6wVW+mLr7tk0st4mx8v8FIFvdni2E yiQA== X-Gm-Message-State: AOAM530EJrkKqNmWZafULaF18kjpWB7SRoVNmmkZdHDbR3ElE5oHl5SN 2yGxrmogqpAER0fpEZ2sh5VheKylkgiukmWNX04Izg== X-Google-Smtp-Source: ABdhPJx072OlknUi2iEvkfpvMZPY78ass5Uo72enMkSesF5KKnbz78Uq6W6xvDu5uUt3uhGOseOKXC1h4RHlLASi8Xg= X-Received: by 2002:a05:6e02:11a9:: with SMTP id 9mr2322814ilj.288.1617994063197; Fri, 09 Apr 2021 11:47:43 -0700 (PDT) MIME-Version: 1.0 References: <20210401183216.443C4443@viggo.jf.intel.com> <20210401183223.80F1E291@viggo.jf.intel.com> In-Reply-To: From: Wei Xu Date: Fri, 9 Apr 2021 11:47:31 -0700 Message-ID: Subject: Re: [PATCH 04/10] mm/migrate: make migrate_pages() return nr_succeeded To: Dave Hansen Cc: Oscar Salvador , Yang Shi , Dave Hansen , Linux MM , Linux Kernel Mailing List , Yang Shi , Huang Ying , Dan Williams , David Hildenbrand Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 879B5C0007CA X-Stat-Signature: tbm9wehn6zfckodhz814emdfpx5zs55e Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=mail-il1-f181.google.com; client-ip=209.85.166.181 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617994061-450407 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 9, 2021 at 8:50 AM Dave Hansen wrote: > I also considered passing NULL to mean "I don't care about > nr_succeeded". I mostly avoided it to reduce churn. But, looking at it > here, it does seem cleaner. > > Any objections to moving over to Oscar's suggestion? I like this approach (making *nr_succeeded an optional argument). No objection here.