From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6797EC433F5 for ; Fri, 29 Apr 2022 14:27:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCDB46B0072; Fri, 29 Apr 2022 10:27:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C57866B0073; Fri, 29 Apr 2022 10:27:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD1A36B0074; Fri, 29 Apr 2022 10:27:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 9AE306B0072 for ; Fri, 29 Apr 2022 10:27:14 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6BA4B274E9 for ; Fri, 29 Apr 2022 14:27:14 +0000 (UTC) X-FDA: 79410143988.01.C3C3B89 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf04.hostedemail.com (Postfix) with ESMTP id A7F5840073 for ; Fri, 29 Apr 2022 14:27:08 +0000 (UTC) Received: by mail-lj1-f175.google.com with SMTP id q14so10696990ljc.12 for ; Fri, 29 Apr 2022 07:27:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gbv+Cs2qOEmiq4UU4y37miIXWOPfSaXc6sqWaYG9PdY=; b=iDwrRh0AaJ9OCu1nZH8mgbVC2yxPGEpfFFkk0KCyLC44TPCnlACEZtvHiOWXy9xvAf L51e2CkjcPV7Jwr0ZVRlUAcr4nBIneyQy8nFfYWL4fjGU2Cn4MKqKmzwQZhLIVKvbSRy A9XVAyarXMMYxWDplPDOemQakv883VvfGyvehiCBwfuOEib6qVh/wbUrN7T3PxLwPHbn 6g5tfeyDhSYkq6fWA9eSg7bbdZU3ttYfr0mi42HSVX5tTnFcs2aRnCZPeKGaVqcjUfwK WRILvwXcvd5BVeKYuy7NUfOPX7tP/+rCnBDnlALTkGNTkeJQ4V3mYlqef96wiE6O8rRO N+eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gbv+Cs2qOEmiq4UU4y37miIXWOPfSaXc6sqWaYG9PdY=; b=467tIZtasuqIAtDYm2Sj54RRtB9+PxHvT6jz+ATTleiBw59ZCoo8m/KkdvzuaS0wFi SSmR9sq4SC9GeOaYNHv5etL6djKmsw+Djm3yahXJLYWQNDoPyNAkOhGVnNOFav9m8MX5 eZML27jlYU9DSZARdbvaIh0u4bd3shEFKdXFaHt3qUP4A4JO97wluhYz9wivRPU0wLYQ /8Qoy5b7yVArIo2S7BJsQ3OeDS+BclCeV0ZeGvwCk6pWmoAQeBaOMJwY+8rFgfVAZmqY RvEz+09aCPNqFomCCwMRpx2ytbAh7nqc8xP72HPAXX4FSkkmCJHF4ZAe/yopF5b9b4VH 2NQw== X-Gm-Message-State: AOAM533yInwGd65Bope8+hv1VeFKjsO/g7CoHtk7XNgCSb+xQoYrrmA6 SeRdNm/9S14XKV4ZJMOflZn6Me4s5t5ZL2wZiHbTjA== X-Google-Smtp-Source: ABdhPJzCF0Sk0XtWGx7bqihS6a5N7sLp0q79+AGEeZ5dtLXkEUWWfnjrTwBFzyBymhLMTxAPlK5g1hjteBRjtGW1Pxc= X-Received: by 2002:a05:651c:154b:b0:24f:4217:ca8d with SMTP id y11-20020a05651c154b00b0024f4217ca8dmr1258528ljp.278.1651242432030; Fri, 29 Apr 2022 07:27:12 -0700 (PDT) MIME-Version: 1.0 References: <20220426144412.742113-1-zokeefe@google.com> <20220426144412.742113-8-zokeefe@google.com> In-Reply-To: From: "Zach O'Keefe" Date: Fri, 29 Apr 2022 07:26:35 -0700 Message-ID: Subject: Re: [PATCH v3 07/12] mm/khugepaged: add flag to ignore khugepaged_max_ptes_* To: Peter Xu Cc: Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org, Andrea Arcangeli , Andrew Morton , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia , Pavel Begunkov , Thomas Bogendoerfer Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A7F5840073 X-Stat-Signature: ck7izb7ipu1tbspfabzorudrdr7ckc37 X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=iDwrRh0A; spf=pass (imf04.hostedemail.com: domain of zokeefe@google.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1651242428-168108 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 27, 2022 at 2:13 PM Peter Xu wrote: > > On Tue, Apr 26, 2022 at 07:44:07AM -0700, Zach O'Keefe wrote: > > @@ -2365,6 +2375,7 @@ static int khugepaged(void *none) > > { > > struct mm_slot *mm_slot; > > struct collapse_control cc = { > > + .enforce_pte_scan_limits = true, > > .last_target_node = NUMA_NO_NODE, > > .gfp = &alloc_hugepage_khugepaged_gfpmask, > > .alloc_hpage = &khugepaged_alloc_page, > > @@ -2512,6 +2523,7 @@ int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev, > > unsigned long start, unsigned long end) > > { > > struct collapse_control cc = { > > + .enforce_pte_scan_limits = false, > > .last_target_node = NUMA_NO_NODE, > > .hpage = NULL, > > .gfp = &alloc_hugepage_madvise_gfpmask, > > This changes the semantics of the new madvise(). IMHO it'll be ideal if > this patch is moved before the introduction of MADV_COLLAPSE, so the new > madvise() will have a consistent behavior. > That makes sense to me, as this was how it was done in the RFC. I'll assume this applies equally well to "mm/khugepaged: add flag to ignore page young/referenced requirement" and move both before introducing the new madvise(2) mode. Thanks again Peter, Zach > -- > Peter Xu >