From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C95D8C433EF for ; Thu, 28 Apr 2022 22:51:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 218CC6B0071; Thu, 28 Apr 2022 18:51:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17B396B0072; Thu, 28 Apr 2022 18:51:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0EDC6B0073; Thu, 28 Apr 2022 18:51:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id DDFB26B0071 for ; Thu, 28 Apr 2022 18:51:41 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BB0AB22462 for ; Thu, 28 Apr 2022 22:51:41 +0000 (UTC) X-FDA: 79407786402.02.1C0A0FD Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf05.hostedemail.com (Postfix) with ESMTP id 034F6100061 for ; Thu, 28 Apr 2022 22:51:32 +0000 (UTC) Received: by mail-lf1-f45.google.com with SMTP id t25so11121005lfg.7 for ; Thu, 28 Apr 2022 15:51:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2w0IBVrZLTIty+DvuSx6BwtTvVfxT4CS/rmi1euFWrk=; b=E23Yz6CEeZRvFjEDrs7adKvlPQ2XkxU6wYu0xvr2+HQFXzmyvD8LROBp00RHFUA16F bqFRFS1Dwx60Aomi65CKuKoSX0vXX0M8XaAN/iB5qAP/i1owTWNbnpjWv9QZeb5V2UVi 9PU8qrOduuZXoS/SGA/BWLWiesJ1S66RhbY/osQEitQnoKCejeCmmRDzSi3tJwKArmCX w+0ES+l+00lgoZQpPtz/VxjyooBJ2UWu9pOPUZFIMRdnqNo3MInIKSIdfffBHMl2TOrT 7kGSNuIy94PnUSInqiRsYQC4pVXte5+uqvD5aLo6kVD1EAQAPs7M/+sDC81MxGrYRf/P AFfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2w0IBVrZLTIty+DvuSx6BwtTvVfxT4CS/rmi1euFWrk=; b=ZCZiixVaVG0byHf27lklBpM6Y5ECSbHeWtJV0KTwv4NrYMoAlIXtBSYmUc6Dod0oeT zW/A057SvPY4n+YI/JyqKiDHNqBFnrS7qYa4/PFpDTKkptyRWLEF6bHPJ95KbhOVTJNG Q+thxwLtOTvod5bfNlxPfDppuYZ7I9uUfAf+QX5jnSpcFEJ9AhigGVEuQ2nwF6kbLsxA 3KV6MwlNWOpqjbd7pA+2OZ8LhGiyOx9TmC/WjyXo9hSGWaBYAJMJ29afGkM4CfaHNZO3 8CPAVqkZK+or5r8l0F2PUIauZHOl7P7LeG4xRliD7rXYuwwA5zaQP6CQ20I3vl071Gdv Vb+w== X-Gm-Message-State: AOAM530VPVI9qKk0zrMq8VI4s8QRr3B+NWnSlUl2rldvDZoYk2UONB8e Cj5e/+l2uAGP2mMwEoSWR2oWaLIROe0yhABrvrw7Dw== X-Google-Smtp-Source: ABdhPJxkwI9tPWma2G9wEJAEwBu4kMSxyH4qDAkGuSoyyN8kqMP9VUAKPhscsVFFJh76wgIGATdk+4ZLrPwItokAYf4= X-Received: by 2002:a05:6512:1109:b0:472:25d9:d262 with SMTP id l9-20020a056512110900b0047225d9d262mr8619868lfg.128.1651186299310; Thu, 28 Apr 2022 15:51:39 -0700 (PDT) MIME-Version: 1.0 References: <20220426144412.742113-1-zokeefe@google.com> <20220426144412.742113-7-zokeefe@google.com> In-Reply-To: From: "Zach O'Keefe" Date: Thu, 28 Apr 2022 15:51:02 -0700 Message-ID: Subject: Re: [PATCH v3 06/12] mm/khugepaged: remove khugepaged prefix from shared collapse functions To: Peter Xu Cc: Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org, Andrea Arcangeli , Andrew Morton , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia , Pavel Begunkov , Thomas Bogendoerfer , kernel test robot Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 034F6100061 X-Stat-Signature: xgidth7r46bhgp83as6r9xgji8dezrdj X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=E23Yz6CE; spf=pass (imf05.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam09 X-HE-Tag: 1651186292-683512 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 27, 2022 at 2:10 PM Peter Xu wrote: > > On Tue, Apr 26, 2022 at 07:44:06AM -0700, Zach O'Keefe wrote: > > The following functions/tracepoints are shared between khugepaged and > > madvise collapse contexts. Remove the khugepaged prefixes. > > > > tracepoint:mm_khugepaged_scan_pmd -> tracepoint:mm_scan_pmd > > khugepaged_test_exit() -> test_exit() > > khugepaged_scan_abort() -> scan_abort() > > khugepaged_scan_pmd() -> scan_pmd() > > khugepaged_find_target_node() -> find_target_node() > > The khugepaged prefix can indeed be confusing, but are the new names just > too short? IMHO it'll be nice to still have some generic prefix. > > Perhaps something like "hpage_collapse_"/"hpage_"/"hpc_"/..? > If we want to keep a prefix, I'd throw my hat in with "hpage_collapse_". I feel like "collapse" should be in there, and "collapse_" on its own seems odd to me. Updated. Thanks Peter. > -- > Peter Xu >