From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8126DC54FCB for ; Thu, 23 Apr 2020 18:50:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 29AC920704 for ; Thu, 23 Apr 2020 18:50:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="b0Bvtag5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29AC920704 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B07038E0005; Thu, 23 Apr 2020 14:50:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB7598E0003; Thu, 23 Apr 2020 14:50:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97F478E0005; Thu, 23 Apr 2020 14:50:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 803E38E0003 for ; Thu, 23 Apr 2020 14:50:36 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 29E6281D6 for ; Thu, 23 Apr 2020 18:50:36 +0000 (UTC) X-FDA: 76740010872.18.cup35_79980a5f6c020 X-HE-Tag: cup35_79980a5f6c020 X-Filterd-Recvd-Size: 16229 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Thu, 23 Apr 2020 18:50:35 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id s18so656272pgl.12 for ; Thu, 23 Apr 2020 11:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lbDX1NdIBr13DPMhY5MyxWO5eK+IFdipG/Sg+K38HgM=; b=b0Bvtag5c2+MHIEvUM7RS//TdCKDWCklVH6dWJqNkMzjwOysWc3txSI7A4/CE8jrtx 3Z0hBSb2TNp+Ar/667lhVycHNUvEFJ3s8sH/Zt2De872Ka3Vq4ozzDyQRF3SKC/nL4MT afwzWQmxfVzHXr0ivKCDsFypTWxEsNSMNC+J9OIAo5iAh2Np+n1Zm9W9cbRy5Lhz6KLA doNUE7tOfEWlroYGP03di+8aWMdJ/34dpASqmyCxrz4YnQ1dJmNOfFgV57fKrubcQoz7 xNTl0S5+33P3FpkBKiaMoGZNb1YYiNbM/TAbO0jjYA6LE55NDiimL+vWLTnNUpNkclsX V5Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lbDX1NdIBr13DPMhY5MyxWO5eK+IFdipG/Sg+K38HgM=; b=O72sN2T4NvRlrTiUKZdeMSDIv9BPZ7I8szR/LcZ21bIS6omDds5jDKaprMu/TpSkv9 BhjHBuT5Dl+/Oj186upXbyEJUb5qzhMAUFbJvIkboxxZw9MtFHdmIUC+/StxFbjBef9b ivKIIVKgT1fdN4WhDOYjvd6Qxj6xblMnNHgb26QD692qlmOOO85dmqRqSF+ESdXOzMwB sTvQxC+PXT0dBd7UFQfR0+GRQblxGLNBwDIfOSLq0zYHPtr0Q3/qMcMq7cn2s3x68mBk CwLlqSjN23SrVX1Xbbxi5ULVoReFqDU1L3spPM6cIT0WfsU2aMC2GJNM5UHA0ENoVFqa 7tSg== X-Gm-Message-State: AGi0PuayRmyq5OKNSav7B5xQ8i4InMaeVIVKH02KL/oSifhqSQ+0Kaz0 4opg7agF7eDh+/dJox1AMY09w94oqPwSP+8q4fyrHw== X-Google-Smtp-Source: APiQypJC3SlyxnWnkHkp9nWD8EYrVGdJILSJol+sRGo/rZ+QLIaZpiDv83EuKnOGUWpEbJ4w2QgrSpak/EVDuMNZdPg= X-Received: by 2002:a63:fc45:: with SMTP id r5mr5198278pgk.440.1587667834221; Thu, 23 Apr 2020 11:50:34 -0700 (PDT) MIME-Version: 1.0 References: <20200325161249.55095-1-glider@google.com> <20200325161249.55095-15-glider@google.com> In-Reply-To: <20200325161249.55095-15-glider@google.com> From: Andrey Konovalov Date: Thu, 23 Apr 2020 20:50:22 +0200 Message-ID: Subject: Re: [PATCH v5 14/38] crypto: kmsan: disable accelerated configs under KMSAN To: Alexander Potapenko Cc: Herbert Xu , "David S. Miller" , Eric Biggers , Vegard Nossum , Dmitry Vyukov , Marco Elver , Linux Memory Management List , Alexander Viro , Andreas Dilger , Andrew Morton , Andrey Ryabinin , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , Christoph Hellwig , "Darrick J. Wong" , Dmitry Torokhov , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Jens Axboe , Marek Szyprowski , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S . Tsirkin" , Michal Hocko , Michal Simek , Petr Mladek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 25, 2020 at 5:13 PM wrote: > > KMSAN is unable to understand when initialized values come from assembly. > Disable accelerated configs in KMSAN builds to prevent false positive > reports. > > Signed-off-by: Alexander Potapenko > To: Alexander Potapenko > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Eric Biggers > Cc: Vegard Nossum > Cc: Dmitry Vyukov > Cc: Marco Elver > Cc: Andrey Konovalov > Cc: linux-mm@kvack.org Reviewed-by: Andrey Konovalov > > --- > > v4: > - shorten comments as requested by Marco Elver > > v5: > - move the 'depends' directives together, added missing configs as > requested by Eric Biggers > > Change-Id: Iddc71a2a27360e036d719c0940ebf15553cf8de8 > --- > crypto/Kconfig | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/crypto/Kconfig b/crypto/Kconfig > index c24a47406f8f5..5035e8b2b033f 100644 > --- a/crypto/Kconfig > +++ b/crypto/Kconfig > @@ -268,6 +268,7 @@ config CRYPTO_CURVE25519 > config CRYPTO_CURVE25519_X86 > tristate "x86_64 accelerated Curve25519 scalar multiplication library" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_LIB_CURVE25519_GENERIC > select CRYPTO_ARCH_HAVE_LIB_CURVE25519 > > @@ -317,11 +318,13 @@ config CRYPTO_AEGIS128_SIMD > bool "Support SIMD acceleration for AEGIS-128" > depends on CRYPTO_AEGIS128 && ((ARM || ARM64) && KERNEL_MODE_NEON) > depends on !ARM || CC_IS_CLANG || GCC_VERSION >= 40800 > + depends on !KMSAN # avoid false positives from assembly > default y > > config CRYPTO_AEGIS128_AESNI_SSE2 > tristate "AEGIS-128 AEAD algorithm (x86_64 AESNI+SSE2 implementation)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_AEAD > select CRYPTO_SIMD > help > @@ -458,6 +461,7 @@ config CRYPTO_NHPOLY1305 > config CRYPTO_NHPOLY1305_SSE2 > tristate "NHPoly1305 hash function (x86_64 SSE2 implementation)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_NHPOLY1305 > help > SSE2 optimized implementation of the hash function used by the > @@ -466,6 +470,7 @@ config CRYPTO_NHPOLY1305_SSE2 > config CRYPTO_NHPOLY1305_AVX2 > tristate "NHPoly1305 hash function (x86_64 AVX2 implementation)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_NHPOLY1305 > help > AVX2 optimized implementation of the hash function used by the > @@ -579,6 +584,7 @@ config CRYPTO_CRC32C > config CRYPTO_CRC32C_INTEL > tristate "CRC32c INTEL hardware acceleration" > depends on X86 > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_HASH > help > In Intel processor with SSE4.2 supported, the processor will > @@ -619,6 +625,7 @@ config CRYPTO_CRC32 > config CRYPTO_CRC32_PCLMUL > tristate "CRC32 PCLMULQDQ hardware acceleration" > depends on X86 > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_HASH > select CRC32 > help > @@ -684,6 +691,7 @@ config CRYPTO_BLAKE2S > config CRYPTO_BLAKE2S_X86 > tristate "BLAKE2s digest algorithm (x86 accelerated version)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_LIB_BLAKE2S_GENERIC > select CRYPTO_ARCH_HAVE_LIB_BLAKE2S > > @@ -698,6 +706,7 @@ config CRYPTO_CRCT10DIF > config CRYPTO_CRCT10DIF_PCLMUL > tristate "CRCT10DIF PCLMULQDQ hardware acceleration" > depends on X86 && 64BIT && CRC_T10DIF > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_HASH > help > For x86_64 processors with SSE4.2 and PCLMULQDQ supported, > @@ -745,6 +754,7 @@ config CRYPTO_POLY1305 > config CRYPTO_POLY1305_X86_64 > tristate "Poly1305 authenticator algorithm (x86_64/SSE2/AVX2)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_LIB_POLY1305_GENERIC > select CRYPTO_ARCH_HAVE_LIB_POLY1305 > help > @@ -870,6 +880,7 @@ config CRYPTO_SHA1 > config CRYPTO_SHA1_SSSE3 > tristate "SHA1 digest algorithm (SSSE3/AVX/AVX2/SHA-NI)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_SHA1 > select CRYPTO_HASH > help > @@ -881,6 +892,7 @@ config CRYPTO_SHA1_SSSE3 > config CRYPTO_SHA256_SSSE3 > tristate "SHA256 digest algorithm (SSSE3/AVX/AVX2/SHA-NI)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_SHA256 > select CRYPTO_HASH > help > @@ -893,6 +905,7 @@ config CRYPTO_SHA256_SSSE3 > config CRYPTO_SHA512_SSSE3 > tristate "SHA512 digest algorithm (SSSE3/AVX/AVX2)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_SHA512 > select CRYPTO_HASH > help > @@ -1064,6 +1077,7 @@ config CRYPTO_WP512 > config CRYPTO_GHASH_CLMUL_NI_INTEL > tristate "GHASH hash function (CLMUL-NI accelerated)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_CRYPTD > help > This is the x86_64 CLMUL-NI accelerated implementation of > @@ -1114,6 +1128,7 @@ config CRYPTO_AES_TI > config CRYPTO_AES_NI_INTEL > tristate "AES cipher algorithms (AES-NI)" > depends on X86 > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_AEAD > select CRYPTO_LIB_AES > select CRYPTO_ALGAPI > @@ -1237,6 +1252,7 @@ config CRYPTO_BLOWFISH_COMMON > config CRYPTO_BLOWFISH_X86_64 > tristate "Blowfish cipher algorithm (x86_64)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_SKCIPHER > select CRYPTO_BLOWFISH_COMMON > help > @@ -1268,6 +1284,7 @@ config CRYPTO_CAMELLIA_X86_64 > tristate "Camellia cipher algorithm (x86_64)" > depends on X86 && 64BIT > depends on CRYPTO > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_SKCIPHER > select CRYPTO_GLUE_HELPER_X86 > help > @@ -1285,6 +1302,7 @@ config CRYPTO_CAMELLIA_AESNI_AVX_X86_64 > tristate "Camellia cipher algorithm (x86_64/AES-NI/AVX)" > depends on X86 && 64BIT > depends on CRYPTO > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_SKCIPHER > select CRYPTO_CAMELLIA_X86_64 > select CRYPTO_GLUE_HELPER_X86 > @@ -1305,6 +1323,7 @@ config CRYPTO_CAMELLIA_AESNI_AVX2_X86_64 > tristate "Camellia cipher algorithm (x86_64/AES-NI/AVX2)" > depends on X86 && 64BIT > depends on CRYPTO > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_CAMELLIA_AESNI_AVX_X86_64 > help > Camellia cipher algorithm module (x86_64/AES-NI/AVX2). > @@ -1351,6 +1370,7 @@ config CRYPTO_CAST5 > config CRYPTO_CAST5_AVX_X86_64 > tristate "CAST5 (CAST-128) cipher algorithm (x86_64/AVX)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_SKCIPHER > select CRYPTO_CAST5 > select CRYPTO_CAST_COMMON > @@ -1373,6 +1393,7 @@ config CRYPTO_CAST6 > config CRYPTO_CAST6_AVX_X86_64 > tristate "CAST6 (CAST-256) cipher algorithm (x86_64/AVX)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_SKCIPHER > select CRYPTO_CAST6 > select CRYPTO_CAST_COMMON > @@ -1406,6 +1427,7 @@ config CRYPTO_DES_SPARC64 > config CRYPTO_DES3_EDE_X86_64 > tristate "Triple DES EDE cipher algorithm (x86-64)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_SKCIPHER > select CRYPTO_LIB_DES > help > @@ -1473,6 +1495,7 @@ config CRYPTO_CHACHA20 > config CRYPTO_CHACHA20_X86_64 > tristate "ChaCha stream cipher algorithms (x86_64/SSSE3/AVX2/AVX-512VL)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_SKCIPHER > select CRYPTO_LIB_CHACHA_GENERIC > select CRYPTO_ARCH_HAVE_LIB_CHACHA > @@ -1516,6 +1539,7 @@ config CRYPTO_SERPENT > config CRYPTO_SERPENT_SSE2_X86_64 > tristate "Serpent cipher algorithm (x86_64/SSE2)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_SKCIPHER > select CRYPTO_GLUE_HELPER_X86 > select CRYPTO_SERPENT > @@ -1535,6 +1559,7 @@ config CRYPTO_SERPENT_SSE2_X86_64 > config CRYPTO_SERPENT_SSE2_586 > tristate "Serpent cipher algorithm (i586/SSE2)" > depends on X86 && !64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_SKCIPHER > select CRYPTO_GLUE_HELPER_X86 > select CRYPTO_SERPENT > @@ -1554,6 +1579,7 @@ config CRYPTO_SERPENT_SSE2_586 > config CRYPTO_SERPENT_AVX_X86_64 > tristate "Serpent cipher algorithm (x86_64/AVX)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_SKCIPHER > select CRYPTO_GLUE_HELPER_X86 > select CRYPTO_SERPENT > @@ -1574,6 +1600,7 @@ config CRYPTO_SERPENT_AVX_X86_64 > config CRYPTO_SERPENT_AVX2_X86_64 > tristate "Serpent cipher algorithm (x86_64/AVX2)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_SERPENT_AVX_X86_64 > help > Serpent cipher algorithm, by Anderson, Biham & Knudsen. > @@ -1669,6 +1696,7 @@ config CRYPTO_TWOFISH_586 > config CRYPTO_TWOFISH_X86_64 > tristate "Twofish cipher algorithm (x86_64)" > depends on (X86 || UML_X86) && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_ALGAPI > select CRYPTO_TWOFISH_COMMON > help > @@ -1685,6 +1713,7 @@ config CRYPTO_TWOFISH_X86_64 > config CRYPTO_TWOFISH_X86_64_3WAY > tristate "Twofish cipher algorithm (x86_64, 3-way parallel)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_SKCIPHER > select CRYPTO_TWOFISH_COMMON > select CRYPTO_TWOFISH_X86_64 > @@ -1706,6 +1735,7 @@ config CRYPTO_TWOFISH_X86_64_3WAY > config CRYPTO_TWOFISH_AVX_X86_64 > tristate "Twofish cipher algorithm (x86_64/AVX)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_SKCIPHER > select CRYPTO_GLUE_HELPER_X86 > select CRYPTO_SIMD > -- > 2.25.1.696.g5e7596f4ac-goog >