From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08ECFC55179 for ; Thu, 29 Oct 2020 20:00:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6E2EB20825 for ; Thu, 29 Oct 2020 20:00:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="iMDTwDLe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E2EB20825 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 771DE6B005C; Thu, 29 Oct 2020 16:00:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 722326B0062; Thu, 29 Oct 2020 16:00:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 639036B0068; Thu, 29 Oct 2020 16:00:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 2EF7D6B005C for ; Thu, 29 Oct 2020 16:00:52 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CB3D61EE6 for ; Thu, 29 Oct 2020 20:00:51 +0000 (UTC) X-FDA: 77426031102.28.crown34_1f10f3527290 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 7D9AF6C3C for ; Thu, 29 Oct 2020 20:00:51 +0000 (UTC) X-HE-Tag: crown34_1f10f3527290 X-Filterd-Recvd-Size: 4661 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Thu, 29 Oct 2020 20:00:50 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id e7so3233561pfn.12 for ; Thu, 29 Oct 2020 13:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lCP1WO1+VHzaoW6B3s0gmUP2QnpBjOsDZXHhfza/ed8=; b=iMDTwDLekHKm2kQfUw61OXhU4hv2TL3TfsFBwe0mJNO4y8ryLBGRm4NP8gPS1ptNNi 2UBqD0A+kYcmo2GaqCAIUiRBemjZqKbLb4zYxzsqBTZ3R1q5kKSUJTBkbgRL5wXuGy16 Nw5lkLNmpAY1+ijcd4JMdBxZKVDKHagbuTI/qV4tWM4wgZMjCkqOd6DmZ/yIgA0sV8EA 2HKhL0PXWZzMDvCJjYpJCJNCA0LoOilEU84xno560sBrevL2uDsZtdwD3VOnVgRlYw4f Jqv4RDQ0zswFqUpFu1xhtwI2Fq8M0okebXZNgYib+IM8ZMiBdpM0sXVJkFAcl6dDbAa3 IMYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lCP1WO1+VHzaoW6B3s0gmUP2QnpBjOsDZXHhfza/ed8=; b=penvC8mx41HqQtvlSb9J3H11jM3ChfT8TFr50+ZbhlhDXvpCuHC/trz0vWAmAOunud ZByDseEuKZbPTzvTlpj0sViupvWwqhHVFrvArvgByG3Oiu5AZ1wPCJp+Gh76ZbeR8leA pC9BmGRonFLwuKz8okeiyACDdNaKdqhqjZHXoF6KStO5+cRpE++Trv/TttyjMwIBynyS Htq4HdEIhPgI79d7cBR0ya/wpDVP6WpfZxo8SbiZwf5OqT1ft/3g2SCyjzTvCmxZ5gyP cE9gF+L6DyFXCrt/Hvo5NIwJQKm0iPF093E0sEr5J5zdEOlwy4edr3SuTxIKeHEgzcN4 +j0g== X-Gm-Message-State: AOAM5300vCGSxbZmvWcHW1drkFy57KVmh4tUNkgOgTgeNMWpMSlhFW5c UJQE1EoIRdW+YEzuZI+NP887sC+cqkz6vW+XxfAe/Q== X-Google-Smtp-Source: ABdhPJzbQAUJk0kVFK3CtTs1GowkCphU5iW79ZzmaFBk380eaBTxf6iWXo14Dh/UKx+4MymCnOiVLxpRA+Ly/HIOhCU= X-Received: by 2002:a17:90b:807:: with SMTP id bk7mr1438790pjb.166.1604001649764; Thu, 29 Oct 2020 13:00:49 -0700 (PDT) MIME-Version: 1.0 References: <1049f02fb4132390a6a314eb21dccfe5500e69d6.1603372719.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Thu, 29 Oct 2020 21:00:38 +0100 Message-ID: Subject: Re: [PATCH RFC v2 05/21] kasan: allow VMAP_STACK for HW_TAGS mode To: Dmitry Vyukov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Kostya Serebryany , Peter Collingbourne , Serban Constantinescu , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 27, 2020 at 1:49 PM Dmitry Vyukov wrote: > > On Thu, Oct 22, 2020 at 3:19 PM Andrey Konovalov wrote: > > > > Even though hardware tag-based mode currently doesn't support checking > > vmalloc allocations, it doesn't use shadow memory and works with > > VMAP_STACK as is. > > > > Signed-off-by: Andrey Konovalov > > Link: https://linux-review.googlesource.com/id/I3552cbc12321dec82cd7372676e9372a2eb452ac > > --- > > arch/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/Kconfig b/arch/Kconfig > > index af14a567b493..3caf7bcdcf93 100644 > > --- a/arch/Kconfig > > +++ b/arch/Kconfig > > @@ -868,7 +868,7 @@ config VMAP_STACK > > default y > > bool "Use a virtually-mapped stack" > > depends on HAVE_ARCH_VMAP_STACK > > - depends on !KASAN || KASAN_VMALLOC > > + depends on !(KASAN_GENERIC || KASAN_SW_TAGS) || KASAN_VMALLOC > > I find it a bit simpler to interpret: > > depends on !KASAN || KASAN_HW_TAGS || KASAN_VMALLOC > > due to simpler structure. But maybe it's just me. This looks better, will fix in the next version, thanks!