From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAAD3C5517A for ; Wed, 11 Nov 2020 18:52:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 09F3A2100A for ; Wed, 11 Nov 2020 18:52:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="iNz4Bk2U" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09F3A2100A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5DAA06B005D; Wed, 11 Nov 2020 13:52:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 58C8B6B006C; Wed, 11 Nov 2020 13:52:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C9CF6B006E; Wed, 11 Nov 2020 13:52:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id 2119D6B005D for ; Wed, 11 Nov 2020 13:52:22 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BE1611EE6 for ; Wed, 11 Nov 2020 18:52:21 +0000 (UTC) X-FDA: 77473032882.13.scale58_38121d927300 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id A084B18140B70 for ; Wed, 11 Nov 2020 18:52:21 +0000 (UTC) X-HE-Tag: scale58_38121d927300 X-Filterd-Recvd-Size: 4879 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 18:52:21 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id c66so2162195pfa.4 for ; Wed, 11 Nov 2020 10:52:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e9me8OLCg9caFbPV5Uj2BdRlxnobSrjFoBA3jMpvquw=; b=iNz4Bk2UGOrF47EtwH9pt5EnTDKRQsVk6o+2eNqF0Gzn9RZmx1bK1W3xFKAi6lu5mh NLodQxAAUrOH0IC6qvoyUVZ3EODMH1Z0+vc+u2a0PWf334XenrxvguUFdi/A/fE5gL68 pjTTB8LMjFW7Kqj4I6zw5y04j8C5ENS1yXmJuKHiIFmk3X9+E4QzFU3QhP6dLblIyd3X NbKNYXPBJUTUVIFA/jPVc5Yb6cfI8XjI8qEXYDUvPfWI4gedug0Hs1e9lePIKfUf8a7o IUlc1ecYlKirHhIg5vyNg2FrNu3FCvhfR6tHBEGI/zxrvK159EqM76lAxfdOIsCNvqxl v6zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e9me8OLCg9caFbPV5Uj2BdRlxnobSrjFoBA3jMpvquw=; b=igAHsuVDqxyfccNZc5CKs2mx7bAAVycdVP3TOXw4JM90H+1ruUCJTBTDyPHzWAdghZ /LH1/dMgQD/4Rrlue+xSiYzgNUACyTnAem9vblXoftoNzkwpMpMimR5PvHbqhcsQWp39 H7Dy5s2U97eh6iRNaFrMXQhNCHZdkIlyrYyPptJ4N+3KZo7nHSiBVt1GX/+sJkPhlQQe Q/hDqJrLQOebh141s73B/BqhnowKrThEokEP/4krO18KdJINAToTPBQ2zUgGCPbrDI03 j89bVhbTKBI+snj57yi1SCoeduinVWa7yfGat3wIUX3vXFcxhQZvE2CYS3iuj1dT0Nyj 68JQ== X-Gm-Message-State: AOAM531JKG4uGGkUq78zVBTQVRs2bRZdREjsrBulG5r+Fhzr6oHxK+VM bR1IhfGUQ8Q2L8KoDDGfpcZ4ARJHDCU+2fwLLagBOw== X-Google-Smtp-Source: ABdhPJykU80dffJSIdNduPLXhQGxEkHGO5yecTSm+N651CeXvmn1GahM1mQkhtZRZnMW2ZlVA9Yu+8f659ZlUSnD150= X-Received: by 2002:a62:cec6:0:b029:18a:d620:6b86 with SMTP id y189-20020a62cec60000b029018ad6206b86mr23279253pfg.2.1605120740077; Wed, 11 Nov 2020 10:52:20 -0800 (PST) MIME-Version: 1.0 References: <49f7f2c12b0d5805f9a7b7092b986bbc2dd077a1.1605046192.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Wed, 11 Nov 2020 19:52:09 +0100 Message-ID: Subject: Re: [PATCH v9 21/44] kasan: kasan_non_canonical_hook only for software modes To: Alexander Potapenko Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 11, 2020 at 4:09 PM Alexander Potapenko wrote: > > On Tue, Nov 10, 2020 at 11:11 PM Andrey Konovalov wrote: > > > > This is a preparatory commit for the upcoming addition of a new hardware > > tag-based (MTE-based) KASAN mode. > > > > kasan_non_canonical_hook() is only applicable to KASAN modes that use > > shadow memory, and won't be needed for hardware tag-based KASAN. > > > > No functional changes for software modes. > > > > Signed-off-by: Andrey Konovalov > > Signed-off-by: Vincenzo Frascino > > Reviewed-by: Marco Elver > > --- > > Change-Id: Icc9f5ef100a2e86f3a4214a0c3131a68266181b2 > > --- > > mm/kasan/report.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > > index 5d5733831ad7..594bad2a3a5e 100644 > > --- a/mm/kasan/report.c > > +++ b/mm/kasan/report.c > > @@ -403,7 +403,8 @@ bool kasan_report(unsigned long addr, size_t size, bool is_write, > > return ret; > > } > > > > -#ifdef CONFIG_KASAN_INLINE > > +#if (defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS)) && \ > > + defined(CONFIG_KASAN_INLINE) > > /* > > * With CONFIG_KASAN_INLINE, accesses to bogus pointers (outside the high > > * canonical half of the address space) cause out-of-bounds shadow memory reads > > Perhaps this comment also needs to be updated. In what way?