From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78FFCC2D0E4 for ; Thu, 12 Nov 2020 19:27:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C6E4A20B80 for ; Thu, 12 Nov 2020 19:27:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="d77qtn8Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6E4A20B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C24CA6B0036; Thu, 12 Nov 2020 14:27:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BAE326B005C; Thu, 12 Nov 2020 14:27:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A75696B0068; Thu, 12 Nov 2020 14:27:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id 777196B0036 for ; Thu, 12 Nov 2020 14:27:19 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 232AE1EE6 for ; Thu, 12 Nov 2020 19:27:19 +0000 (UTC) X-FDA: 77476749798.15.roof67_2e1030a27308 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 038781814B0C7 for ; Thu, 12 Nov 2020 19:27:18 +0000 (UTC) X-HE-Tag: roof67_2e1030a27308 X-Filterd-Recvd-Size: 5710 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Nov 2020 19:27:17 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id g7so5488225pfc.2 for ; Thu, 12 Nov 2020 11:27:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xycyBHYzWiVaz+V9gLDQX6HE1E3HaoQ5YhnMfRsWwHI=; b=d77qtn8YZRh/AQDOvMteWddTQy3QqcvCr4HFZmmE3hz1br3LMK/NbAG3k+k3xODi3/ ASmDD98lubGa9NJ8Wzq9bKaVt9JY3HKEfCzk1Qh0lFmf2QUIztT7WPPDaH0BUeoqbTnW xn7YIWG3wK1v+c4PTAtSNQ2k8ND/UsrXhn21Aa8zwn+oL90K4kZiCMSEsWBG2Bzbxj0E OFsIiTJa2sxHM1pLhsdmsrPH9ig+NRIOEAfJjt4L+pHacdAyKbjqyfjMPU2DTVON8YNl k1NkpxfgAzm4bQr8QVJioD816VUeh0n4KcQUFM1RBtdN9NR05kj470o+m4p6tMw2+ck/ vYxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xycyBHYzWiVaz+V9gLDQX6HE1E3HaoQ5YhnMfRsWwHI=; b=S7eeGjtQzrxNLwtFFdeqc6II+lI26lzkcslNiptp7aqUMtmFIG4efJUVSTVTn+/ZRs xtdE0dmQmAAouxEnU25jEoZRYXEDbFu+0921pu0S0HEYfgNeHH5yATSr0KXtHqHlF2aw kLG2rLmaBrHUPU/D0dYxS+BQSNxEytA05tH7vLU14e7HCizu0Kj2O+0u8DTMbkxve8MY qBFaAKGX8KMESuwtzBL0/+mFlfcU+KATzCpKwcgvhuvFQc/6MXumr6oD4zTRyFUJhBv7 av5fEy/AvdTD6e1ZHO/TlCyVNBk5Pr3MtRUJGhV4RIHxuxC6ev8VOUqdKbCbZJOmSDgD +sEg== X-Gm-Message-State: AOAM5318mbwDaoRfMkxBm4uCo99XFn6tVBpMHMgBWdaeOMxiGzofeFbD +X7DdMv4h/lIsj5wxjjv3V9qvBSR52pkMMvrauUAUg== X-Google-Smtp-Source: ABdhPJzGsAs7K5YmJeT7a5J9GmyJkaJyaoemUzPhUj2Gpuh+rkQNq9gc9pGSSZ642a8HYgxMYzcYgnpVxakIRaPJJ/I= X-Received: by 2002:a17:90a:eb02:: with SMTP id j2mr747894pjz.136.1605209236569; Thu, 12 Nov 2020 11:27:16 -0800 (PST) MIME-Version: 1.0 References: <49f7f2c12b0d5805f9a7b7092b986bbc2dd077a1.1605046192.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Thu, 12 Nov 2020 20:27:05 +0100 Message-ID: Subject: Re: [PATCH v9 21/44] kasan: kasan_non_canonical_hook only for software modes To: Alexander Potapenko Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 12, 2020 at 4:16 PM Alexander Potapenko wrote: > > On Wed, Nov 11, 2020 at 7:52 PM 'Andrey Konovalov' via kasan-dev > wrote: > > > > On Wed, Nov 11, 2020 at 4:09 PM Alexander Potapenko wrote: > > > > > > On Tue, Nov 10, 2020 at 11:11 PM Andrey Konovalov wrote: > > > > > > > > This is a preparatory commit for the upcoming addition of a new hardware > > > > tag-based (MTE-based) KASAN mode. > > > > > > > > kasan_non_canonical_hook() is only applicable to KASAN modes that use > > > > shadow memory, and won't be needed for hardware tag-based KASAN. > > > > > > > > No functional changes for software modes. > > > > > > > > Signed-off-by: Andrey Konovalov > > > > Signed-off-by: Vincenzo Frascino > > > > Reviewed-by: Marco Elver > > > > --- > > > > Change-Id: Icc9f5ef100a2e86f3a4214a0c3131a68266181b2 > > > > --- > > > > mm/kasan/report.c | 3 ++- > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > > > > index 5d5733831ad7..594bad2a3a5e 100644 > > > > --- a/mm/kasan/report.c > > > > +++ b/mm/kasan/report.c > > > > @@ -403,7 +403,8 @@ bool kasan_report(unsigned long addr, size_t size, bool is_write, > > > > return ret; > > > > } > > > > > > > > -#ifdef CONFIG_KASAN_INLINE > > > > +#if (defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS)) && \ > > > > + defined(CONFIG_KASAN_INLINE) > > > > /* > > > > * With CONFIG_KASAN_INLINE, accesses to bogus pointers (outside the high > > > > * canonical half of the address space) cause out-of-bounds shadow memory reads > > > > > > Perhaps this comment also needs to be updated. > > > > In what way? > > Ok, maybe not. I thought you were restricting the set of configs under > which this hook is used, so this should've been explained. > But as far as I understand, CONFIG_KASAN_INLINE already implies > "defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS)", > doesn't it? > Maybe this change is not needed at all then? Ah, yes, you're right. Will drop this patch, thanks!