From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CE45C54FD0 for ; Thu, 23 Apr 2020 19:22:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C79B42075A for ; Thu, 23 Apr 2020 19:22:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ouKVXMYa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C79B42075A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 793D88E0009; Thu, 23 Apr 2020 15:22:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71D2F8E0003; Thu, 23 Apr 2020 15:22:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60B9A8E0009; Thu, 23 Apr 2020 15:22:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id 4692B8E0003 for ; Thu, 23 Apr 2020 15:22:31 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id F04C4180AD822 for ; Thu, 23 Apr 2020 19:22:30 +0000 (UTC) X-FDA: 76740091260.17.frame84_6d3a691d1a52b X-HE-Tag: frame84_6d3a691d1a52b X-Filterd-Recvd-Size: 5944 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Thu, 23 Apr 2020 19:22:30 +0000 (UTC) Received: by mail-pl1-f193.google.com with SMTP id f8so2750001plt.2 for ; Thu, 23 Apr 2020 12:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cX2Ug2OBCbQlDwd0b1Kt7ExDkgbwcF8sT2YYQwioyro=; b=ouKVXMYaGaLqRbH13MQfz0/HJQ1CPaU9WuWW3mTLW9nCUouGn2fupVgseBemnqxOoA oPl+KR3oexiTOqt4E05VZsrIe3QBwWfnxMYVI7eKePLDuehdf4zCdQnYovhsXcBwZecf SQP/8BgEIxppkTN5Fzu8NUgbT/ANk0CCdpiFW3Fug1zx3sZiqeIswBGWrIE4QvmI5l35 06Lz6lua3GaQAe99tfO5jtEn6WtTos7d9IA+vftoQ5u7gu6gOwksDOik79IHLjExADgA ji7TAwr0mZ5IOJCMRCbydqV4gLEdC66gwB95cEJnG34bEyYyv7t+rPmZM6Uvz0rJAREM YvRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cX2Ug2OBCbQlDwd0b1Kt7ExDkgbwcF8sT2YYQwioyro=; b=EYqg5e0aeXGmdf74dOXfHPtLpZ2Xw+qpkrWFuv1hQsKtfCgVE4ywu3nRtDhaDOsq3D 4IyHQJ9kX4aEGLeDy6P6PjozhQ7wK/SlrbgdpKfeus6kcs6iX/bzaTQniwFqaIXXe+f+ cLKvOieqHJyJ7nc+XrWmcTiv4cPmcoaN9WGbv7qli7ECii+oHRO0j35H29fCJTNHjrBu gl2vHZlsJFkKqFFJFovTKzmKktU6Xqb4Lu/+lGq7kcIvZb75ANhH2bSW7Vm740rjj8Jc DP5hM8a86wH8xsFQZoBV/mIjnlrteaJQU/ccPg7fB9rZ1Cxf3xNs1+nSnuq39L0GB9o4 AQ5Q== X-Gm-Message-State: AGi0PuZ8l+ScUkDn5nlNoS13AGB7rapLaLcNlCz1y490ZdClbdlBz3H8 A7iaWEMuYiK/GHYG0lh7q0q4lLtMkodoJPwAeKkSSg== X-Google-Smtp-Source: APiQypImJiX9TIPhr+8AfOrAzwJedHWbVs2+ygpADMJpH+stX9z9bJMQY31nE52TjFI660hQDhBmCeNJZXjXd4JQCvQ= X-Received: by 2002:a17:902:9889:: with SMTP id s9mr4838918plp.252.1587669749410; Thu, 23 Apr 2020 12:22:29 -0700 (PDT) MIME-Version: 1.0 References: <20200325161249.55095-1-glider@google.com> <20200325161249.55095-10-glider@google.com> In-Reply-To: <20200325161249.55095-10-glider@google.com> From: Andrey Konovalov Date: Thu, 23 Apr 2020 21:22:18 +0200 Message-ID: Subject: Re: [PATCH v5 09/38] kmsan: stackdepot: don't allocate KMSAN metadata for stackdepot To: Alexander Potapenko Cc: Andrey Ryabinin , Jens Axboe , Andy Lutomirski , Vegard Nossum , Dmitry Vyukov , Marco Elver , Christoph Hellwig , Linux Memory Management List , Alexander Viro , Andreas Dilger , Andrew Morton , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , "Darrick J. Wong" , "David S. Miller" , Dmitry Torokhov , Eric Biggers , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Marek Szyprowski , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S . Tsirkin" , Michal Hocko , Michal Simek , Petr Mladek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 25, 2020 at 5:13 PM wrote: > > We assume an uninitialized value couldn't come from stackdepot, so > we don't track stackdepot allocations with KMSAN. > > Signed-off-by: Alexander Potapenko > Cc: Andrey Ryabinin > Cc: Jens Axboe > Cc: Andy Lutomirski > Cc: Vegard Nossum > Cc: Dmitry Vyukov > Cc: Marco Elver > Cc: Andrey Konovalov > Cc: Christoph Hellwig > Cc: linux-mm@kvack.org Reviewed-by: Andrey Konovalov > --- > > v4: > - set __GFP_NO_KMSAN_SHADOW explicitly for allocations > > Change-Id: Ic3ec9b3dff3fff2732d874508a3582fb26ff0b1f > --- > lib/stackdepot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/stackdepot.c b/lib/stackdepot.c > index 195ce3dc7c37e..ba584910ad66b 100644 > --- a/lib/stackdepot.c > +++ b/lib/stackdepot.c > @@ -297,7 +297,7 @@ depot_stack_handle_t stack_depot_save(unsigned long *entries, > */ > alloc_flags &= ~GFP_ZONEMASK; > alloc_flags &= (GFP_ATOMIC | GFP_KERNEL); > - alloc_flags |= __GFP_NOWARN; > + alloc_flags |= (__GFP_NOWARN | __GFP_NO_KMSAN_SHADOW); > page = alloc_pages(alloc_flags, STACK_ALLOC_ORDER); > if (page) > prealloc = page_address(page); > -- > 2.25.1.696.g5e7596f4ac-goog >