From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A84EC2D0A3 for ; Wed, 4 Nov 2020 19:22:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 99AE22083B for ; Wed, 4 Nov 2020 19:22:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="c+mg+DzL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99AE22083B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E73736B007B; Wed, 4 Nov 2020 14:22:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DFC4F6B0080; Wed, 4 Nov 2020 14:22:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEA7B6B0081; Wed, 4 Nov 2020 14:22:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id 9E5886B007B for ; Wed, 4 Nov 2020 14:22:21 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 41D1F8249980 for ; Wed, 4 Nov 2020 19:22:21 +0000 (UTC) X-FDA: 77447706882.11.tray20_4910c86272c3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 0AD60180F8B81 for ; Wed, 4 Nov 2020 19:22:21 +0000 (UTC) X-HE-Tag: tray20_4910c86272c3 X-Filterd-Recvd-Size: 5267 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Nov 2020 19:22:19 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id b12so10762067plr.4 for ; Wed, 04 Nov 2020 11:22:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1AS6LJKOijonuhwsBoB44CLu/ocg1LiPjNjpXhH5Y8E=; b=c+mg+DzLn/N+UEJNBB+4veQnmWwotqeTUw/rCUoIWXye/WJzZBi0M/Pyxx/PNq2rEQ jMxwH1zM+yd4q8gmwV4ru1iRUrC6U6ndNLcad8yba/pdW8hMvLnWF+FMdvsO+CPTimYy ajQmH/Wrn8dsI56XipHtodaGZyqJHT9xM81ZYDJ4RE7++id4RUHCu3a8pLthQ8H1Sfa1 Wv5yA5rI8k+08XW1XzaJdOFMvy2qXEJw+vfCBXfd7TrfB2oXGm9VpTRnOAkkOc5qOmDS dOY1e3gQCxdOla/C5iLBjYMoF6+1417bhfo2zIhDLLOIb/XAmo8SaVVGGu8cybI6ZI9C 8mEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1AS6LJKOijonuhwsBoB44CLu/ocg1LiPjNjpXhH5Y8E=; b=ZbYiiCGJv71orwCOufMgaU/EkmgYyiBkZGDFHrb4XHDFtil/jqhkzETtSTcD1bmw5h RY5OlIqfY33ZemSI2bha7GGT92tdrahG9RMF3Y+2OvZCIe/TqFuPnMdTsZbFPAbnavjC CTiwEV/GVQ2wSBSC970cV6cL6IVv00ciwrf5vMK/hDLnd4NW/XTS5/I+TxGwVq18TAuO bva3Bnips44TMIRvwGRE3eKRLT0Up+UlYVAHzWGjfO41w3UC40GKM7tg6lDjIhv6WLeH 2t/vifkIxpUavACQ4MxWm3LKmqmHaGqENnH+btVTRI5ZRzLCxczZzhXrhO/phvCDYDC/ uKaQ== X-Gm-Message-State: AOAM533c+1DHkq6BRLUoLpEFH+uxQubXxk7zyAk1ABQ6HdZhVe0esLo3 dVIoT8G9iBBLVUAAQsGO1cQWAwGZcOmraKRuQ+A9Fw== X-Google-Smtp-Source: ABdhPJw0130ycGFYPg+WxQoIUzb5lSobSiqo0GY/ZxXtvcSA/Z47gVexTwvVanpaUPrMOfMNVUylwlZMpHbm1Bk2oGU= X-Received: by 2002:a17:902:d90d:b029:d6:ecf9:c1dd with SMTP id c13-20020a170902d90db02900d6ecf9c1ddmr3847240plz.13.1604517738891; Wed, 04 Nov 2020 11:22:18 -0800 (PST) MIME-Version: 1.0 References: <4dee872cf377e011290bbe2e90c7e7fd24e789dd.1604333009.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Wed, 4 Nov 2020 20:22:07 +0100 Message-ID: Subject: Re: [PATCH v7 16/41] kasan: rename KASAN_SHADOW_* to KASAN_GRANULE_* To: Vasily Gorbik Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , kasan-dev , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 4, 2020 at 8:11 PM Vasily Gorbik wrote: > > On Mon, Nov 02, 2020 at 05:03:56PM +0100, Andrey Konovalov wrote: > > This is a preparatory commit for the upcoming addition of a new hardware > > tag-based (MTE-based) KASAN mode. > > > > The new mode won't be using shadow memory, but will still use the concept > > of memory granules. Each memory granule maps to a single metadata entry: > > 8 bytes per one shadow byte for generic mode, 16 bytes per one shadow byte > > for software tag-based mode, and 16 bytes per one allocation tag for > > hardware tag-based mode. > > > > Rename KASAN_SHADOW_SCALE_SIZE to KASAN_GRANULE_SIZE, and KASAN_SHADOW_MASK > > to KASAN_GRANULE_MASK. > > > > Also use MASK when used as a mask, otherwise use SIZE. > > > > No functional changes. > > > > Signed-off-by: Andrey Konovalov > > Signed-off-by: Vincenzo Frascino > > Reviewed-by: Marco Elver > > --- > > Change-Id: Iac733e2248aa9d29f6fc425d8946ba07cca73ecf > > --- > > Documentation/dev-tools/kasan.rst | 2 +- > > lib/test_kasan.c | 2 +- > > mm/kasan/common.c | 39 ++++++++++++++++--------------- > > mm/kasan/generic.c | 14 +++++------ > > mm/kasan/generic_report.c | 8 +++---- > > mm/kasan/init.c | 8 +++---- > > mm/kasan/kasan.h | 4 ++-- > > mm/kasan/report.c | 10 ++++---- > > mm/kasan/tags_report.c | 2 +- > > 9 files changed, 45 insertions(+), 44 deletions(-) > > hm, this one got escaped somehow > > lib/test_kasan_module.c: > 18 #define OOB_TAG_OFF (IS_ENABLED(CONFIG_KASAN_GENERIC) ? 0 : KASAN_SHADOW_SCALE_SIZE) You mean it's not on the patch? It is, almost at the very top. Or do you mean something else?