From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D677DC3815B for ; Tue, 14 Apr 2020 14:56:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8B78220578 for ; Tue, 14 Apr 2020 14:56:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="s1MmO9Zc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B78220578 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 371B78E0003; Tue, 14 Apr 2020 10:56:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 321D88E0001; Tue, 14 Apr 2020 10:56:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 210CE8E0003; Tue, 14 Apr 2020 10:56:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id 08EAC8E0001 for ; Tue, 14 Apr 2020 10:56:27 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id BE645824556B for ; Tue, 14 Apr 2020 14:56:26 +0000 (UTC) X-FDA: 76706761572.02.gun63_1b1ee90145c5f X-HE-Tag: gun63_1b1ee90145c5f X-Filterd-Recvd-Size: 7832 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Apr 2020 14:56:26 +0000 (UTC) Received: by mail-pj1-f66.google.com with SMTP id a32so5371989pje.5 for ; Tue, 14 Apr 2020 07:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NtLYFZcwZjjkmEi7lYlFs2vmaeFslRSweusNpdStubw=; b=s1MmO9ZcF/8UAadMdgpD4T0el8Vx4Ym8pM3zrO5rqkKzMoLa6uxX2p6z16s2Z3t7uM M3dUJgDwKT3XCPjdckTPUqmZcQdhMDiVYiPgFj+oTEGgRifPyP5qZWL9FVQUoZ6TxwzQ +LsvjgQeEonUL/3Zjv00PCip1PKxLN3tzBlcMEXNFf946uM1ZjXhLP+/iBPzwph2fXBq o5VQCyrOPKYnBkJRWwcJSUKV+IJDvHny1C9SNN4UXhAwziizzCn6MdWKEY29Vw5qSzy6 DqJM0bvZyVklIgTlYzKyahkMvybhTYTPEpkV/QR1K3ZZwiB0nDaRWedQCaTxmwblCPkI nvCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NtLYFZcwZjjkmEi7lYlFs2vmaeFslRSweusNpdStubw=; b=bOuYudlgEACykhQzLUgd20KUbwH1E9ROBlI8NCRupkJPtQJbcF+z/QS1INz8mUcRgl OcvcfC6NE+7SJpcKx0BIq+CCPdI1UI+wfXA6spVDPR6VP4CRKg2vcTtgneZ28WkA8bbI aG5ig90ZieffePfAy+JqMgILIDgjMYNXLq/H4Gx1b93EYardJFkV6H8GGTE8ZkrDat7N gTdQsQiWynR5MGsM1csAkP/O22QyEjKVrFnIqRHIpwrgSGzkpzp7bjkKBn2zTHMewRqv CPdgDBl1QN7qGAsHaqvh7ewglGWNHd4V/pOIBrRcHlTh5dmaxtSbuEU6mjo4agCveWwW T0Lg== X-Gm-Message-State: AGi0PuYIxv+LdpvSF9SjlFYNZnc0W3L4jb+bf90OOwpoMXX7uEVu9hqo t+BfOcPP6TGChFgDJ6dL19uLc5m7wopq+wH7q9ql1A== X-Google-Smtp-Source: APiQypKsKf95Nv+gf6aPUWGyUVDTNotez7ZUnDmioIwNfT8c8oMejfMeBIBGLRl22NEg+Dvy8YcqePldx3aCy4K+b38= X-Received: by 2002:a17:90a:9af:: with SMTP id 44mr554001pjo.128.1586876185117; Tue, 14 Apr 2020 07:56:25 -0700 (PDT) MIME-Version: 1.0 References: <20200325161249.55095-1-glider@google.com> <20200325161249.55095-30-glider@google.com> In-Reply-To: <20200325161249.55095-30-glider@google.com> From: Andrey Konovalov Date: Tue, 14 Apr 2020 16:56:13 +0200 Message-ID: Subject: Re: [PATCH v5 29/38] kmsan: enable KMSAN builds To: Alexander Potapenko Cc: Jens Axboe , Andy Lutomirski , Vegard Nossum , Dmitry Vyukov , Marco Elver , Linux Memory Management List , Alexander Viro , Andreas Dilger , Andrew Morton , Andrey Ryabinin , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , Christoph Hellwig , "Darrick J. Wong" , "David S. Miller" , Dmitry Torokhov , Eric Biggers , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Marek Szyprowski , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S . Tsirkin" , Michal Hocko , Michal Simek , Petr Mladek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 25, 2020 at 5:14 PM wrote: > > Make KMSAN usable by adding the necessary Makefile bits. > > Signed-off-by: Alexander Potapenko > To: Alexander Potapenko > Cc: Jens Axboe > Cc: Andy Lutomirski > Cc: Vegard Nossum > Cc: Dmitry Vyukov > Cc: Marco Elver > Cc: Andrey Konovalov > Cc: linux-mm@kvack.org > > --- > This patch was previously called "kmsan: Changing existing files to > enable KMSAN builds". Logically unrelated parts of it were split away. > > v4: > - split away changes to init/main.c as requested by Andrey Konovalov Hm, I've forgotten what exactly I asked here :( But right now this patch looks like parts of other patches. > > Change-Id: I37e0b7f2d2f2b0aeac5753ff9d6b411485fc374e > --- > Makefile | 3 ++- > mm/Makefile | 1 + > scripts/Makefile.lib | 6 ++++++ > 3 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index a532333b4cd02..da315f20618b3 100644 > --- a/Makefile > +++ b/Makefile > @@ -482,7 +482,7 @@ export KBUILD_HOSTCXXFLAGS KBUILD_HOSTLDFLAGS KBUILD_HOSTLDLIBS LDFLAGS_MODULE > > export KBUILD_CPPFLAGS NOSTDINC_FLAGS LINUXINCLUDE OBJCOPYFLAGS KBUILD_LDFLAGS > export KBUILD_CFLAGS CFLAGS_KERNEL CFLAGS_MODULE > -export CFLAGS_KASAN CFLAGS_KASAN_NOSANITIZE CFLAGS_UBSAN CFLAGS_KCSAN > +export CFLAGS_KASAN CFLAGS_KASAN_NOSANITIZE CFLAGS_UBSAN CFLAGS_KCSAN CFLAGS_KMSAN > export KBUILD_AFLAGS AFLAGS_KERNEL AFLAGS_MODULE > export KBUILD_AFLAGS_MODULE KBUILD_CFLAGS_MODULE KBUILD_LDFLAGS_MODULE > export KBUILD_AFLAGS_KERNEL KBUILD_CFLAGS_KERNEL > @@ -901,6 +901,7 @@ KBUILD_CFLAGS += $(call cc-option,-fcf-protection=none) > endif > > include scripts/Makefile.kasan > +include scripts/Makefile.kmsan I think this change should go together with the addition of scripts/Makefile.kmsan. > include scripts/Makefile.extrawarn > include scripts/Makefile.ubsan > include scripts/Makefile.kcsan > diff --git a/mm/Makefile b/mm/Makefile > index fa91e963c2f9e..7b9bce9cc0afb 100644 > --- a/mm/Makefile > +++ b/mm/Makefile > @@ -81,6 +81,7 @@ obj-$(CONFIG_PAGE_POISONING) += page_poison.o > obj-$(CONFIG_SLAB) += slab.o > obj-$(CONFIG_SLUB) += slub.o > obj-$(CONFIG_KASAN) += kasan/ > +obj-$(CONFIG_KMSAN) += kmsan/ And this change should go together with the addition or enabling of CONFIG_KMSAN. > obj-$(CONFIG_FAILSLAB) += failslab.o > obj-$(CONFIG_MEMORY_HOTPLUG) += memory_hotplug.o > obj-$(CONFIG_MEMTEST) += memtest.o > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index b12dd5ba48960..e9a8c2671a4b3 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -137,6 +137,12 @@ _c_flags += $(if $(patsubst n%,, \ > $(CFLAGS_KASAN), $(CFLAGS_KASAN_NOSANITIZE)) > endif > > +ifeq ($(CONFIG_KMSAN),y) > +_c_flags += $(if $(patsubst n%,, \ > + $(KMSAN_SANITIZE_$(basetarget).o)$(KMSAN_SANITIZE)y), \ > + $(CFLAGS_KMSAN)) > +endif > + And this looks like it deserves to be together with the definition of CFLAGS_KMSAN. > ifeq ($(CONFIG_UBSAN),y) > _c_flags += $(if $(patsubst n%,, \ > $(UBSAN_SANITIZE_$(basetarget).o)$(UBSAN_SANITIZE)$(CONFIG_UBSAN_SANITIZE_ALL)), \ > -- > 2.25.1.696.g5e7596f4ac-goog >