From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1452C433E0 for ; Thu, 7 Jan 2021 01:59:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3010422BEA for ; Thu, 7 Jan 2021 01:59:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3010422BEA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6FCD18D0112; Wed, 6 Jan 2021 20:59:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AE058D0090; Wed, 6 Jan 2021 20:59:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59CFD8D0112; Wed, 6 Jan 2021 20:59:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 418208D0090 for ; Wed, 6 Jan 2021 20:59:43 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 04E8A8245571 for ; Thu, 7 Jan 2021 01:59:43 +0000 (UTC) X-FDA: 77677322646.22.wall59_37148a2274e6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id DE0B418038E60 for ; Thu, 7 Jan 2021 01:59:42 +0000 (UTC) X-HE-Tag: wall59_37148a2274e6 X-Filterd-Recvd-Size: 4885 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Jan 2021 01:59:42 +0000 (UTC) Received: by mail-pg1-f181.google.com with SMTP id 15so3660361pgx.7 for ; Wed, 06 Jan 2021 17:59:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dwRklFypON9ymYuJdkSeEyVAOtCE8vnlHBFLWfNebOw=; b=qbNtHL8IUPmB93E4Yb/7mn7axeEyeDz8Eg5slCvCUmUjPGcDMD7SHpCjDl/x+fhirL BwTkpazZ3Guse9OOjk3+PbLKpVKh8MRQ3d8TxfEHN7Di0WUbDmosbF49GS/teSkoDBvr k8WNz9bP89CuvEfeHb0HSpXN4/11W1Qx/iv8FJV5x/EbwSg9HHb38ayi8bU8vKaPhxdE O+U+RDlG9xT6ZJr+wUeLP7vPvwupb3AE8sBN3hZB0vpxAU8u2JC8+oC0/3Owv+gelvHI E0v0I4n1po9Hk7om22WrA+bsaoTT1l6QN4p6FNChNLahGs+sLjdPBv29Kq5vtOSd5QJT L3Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dwRklFypON9ymYuJdkSeEyVAOtCE8vnlHBFLWfNebOw=; b=HHg+jQSV2q7V4MzxYhT8O31zMrtw4H/7K4B+TfVaG1WVlnc0OZmKr7RkviYvRaGQR8 LK6ILKGHGX9ujX2THUetpf0nhmW967XEzyAJR1l8pJfFqnchiSiVOLliVxmT1247oejf fTNO5zv6+cTO6kNgXyz0ECUDS99YUlF+xWfOX+0BWmjmkSffRjrpBnaf7dT1Ucb7rnKf 1C34H53/Ynqq5wKEFSveZj+6N4IQ9xz1fOprioIeUGr7htz78mQV3jbU40zuU/dk0ghF W9si1NdBnx7CXSF8J1qw9P80nabFROp3hESPa8UU19/OKlZddXf/ASLNRLUz7P1/AX6g pMnw== X-Gm-Message-State: AOAM530wXWituUtKFlifFz2bi8n/h1DmURzhTqVjUuZsKleo7XJkLeIh LL6LT52/eqad2n+T4yaWxmYQeZZhFJKHEm+iXokYBw== X-Google-Smtp-Source: ABdhPJymCNgpGKk23UvNeALWJ51IQKBwUv6+Tpt2JdQ3m9oJbmtd8fKgVj5GSq4rXgzCTWwCoPigAdI6MAKGa5pkGMM= X-Received: by 2002:a62:e309:0:b029:1ae:5b4a:3199 with SMTP id g9-20020a62e3090000b02901ae5b4a3199mr5771408pfh.24.1609984781252; Wed, 06 Jan 2021 17:59:41 -0800 (PST) MIME-Version: 1.0 References: <202101060828.QFNIkNMv-lkp@intel.com> <20210106160250.24b79d8d119a7ff0a5414f3f@linux-foundation.org> In-Reply-To: <20210106160250.24b79d8d119a7ff0a5414f3f@linux-foundation.org> From: Andrey Konovalov Date: Thu, 7 Jan 2021 02:59:30 +0100 Message-ID: Subject: Re: [PATCH 10/11] kasan: fix bug detection via ksize for HW_TAGS mode To: Andrew Morton Cc: kernel test robot , Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Marco Elver , kbuild-all@lists.01.org, clang-built-linux , Linux Memory Management List , Will Deacon , Andrey Ryabinin , Evgenii Stepanov Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 7, 2021 at 1:02 AM Andrew Morton wrote: > > On Wed, 6 Jan 2021 08:09:00 +0800 kernel test robot wrote: > > > Hi Andrey, > > In file included from arch/x86/boot/compressed/cmdline.c:2: > > In file included from arch/x86/boot/compressed/misc.h:30: > > In file included from include/linux/acpi.h:14: > > In file included from include/linux/resource_ext.h:11: > > In file included from include/linux/slab.h:136: > > >> include/linux/kasan.h:314:77: warning: non-void function does not return a value [-Wreturn-type] > > static inline bool kasan_check_byte(const void *address, unsigned long ip) {} > > ^ > > 1 warning generated. > > > > This? > > --- a/include/linux/kasan.h~kasan-fix-bug-detection-via-ksize-for-hw_tags-mode-fix > +++ a/include/linux/kasan.h > @@ -311,7 +311,10 @@ static inline void *kasan_krealloc(const > return (void *)object; > } > static inline void kasan_kfree_large(void *ptr, unsigned long ip) {} > -static inline bool kasan_check_byte(const void *address, unsigned long ip) {} > +static inline bool kasan_check_byte(const void *address, unsigned long ip) > +{ > + return true; > +} > > #endif /* CONFIG_KASAN */ Yes. > btw, "kasan_check_byte" isn't a good function name. Check for what? > Does it return true for a check which passed, or for a check which > failed? Something like "kasan_byte_valid" would be better - the name > explains the return value. Sounds good, will fix in v2 along with the warning. Thank you!