From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE7FBC388F9 for ; Thu, 12 Nov 2020 00:05:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0ADC120759 for ; Thu, 12 Nov 2020 00:05:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="a9rslGNN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0ADC120759 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EACBB6B0036; Wed, 11 Nov 2020 19:05:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E5CBF6B005D; Wed, 11 Nov 2020 19:05:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D714F6B0068; Wed, 11 Nov 2020 19:05:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id AC3B76B0036 for ; Wed, 11 Nov 2020 19:05:43 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 531553629 for ; Thu, 12 Nov 2020 00:05:43 +0000 (UTC) X-FDA: 77473822566.03.stamp31_330cf6027301 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 3296328A4E8 for ; Thu, 12 Nov 2020 00:05:43 +0000 (UTC) X-HE-Tag: stamp31_330cf6027301 X-Filterd-Recvd-Size: 4524 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Nov 2020 00:05:42 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id z24so2617206pgk.3 for ; Wed, 11 Nov 2020 16:05:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eIXncWLvf3BJhcwIlL7/HzTlh6QP9c7KA+O5cQg6G3M=; b=a9rslGNNyF79v94Kg4Q/UmR2Xmf/bZEGFLn4vd48EBDq+CC8G2JRrpsbNUuHeJVehx jimGRp6ErXtI6zqp9GXe7tHGi9GbMzq89KQauoNglSskzAWUuW0MHt7AZ2WpSxbsPl5+ tPBtVTY42Zt8DxyLlBMdyLvzOFzQeTwzQ6oNMmxkqbn7L8eFqBIE0bUYz7iKYJBiWvOk Z52DcVu3U2Z/Dh5yup94zky1g85mDQrh4l67WRMiR0tfsddDwMcWkXs6zgH+SCbZmBxb z/IGM+O7cakfJmeAUYqCtMRlbKe90jDKBPM4MV3qNmypw1mXVRuFAOTgWLUGtCgpICq7 Q57w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eIXncWLvf3BJhcwIlL7/HzTlh6QP9c7KA+O5cQg6G3M=; b=Zikft5PcLWeZBtozCYEv1HEUJJikI037UUiKP6oQg82499It3iAvW5tT3zQZV6a1MA HHVZ7OAjqDLVh5NWU5V4jB1P+owBMTvQYT/5K4jeSJ6WMmQFFAIqXUH3cixqP+eIwZD2 vXd8ZvxVdialGmTJ9byQax5ELUm5Ogec4bQ3R7lWZ2LzpolJmUN3lMiNUBVg/6qiFlPZ 6EaDlkyO+xPgmVuUFpAfHNfp4loqb4saYVuQjfbaz4FyKa+Oqo9JrrmuOE1Rug0rx6l5 w2XkibXPJ6FFmgfFQPzLnpBQmsR40HUMlD3KxgBaIgAKGJVhqqNAiJNb7YlC+5e09c5e yoDA== X-Gm-Message-State: AOAM530ff8icGLMHMUUF7IcW7Yax9SRw9Eg1zOWNlqgv8Jr1PuBZFDs4 IAodGs0AgE8alxOoEEnFXkk3OocDENISGuDKkCcYgA== X-Google-Smtp-Source: ABdhPJyY5iBbncGSNeuN2E9vNBsMMt4g0qABGf83cqeejP9fYxXQvlFAsZV4kqoi6HIJ0aXz6AHkP0LkyCe9oKXhBFI= X-Received: by 2002:a63:1f53:: with SMTP id q19mr24237607pgm.286.1605139541442; Wed, 11 Nov 2020 16:05:41 -0800 (PST) MIME-Version: 1.0 References: <85aba371903b749412fac34e44e54c89e5ddae30.1605046192.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Thu, 12 Nov 2020 01:05:30 +0100 Message-ID: Subject: Re: [PATCH v9 10/44] kasan: define KASAN_GRANULE_PAGE To: Marco Elver Cc: Alexander Potapenko , Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 11, 2020 at 8:05 PM Marco Elver wrote: > > On Wed, 11 Nov 2020 at 19:48, Andrey Konovalov wrote: > > > > On Wed, Nov 11, 2020 at 3:13 PM Alexander Potapenko wrote: > > > > > > On Tue, Nov 10, 2020 at 11:11 PM Andrey Konovalov wrote: > > > > > > > > Define KASAN_GRANULE_PAGE as (KASAN_GRANULE_SIZE << PAGE_SHIFT), which is > > > > the same as (KASAN_GRANULE_SIZE * PAGE_SIZE), and use it across KASAN code > > > > to simplify it. > > > > > > What's the physical sense behind KASAN_GRANULE_PAGE? Is it something > > > more than just a product of two constants? > > > > No, just a product. > > > > > The name suggests it might be something page-sized, but in reality it is not. > > > > What name would you prefer? > > Is it actually KASAN_GRANULES_PER_SHADOW_PAGE ? AFAIK we're trying > to calculate the granules that we can fit into a page of shadow > memory. Not exactly, it's the amount of memory, not the number of granules. Will name it KASAN_MEMORY_PER_SHADOW_PAGE in v10.