From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AD7AECE589 for ; Tue, 1 Oct 2019 11:54:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5049B20640 for ; Tue, 1 Oct 2019 11:54:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FsAwZFtT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5049B20640 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DC1578E0005; Tue, 1 Oct 2019 07:54:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D705C8E0001; Tue, 1 Oct 2019 07:54:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C39598E0005; Tue, 1 Oct 2019 07:54:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id A26238E0001 for ; Tue, 1 Oct 2019 07:54:02 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 22200824CA3B for ; Tue, 1 Oct 2019 11:54:02 +0000 (UTC) X-FDA: 75995057124.10.love55_7a7ae0f20d80b X-HE-Tag: love55_7a7ae0f20d80b X-Filterd-Recvd-Size: 4386 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Oct 2019 11:54:01 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id u12so5338714pls.12 for ; Tue, 01 Oct 2019 04:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=64JhZwkDAvaFL8oefy3Dlv2PxK4l6sjIBqb8vtnMKK4=; b=FsAwZFtTbM4w3tHIi2kjemmZZb9MFNARVFQbkmLTTM+KBtRRefSY9TD7PMsLPnR+MA K2dvDteLSzcL5PMfivtOgnn0CpAVfivvC0Z518L1eFH2D5tzCavGG2Dy6qaO00N+fWi2 B3hn97e4qNV0xeJRMQ+VvhAK+WlnXvAgsqf0pXKOlrBmnNIUj7tsu7sedcbglekADziM EKrF0usaaJgyIvFYGObLpAIwI9+Fw3ALKztiM2CYmyg2CiKYLnDs5bqr58PrmyFeELBJ trkfycHg1STppUj82ww83kYr6QvHQRrjHWQMPZobSwLO4lOq3aQJOVYgCVUvRaXqpC2e YnYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=64JhZwkDAvaFL8oefy3Dlv2PxK4l6sjIBqb8vtnMKK4=; b=NLBXW+EBXeXUZPGcXwkUGEG9FciLA7Upowx9cwNkqqoUv11IFrqpEH9Wdvo57SugIy rat0dWZj7CAxLhgPs5ssxN+pcnTEq1LPodqNsCmnZDvaHgFQ7/+LryN70zp91IMhYTyH hCWBtlvZJy3Zs/XTiIV0YergZMmSckjnkh2Jc/evxQU+KOINMfGnuKZzctJHp778bha0 mvMOhfScyyE4D+qAju0dyvWJ9uKU219P9cw4mw9MgphtPDqOcLPub6pLz1Qps1pgqhqr eLjVOp4TXCWYL+QfiKjS6I+hO8DOxwKE/lAls/zGKAzgXapLkUQ9F0i62XIxpxWHSjjx kxIQ== X-Gm-Message-State: APjAAAXE92Lwx2luu0HdWAT6zO5WD1ZvGMr1NePEa+td7zyPnH//MhUc NMISGzRUnvQfJUhlbJ4vbNHeVFgVAzmZ9WD6g48t7A== X-Google-Smtp-Source: APXvYqyJ3Lc7ZQwJT/ACH4RnfsrK1gLwn2azs4odvDQ8uIFF8FKln1z8z11y/394MkKXlOL3lk6SBWElOW9Xv/VNjWU= X-Received: by 2002:a17:902:9a95:: with SMTP id w21mr25171552plp.336.1569930840195; Tue, 01 Oct 2019 04:54:00 -0700 (PDT) MIME-Version: 1.0 References: <29dd42d5-52e3-e2a2-679f-f0e8648f2b40@infradead.org> In-Reply-To: <29dd42d5-52e3-e2a2-679f-f0e8648f2b40@infradead.org> From: Andrey Konovalov Date: Tue, 1 Oct 2019 13:53:48 +0200 Message-ID: Subject: Re: [PATCH mmotm] sparc64: pgtable_64.h: fix mismatched parens To: Randy Dunlap Cc: LKML , Linux MM , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 1, 2019 at 2:23 AM Randy Dunlap wrote: > > From: Randy Dunlap > > Fix lib-untag-user-pointers-in-strn_user.patch unmatched left paren. > Fixes many of these build errors: > > ../mm/gup.c: In function '__get_user_pages': > ../mm/gup.c:791:30: error: expected ')' before ';' token > start = untagged_addr(start); > ^ > In file included from ../arch/sparc/include/asm/pgtable.h:5, > from ../include/linux/mm.h:99, > from ../mm/gup.c:7: > ../arch/sparc/include/asm/pgtable_64.h:1102:2: note: to match this '(' > ((__typeof__(addr))(__untagged_addr((unsigned long)(addr))) > ^ > ../mm/gup.c:791:10: note: in expansion of macro 'untagged_addr' > start = untagged_addr(start); > ^~~~~~~~~~~~~ > ../mm/gup.c:892:21: error: expected ';' before '}' token > > Signed-off-by: Randy Dunlap > Cc: Andrey Konovalov > --- > > Is this already fixed??? Hi Randy, Yes, this has been fixed by a22fea94992a2bc5328005e62f368413ede49c14. Thanks! > > > arch/sparc/include/asm/pgtable_64.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- mmotm-2019-0925-1810.orig/arch/sparc/include/asm/pgtable_64.h > +++ mmotm-2019-0925-1810/arch/sparc/include/asm/pgtable_64.h > @@ -1099,7 +1099,7 @@ static inline unsigned long __untagged_a > return start; > } > #define untagged_addr(addr) \ > - ((__typeof__(addr))(__untagged_addr((unsigned long)(addr))) > + ((__typeof__(addr))(__untagged_addr((unsigned long)(addr)))) > > static inline bool pte_access_permitted(pte_t pte, bool write) > { >