From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 143D8C4727F for ; Thu, 1 Oct 2020 21:54:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 77A3F206C9 for ; Thu, 1 Oct 2020 21:54:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nqXbUTBc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77A3F206C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B134D6B005C; Thu, 1 Oct 2020 17:54:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC3726B0062; Thu, 1 Oct 2020 17:54:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 963B46B0068; Thu, 1 Oct 2020 17:54:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id 6A0376B005C for ; Thu, 1 Oct 2020 17:54:40 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E3346181AE871 for ; Thu, 1 Oct 2020 21:54:39 +0000 (UTC) X-FDA: 77324711478.20.laugh41_3203a422719e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id BE928180C07A3 for ; Thu, 1 Oct 2020 21:54:39 +0000 (UTC) X-HE-Tag: laugh41_3203a422719e X-Filterd-Recvd-Size: 5638 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Thu, 1 Oct 2020 21:54:39 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id g29so88024pgl.2 for ; Thu, 01 Oct 2020 14:54:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3q47gBSVfL/j+OZHN/FfdXXTWivJeUwTp3edwFJcf2k=; b=nqXbUTBcQYRd6tU6SJChhpBw778f3yoV9bUIL7dzDLgBraFkF23uG1KqdFIcnXi1hs biLuo+UmwVDWhGZv+jXnbqiJjK4oQvgqcGrFQ3nsmvBlG2I6s3O7dlTCP1RLYV9wtZfi OJMAjm1b9sHmdlDEMySw+Nl2+rdgbpXcTD2Xen3sSPZnJEbmOWjXkW0iEw1VK9gGqwKu bqkykOKziJLGGlx/EAxJtuog4URgaM5/vkqAZhtWO85y7Y8MTBxoe8SDHv2al9GZgatF Jw7j4YWqGW+ZhFQXN2r3sL6dxX6Mny8rLvwj86yshvaSvMYL6OpHH3XMBA0sWk2wqPk4 kkLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3q47gBSVfL/j+OZHN/FfdXXTWivJeUwTp3edwFJcf2k=; b=Mw4/ZQ+ZPkZSzrOdRcvhyIFLL1s4zQDi3iGhdaqMlDptloRPzsQE/IGAPX6LnDeBCU ytljcp6dFVIACacEJFBIfmlcYHaFNtm3fEvf6HptZDfI9b77RfseHNH0kk9OuD9BMk7l FkNbm/78pI4eeqMa+bn7g0tvAzZLwkNFTG4RUyWKBQgbNNU52h9CaC9vcXGa0zX0LcPx gF/dUtDtDqREu/ITPgtz1ggGTt4GByoG5azfvmRcw8BQ2ZSiUcxAtTb3oNsPAa/NB5O7 V/5d+NOqSivxfWrLWJDwam9790mdeZtnTF3zivpy8eFdY8fqifIiyy0S8yty6EJcvwQW 0JGA== X-Gm-Message-State: AOAM532Ec6oqBi4PsoPVfqfzuOn/hXotHPUU1q1qSjlDC2DDDG2fPBoi GJr9OFfyZy5dXMj6GR586ncFUjhDSaDClNEqqtVrJQ== X-Google-Smtp-Source: ABdhPJwe0nnV0aaMaZSbzhcZHDNLv6ns+vWOJVoH00VYC+JUxWYvdwwgqCoZz9JRt5kZ+WOO8cRFkCCmHD3tnOlCeAg= X-Received: by 2002:a62:ee10:0:b029:142:2501:3972 with SMTP id e16-20020a62ee100000b029014225013972mr4653258pfi.55.1601589278265; Thu, 01 Oct 2020 14:54:38 -0700 (PDT) MIME-Version: 1.0 References: <728981bdedbca9dc1e4cca853699b6a6e8f244e0.1600987622.git.andreyknvl@google.com> <20201001173945.GI4162920@elver.google.com> In-Reply-To: <20201001173945.GI4162920@elver.google.com> From: Andrey Konovalov Date: Thu, 1 Oct 2020 23:54:27 +0200 Message-ID: Subject: Re: [PATCH v3 11/39] kasan: don't duplicate config dependencies To: Marco Elver Cc: Dmitry Vyukov , Vincenzo Frascino , Catalin Marinas , kasan-dev , Andrey Ryabinin , Alexander Potapenko , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 1, 2020 at 7:39 PM wrote: > > On Fri, Sep 25, 2020 at 12:50AM +0200, Andrey Konovalov wrote: > > Both KASAN_GENERIC and KASAN_SW_TAGS have common dependencies, move > > those to KASAN. > > > > Signed-off-by: Andrey Konovalov > > Signed-off-by: Vincenzo Frascino > > Reviewed-by: Marco Elver > > But see comment below: > > > --- > > Change-Id: I77e475802e8f1750b9154fe4a6e6da4456054fcd > > --- > > lib/Kconfig.kasan | 11 +++-------- > > 1 file changed, 3 insertions(+), 8 deletions(-) > > > > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > > index e1d55331b618..b4cf6c519d71 100644 > > --- a/lib/Kconfig.kasan > > +++ b/lib/Kconfig.kasan > > @@ -24,6 +24,9 @@ menuconfig KASAN > > (HAVE_ARCH_KASAN_SW_TAGS && CC_HAS_KASAN_SW_TAGS) > > depends on (SLUB && SYSFS) || (SLAB && !DEBUG_SLAB) > > depends on CC_HAS_WORKING_NOSANITIZE_ADDRESS > > + select SLUB_DEBUG if SLUB > > + select CONSTRUCTORS > > + select STACKDEPOT > > In the later patch your move 'select SLUB_DEBUG' back to where they were > here it seems. The end result is the same, so I leave it to you if you > want to change it. Will fix in v4, thank you! > > > help > > Enables KASAN (KernelAddressSANitizer) - runtime memory debugger, > > designed to find out-of-bounds accesses and use-after-free bugs. > > @@ -46,10 +49,6 @@ choice > > config KASAN_GENERIC > > bool "Generic mode" > > depends on HAVE_ARCH_KASAN && CC_HAS_KASAN_GENERIC > > - depends on (SLUB && SYSFS) || (SLAB && !DEBUG_SLAB) > > - select SLUB_DEBUG if SLUB > > - select CONSTRUCTORS > > - select STACKDEPOT > > help > > Enables generic KASAN mode. > > > > @@ -70,10 +69,6 @@ config KASAN_GENERIC > > config KASAN_SW_TAGS > > bool "Software tag-based mode" > > depends on HAVE_ARCH_KASAN_SW_TAGS && CC_HAS_KASAN_SW_TAGS > > - depends on (SLUB && SYSFS) || (SLAB && !DEBUG_SLAB) > > - select SLUB_DEBUG if SLUB > > - select CONSTRUCTORS > > - select STACKDEPOT > > help > > Enables software tag-based KASAN mode. > > > > -- > > 2.28.0.681.g6f77f65b4e-goog > >