From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5992C4742C for ; Wed, 11 Nov 2020 18:50:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1CFC32068D for ; Wed, 11 Nov 2020 18:50:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Kp0u3B28" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CFC32068D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 78BFC6B0036; Wed, 11 Nov 2020 13:50:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F0246B005D; Wed, 11 Nov 2020 13:50:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B9356B0068; Wed, 11 Nov 2020 13:50:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154]) by kanga.kvack.org (Postfix) with ESMTP id 2EF886B0036 for ; Wed, 11 Nov 2020 13:50:22 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CB7C0180AD801 for ; Wed, 11 Nov 2020 18:50:21 +0000 (UTC) X-FDA: 77473027842.24.trip71_5b15ce327300 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id AC15E1A4A0 for ; Wed, 11 Nov 2020 18:50:21 +0000 (UTC) X-HE-Tag: trip71_5b15ce327300 X-Filterd-Recvd-Size: 6734 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 18:50:21 +0000 (UTC) Received: by mail-pj1-f65.google.com with SMTP id ie6so1145995pjb.0 for ; Wed, 11 Nov 2020 10:50:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VJh1hc9aoLNnAEUPgEfQmYydHZQ7GWODzgkyZKHT9uI=; b=Kp0u3B28Re8rUmbgk6Wbi+mcHr4eQNPYwd4jZAOskQYR4o5MaGeDoWqvdO4BVYbcFn Hw2Q6K8HVjJlGdDYkeRAutbNUMlg6rv+2l97ht2b62K6cCQ6AVumEqxy+mzLAaNjSAoG absNio8m32HzZApXXtAcXDLkXbhcZlenRLtcF9iFlh5gcmcYU1DVXZQqZ+6qsNRlR0OP /99JefrK7tG3NNeTd10NqBwV4CIZTUmrJYXsgpmdpn3n4C1Jpngfv0Y/mPX9oKuH5aSA RBuTgPHwKl6taj3zlgUL6Ujw1PHPTQ0YStD6g0ZI8zVElJAn5GmfzzsN9DGi6AlvSrJs aIcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VJh1hc9aoLNnAEUPgEfQmYydHZQ7GWODzgkyZKHT9uI=; b=m0uUmpSoGx+I09DlI62Y8Sn5PzDarfGpGaiu5QQwEi3aVJJyDzo5lWbX7QALDn6Qj0 vqxmmcFFu49q8ShpUJ8lNEJFsDYwmgUOw4Rjhnb/q+xqbMKtCxw10SELmBziqH1p21xZ 8b1t6qlPWNg3vx4eGvo0qgcmx3OmtLB0l9ffJPekMqTLV53L2PIBC1WUCiSmt0OmlxZk BANgsvv6Mzpara17pNGZDgb7AM+KWbQjrZgN4vIzji/5nVLGgdgILIJrgCS2Ma21ir4i lwLSaXG1ct55QW75ooQlxm1kwVApsIxXsYyby09s6okKJH+uxUOrB/yST/p/aQxbP3hB e/lw== X-Gm-Message-State: AOAM5301PXSSW8pm0mo6p5UnbUGcJwXrfzUYPiwAtlwz0HRUI/b/h9HP keAmE0SGPcyn8RdHrzJ+S03vp6r72MgPsHGrJ9uxiA== X-Google-Smtp-Source: ABdhPJw6s07+zs7B+6RC0cvaGmwVCAUyrlExtzm9EAiQNBIKwlEQmALGDwxaVv43WCL3AuSGWQLFpPDv3U5Mfrn1Yjc= X-Received: by 2002:a17:90a:4215:: with SMTP id o21mr5064897pjg.166.1605120620141; Wed, 11 Nov 2020 10:50:20 -0800 (PST) MIME-Version: 1.0 References: <619cb0edad35d946c4796976c25bddb5b3eb0c56.1605046192.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Wed, 11 Nov 2020 19:50:09 +0100 Message-ID: Subject: Re: [PATCH v9 17/44] kasan, arm64: move initialization message To: Alexander Potapenko Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 11, 2020 at 4:04 PM Alexander Potapenko wrote: > > On Tue, Nov 10, 2020 at 11:11 PM Andrey Konovalov wrote: > > > > Software tag-based KASAN mode is fully initialized with kasan_init_tags(), > > while the generic mode only requires kasan_init(). Move the > > initialization message for tag-based mode into kasan_init_tags(). > > > > Also fix pr_fmt() usage for KASAN code: generic.c doesn't need it as it > > doesn't use any printing functions; tag-based mode should use "kasan:" > > instead of KBUILD_MODNAME (which stands for file name). > > > > Signed-off-by: Andrey Konovalov > > Reviewed-by: Catalin Marinas > > --- > > Change-Id: Iddca9764b30ff0fab1922f26ca9d4f39b6f22673 > > --- > > arch/arm64/include/asm/kasan.h | 9 +++------ > > arch/arm64/mm/kasan_init.c | 13 +++++-------- > > mm/kasan/generic.c | 2 -- > > mm/kasan/sw_tags.c | 4 +++- > > 4 files changed, 11 insertions(+), 17 deletions(-) > > > > diff --git a/arch/arm64/include/asm/kasan.h b/arch/arm64/include/asm/kasan.h > > index f7ea70d02cab..0aaf9044cd6a 100644 > > --- a/arch/arm64/include/asm/kasan.h > > +++ b/arch/arm64/include/asm/kasan.h > > @@ -12,14 +12,10 @@ > > #define arch_kasan_reset_tag(addr) __tag_reset(addr) > > #define arch_kasan_get_tag(addr) __tag_get(addr) > > > > -#ifdef CONFIG_KASAN > > -void kasan_init(void); > > -#else > > -static inline void kasan_init(void) { } > > -#endif > > - > > #if defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS) > > > > +void kasan_init(void); > > + > > /* > > * KASAN_SHADOW_START: beginning of the kernel virtual addresses. > > * KASAN_SHADOW_END: KASAN_SHADOW_START + 1/N of kernel virtual addresses, > > @@ -43,6 +39,7 @@ void kasan_copy_shadow(pgd_t *pgdir); > > asmlinkage void kasan_early_init(void); > > > > #else > > +static inline void kasan_init(void) { } > > static inline void kasan_copy_shadow(pgd_t *pgdir) { } > > #endif > > > > diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c > > index 5172799f831f..e35ce04beed1 100644 > > --- a/arch/arm64/mm/kasan_init.c > > +++ b/arch/arm64/mm/kasan_init.c > > @@ -278,17 +278,14 @@ static void __init kasan_init_depth(void) > > init_task.kasan_depth = 0; > > } > > > > -#else /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS) */ > > - > > -static inline void __init kasan_init_shadow(void) { } > > - > > -static inline void __init kasan_init_depth(void) { } > > - > > -#endif /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ > > - > > void __init kasan_init(void) > > { > > kasan_init_shadow(); > > kasan_init_depth(); > > +#if defined(CONFIG_KASAN_GENERIC) > > + /* CONFIG_KASAN_SW_TAGS also requires kasan_init_tags(). */ > > pr_info("KernelAddressSanitizer initialized\n"); > > +#endif > > } > > Cannot we have a single kasan_init() function that will call > tool-specific initialization functions and print the message at the > end? Unfortunately no. For different modes we need different functions that are called in different places in the kernel. E.g. for generic KASAN we only need kasan_init() to setup shadow pages; for SW tags we also need kasan_init_sw_tags() which initializes per-cpu state and finilizes initialization process.