From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by kanga.kvack.org (Postfix) with ESMTP id A4D3A6B051F for ; Wed, 7 Nov 2018 10:54:08 -0500 (EST) Received: by mail-io1-f70.google.com with SMTP id c17-v6so19732674ioi.15 for ; Wed, 07 Nov 2018 07:54:08 -0800 (PST) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id c7-v6sor450430iog.57.2018.11.07.07.54.07 for (Google Transport Security); Wed, 07 Nov 2018 07:54:07 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20181107153456.GE2623@brain-police> References: <20181107145922.GD2623@brain-police> <20181107153456.GE2623@brain-police> From: Andrey Konovalov Date: Wed, 7 Nov 2018 16:54:05 +0100 Message-ID: Subject: Re: [PATCH v10 00/22] kasan: add software tag-based mode for arm64 Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Will Deacon , Catalin Marinas Cc: Andrew Morton , Kostya Serebryany , Evgeniy Stepanov , Lee Smith , Ramana Radhakrishnan , Jacob Bramley , Ruben Ayrapetyan , Jann Horn , Mark Brand , Chintan Pandya , Vishwath Mohan , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Christoph Lameter , Mark Rutland , Nick Desaulniers , Marc Zyngier , Dave Martin , Ard Biesheuvel , "Eric W . Biederman" , Ingo Molnar , Paul Lawrence , Geert Uytterhoeven , Arnd Bergmann , "Kirill A . Shutemov" , Greg Kroah-Hartman , Kate Stewart , Mike Rapoport , kasan-dev@googlegroups.com, "open list:DOCUMENTATION" , LKML , Linux ARM , linux-sparse@vger.kernel.org, Linux Memory Management List , Linux Kbuild mailing list On Wed, Nov 7, 2018 at 4:34 PM, Will Deacon wrote: > On Wed, Nov 07, 2018 at 04:11:35PM +0100, Andrey Konovalov wrote: >> On Wed, Nov 7, 2018 at 3:59 PM, Will Deacon wrote: >> > On Wed, Nov 07, 2018 at 03:56:03PM +0100, Andrey Konovalov wrote: >> >> On Tue, Nov 6, 2018 at 6:30 PM, Andrey Konovalov wrote: >> >> > This patchset adds a new software tag-based mode to KASAN [1]. >> >> > (Initially this mode was called KHWASAN, but it got renamed, >> >> > see the naming rationale at the end of this section). >> >> >> >> [...] >> >> >> >> > Reviewed-by: Andrey Ryabinin >> >> > Reviewed-by: Dmitry Vyukov >> >> > Signed-off-by: Andrey Konovalov >> >> >> >> Hi Andrew, >> >> >> >> This patchset has now been reviewed-by KASAN maintainers. Could you >> >> take a look and consider taking this into the -mm tree? >> > >> > I would much prefer to take the arm64 parts (which still need to be reviewed >> > by Catalin afaict) via the arm64 tree, so please can you split those out >> > separately? >> >> Which parts do you mean exactly, which patches? I don't think it makes >> sense to split this patchset, as one part won't function without the >> other. > > I would like the patches that touch code under arch/arm64/ to be reviewed by > somebody from the arm64 community. Since the core parts have already been > reviewed, I was suggesting that you could split them out so that they are > not blocked by the architecture code. Is it not possible to preserve the > existing KASAN behaviour for arm64 with the core parts merged? I figured it > must be, since you're not touching any other architectures here and they > assumedly continue to function correctly. > > However, if you'd rather keep everything together, please can we give it a > couple of weeks so we can at least get the architecture bits reviewed? Most > people are out at LPC next week (and I'm at another conference this week). > > Will