From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2240DC28CBC for ; Mon, 4 May 2020 03:09:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC9C020643 for ; Mon, 4 May 2020 03:09:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VY0BX8QJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC9C020643 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7D0E28E0006; Sun, 3 May 2020 23:09:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7817E8E0001; Sun, 3 May 2020 23:09:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 697188E0006; Sun, 3 May 2020 23:09:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0160.hostedemail.com [216.40.44.160]) by kanga.kvack.org (Postfix) with ESMTP id 508378E0001 for ; Sun, 3 May 2020 23:09:23 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0D1BB12783 for ; Mon, 4 May 2020 03:09:23 +0000 (UTC) X-FDA: 76777555806.27.table31_6f01cf643633d X-HE-Tag: table31_6f01cf643633d X-Filterd-Recvd-Size: 4650 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Mon, 4 May 2020 03:09:22 +0000 (UTC) Received: by mail-qv1-f51.google.com with SMTP id di6so7674211qvb.10 for ; Sun, 03 May 2020 20:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=IjhzQ3oHa9nNeIuiLupnxo7YU2u+0fWxdlUhWitx3YU=; b=VY0BX8QJL/Ls8mKkxdOnZWoc/16ZP/mvIQfcoHIcj1h/K2Q2zQh4jUPwqUTBdL0/gf B/V3IiNsa7a7TQFt2egmpLSRf7jrnXzSaQhRP4vAamVcc+66FrZSPEWYVrbYuzcEC126 damw8M1AurzoePG5McVEwdfx+HHJ78R3X9+vqJUwrzBP8PW0VmM2UDFvA0LhACCwFWa5 ZENGXzZ+BPVX7AgJElbGuJdcFA3A8KksJ9U8cDmfCbVNyEBLTxim+YNdRHfgkjJFHz+Q rCyOz/nrabbolc5/vqm39RXSn6Yy3h00G+9J0rJ0pter4I7xyDYZ0RNdDJM8oMXAF9Bg Wa0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=IjhzQ3oHa9nNeIuiLupnxo7YU2u+0fWxdlUhWitx3YU=; b=ZqtP4aNJ29V4blPkyUbbhMR0QHic/DBpX/EbFjUhiguTcA4/rgsEqHP+BTlr6J5CpV wxdPLUMCxNXv56IMuArBFzFfyJAz0mQngmtj/XeLHqEKrPijFErPXHiPQ0L1ZdKpK8BN pB8Rjp3mfU5pln6mpPjgqBT975TAkNk21iHl06hFY4fbPXCGtoplOLrxNKe7p0IJGxyw c/6Gfj1t0aGqTeBBQRhMK7BkYbR/cGpn/9+774OUtH0hGouDBJkZs3HIZgIELhbTGkC5 sVnuG2VIjzqwV2ZbnEDvMG8/elaFFGJpf9i4DssXGxDMNVsFhmVvLBkautFr8K6GuROD 1/eg== X-Gm-Message-State: AGi0PuaqcJxv41ovENScDVp+H6p3cKuF/d/h+gRzsZ771jK9c65cWJ6h G5mlfwoaTDvJOm5iI/be8SL96tqfILIuYeYdPNQ= X-Google-Smtp-Source: APiQypJZnb1KhKURAZgc+1wjYSttxzA52ie++9Xhfq/pqC2ENO5/rrIWom4CorrSsaCSFMI4ZXJjRxkFSBOB8lhbrz8= X-Received: by 2002:a05:6214:7e1:: with SMTP id bp1mr14347599qvb.208.1588561762103; Sun, 03 May 2020 20:09:22 -0700 (PDT) MIME-Version: 1.0 References: <1588130803-20527-1-git-send-email-iamjoonsoo.kim@lge.com> <20200429184711.9d603da097fdea80f574f1f1@linux-foundation.org> <20200501105545.GA29460@infradead.org> <20200501123429.GA26861@infradead.org> In-Reply-To: <20200501123429.GA26861@infradead.org> From: Joonsoo Kim Date: Mon, 4 May 2020 12:09:11 +0900 Message-ID: Subject: Re: [PATCH v2 00/10] change the implementation of the PageHighMem() To: Christoph Hellwig Cc: Andrew Morton , Linux Memory Management List , LKML , Vlastimil Babka , Laura Abbott , "Aneesh Kumar K . V" , Mel Gorman , Michal Hocko , Johannes Weiner , Roman Gushchin , Minchan Kim , Rik van Riel , Christian Koenig , Huang Rui , Eric Biederman , "Rafael J . Wysocki" , Pavel Machek , kernel-team@lge.com, Joonsoo Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 5=EC=9B=94 1=EC=9D=BC (=EA=B8=88) =EC=98=A4=ED=9B=84 9:34, Ch= ristoph Hellwig =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On Fri, May 01, 2020 at 09:15:30PM +0900, Joonsoo Kim wrote: > > I think that PageHighMemZone() is long and complicated enough to have > > a macro. > > It is. But then again it also shouldn't really be used by anything > but MM internals. I'm not sure that we can make it MM internal but I will try. > > > > PageHighMemZone(page) =3D is_highmem_idx(zone_idx(page_zone(page)) > > > > Instead of open-code, how about changing the style of macro like as > > page_from_highmem()? What PageHighMemZone() represent is derivated > > attribute from the page so PageXXX() style may not be appropriate. > > Maybe page_is_highmem_zone() with a big kerneldoc comment explaining > the use case? Bonus points of killing enough users that it can be > in mm/internal.h. I will try to kill page_is_highmem_zone() as much as possible in next versi= on. Thanks.