From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF81CC28CBC for ; Mon, 4 May 2020 03:01:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 64A0920721 for ; Mon, 4 May 2020 03:01:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qNzLwVTA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64A0920721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2F4928E0005; Sun, 3 May 2020 23:01:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27DB58E0001; Sun, 3 May 2020 23:01:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11EDB8E0005; Sun, 3 May 2020 23:01:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0086.hostedemail.com [216.40.44.86]) by kanga.kvack.org (Postfix) with ESMTP id EAD3F8E0001 for ; Sun, 3 May 2020 23:01:44 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9DD99180AD83B for ; Mon, 4 May 2020 03:01:44 +0000 (UTC) X-FDA: 76777536528.15.shake65_2c45ac09ff52e X-HE-Tag: shake65_2c45ac09ff52e X-Filterd-Recvd-Size: 4385 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Mon, 4 May 2020 03:01:44 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id f13so3868936qkh.2 for ; Sun, 03 May 2020 20:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MXVjQh5qk+wFh49Mgj14doNyR4R5wftox/4Vl8s1gFw=; b=qNzLwVTAmfJuM0LtKBfIRAMIoNI7egURDU3XJZ7SKia7RZNNJVOrblZxkhkVQeHpId eSX9gk5nnFFtLZiR2mvXXJKUwpVhb1ECDLLNY39O50nvbLTC3Dpby7aUPzTBxGAP9+k+ 5H5v7sJpaQB19u/DquGNBlecLyKbrimNOpwufmI/RbsojGS/+Hxlg/qvy1nsqxCVxT3U DcUspYfwK9lnYNrol2xBILPzRsYktcTfOjTmxtmuf7IuudT2CRI/85HCSQMo1hQrlIpi xPDzl11tciarFfVZn36XKcXKCQUPFI8TgHA8C5uHz91mJVzD92VqRA/HzufnMYjvTNR+ BVFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MXVjQh5qk+wFh49Mgj14doNyR4R5wftox/4Vl8s1gFw=; b=KUSrHw31v1OBMbPDoscnZvByU1y9c9RbIKqYKrHW+z/iBqEC6G/GoAKfQDgMRmQQMy BVraGOS1hu6AOwUI0zHWEuGkksXgKzILV736E9q15aX8rgnypsNDMIr8vcBUbyHrWbT3 V7QHE3rNzQ/Hb3/0uzMww2/XqGoOPws+/SYI+Jb3sXQI8f9vzeUw8od6qY+b+gjTAbZU SO4Pj5VIYkHlYQJBOWJv1EV2XX6wJUibkOXdKv+vkL+kemgs1/DIWAx0bFZqeYs0vMhA BxVm5Xndw0AQbUL6C/rpNqoinhhQOSsM2ONmqOesdsKsq9yAR2e2Ots8zg1w/l6XTEHb sAvw== X-Gm-Message-State: AGi0PuaUcV+GpD5IfJjxV1k4e4PsyaKxNxps75//hIqQ8PjbF7G5N7m2 ZYuV99W8OKY47ZWqw6u5pagtov67m6l/lCa/mbo= X-Google-Smtp-Source: APiQypLLCaX7+49SOXDRdiJBsEahZHc+Et54qpBgZyXkrMGUk3MglIghTnEgh2XZryXonsLTw6V6mTK8BnNyxsneNtM= X-Received: by 2002:a05:620a:15c1:: with SMTP id o1mr13727225qkm.187.1588561303457; Sun, 03 May 2020 20:01:43 -0700 (PDT) MIME-Version: 1.0 References: <1588130803-20527-1-git-send-email-iamjoonsoo.kim@lge.com> <1588130803-20527-5-git-send-email-iamjoonsoo.kim@lge.com> <20200501122245.GA21897@infradead.org> In-Reply-To: <20200501122245.GA21897@infradead.org> From: Joonsoo Kim Date: Mon, 4 May 2020 12:01:32 +0900 Message-ID: Subject: Re: [PATCH v2 04/10] power: separate PageHighMem() and PageHighMemZone() use case To: Christoph Hellwig Cc: Andrew Morton , Linux Memory Management List , LKML , Vlastimil Babka , Laura Abbott , "Aneesh Kumar K . V" , Mel Gorman , Michal Hocko , Johannes Weiner , Roman Gushchin , Minchan Kim , Rik van Riel , Christian Koenig , Huang Rui , Eric Biederman , "Rafael J . Wysocki" , Pavel Machek , kernel-team@lge.com, Joonsoo Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 5=EC=9B=94 1=EC=9D=BC (=EA=B8=88) =EC=98=A4=ED=9B=84 9:22, Ch= ristoph Hellwig =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On Wed, Apr 29, 2020 at 12:26:37PM +0900, js1304@gmail.com wrote: > > index 6598001..be759a6 100644 > > --- a/kernel/power/snapshot.c > > +++ b/kernel/power/snapshot.c > > @@ -1227,7 +1227,7 @@ static struct page *saveable_highmem_page(struct = zone *zone, unsigned long pfn) > > if (!page || page_zone(page) !=3D zone) > > return NULL; > > > > - BUG_ON(!PageHighMem(page)); > > + BUG_ON(!PageHighMemZone(page)); > > The above check already checks for the highmem zone. So if we want > to keep the BUG_ON it needs stay PageHighMem to make sense. That being > said I'd rather remove it entirel=E1=BA=8F. Okay. > > - BUG_ON(PageHighMem(page)); > > + BUG_ON(PageHighMemZone(page)); > > Same here. Okay. Thanks.