From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C040C433E0 for ; Fri, 3 Jul 2020 00:51:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D26182073E for ; Fri, 3 Jul 2020 00:51:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bE5Ob0jK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D26182073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6B7E18D000F; Thu, 2 Jul 2020 20:51:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 642B38D0002; Thu, 2 Jul 2020 20:51:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5096A8D000F; Thu, 2 Jul 2020 20:51:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id 35CBC8D0002 for ; Thu, 2 Jul 2020 20:51:37 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B078A8248068 for ; Fri, 3 Jul 2020 00:51:36 +0000 (UTC) X-FDA: 76994936592.19.trip23_15086d726e8d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 80AF21ACEA2 for ; Fri, 3 Jul 2020 00:51:36 +0000 (UTC) X-HE-Tag: trip23_15086d726e8d X-Filterd-Recvd-Size: 4669 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Jul 2020 00:51:36 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id k18so27466996qke.4 for ; Thu, 02 Jul 2020 17:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=lLFGT/BBldZHf5sKMBUPCZSt+jbFoZ4KvTvg/Gf1JYs=; b=bE5Ob0jKSu7KhEBUFlQPcIMPq17doykc18l+PBJ2fg8blHy2jIHU9FclxiycIFZ/yt 3uXHNIgCpSv87fDrZn1NkYiKs9w9wDS3UKyNAh4Hjn6PLRO/vNBUn68E8XyfPu23yvTo GVIRzdVRuJ+yxNCukqgIeQhYkt9UamxipRNAdhtXl0taq3wJrsUPyecrB5a13llc5g0Q cBgCSsh9qJn65oczXnL69iIAxLSVHZCfndDa3BFkynHJDbpTdrUd/GUWBg8nPXmUtVIl tXj1M1fsNDsO/TwuoiL+vhjZb45cVOGvg/rbIdAmK65NDxcR0ty7BM7eTfZXOurL7gt2 jDJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=lLFGT/BBldZHf5sKMBUPCZSt+jbFoZ4KvTvg/Gf1JYs=; b=n3Eu5LOTEq03Ay3Kcq9ETMvjm7o9j92HAsLq24Tr/XhJosliKU1Rh2fxQM9Fk8nhyM P6BJjVU4orVUOvQl4BDePriRCAETgXDzaL1FlxhS25VV2Bjm1f6vDZGP2k3DXxvv1TO9 ldN4kxgMaAotqOQxcMWBu1FVlrnrQOPc+1yALyHsmIAzzT59+zTozP0YE6hi1x8uXu0y JjgvYtY5fSegyPRdA5DvyZn0j04pcJKPpwxgMHTzOoXYZnPi0u7RjtEOJtUs2LF7NyqG 5vfrI41oiBTpfZevM4mK03GQ7FS/B7JEg+/M2L7EL1o/vVHp6gV3cBuDaKEI8b43JDAk RwWA== X-Gm-Message-State: AOAM532rLuwS2RlWW+thuwCq/Wp6bKVV05UV/Dj85a6lj+UyS5llPdTU e6ne/mHs/UV6I5GNadZsh93hWBhaaM1tMgA38ro= X-Google-Smtp-Source: ABdhPJyXteh71iUaNTMFeenK1NVxNDjmbT9PEIq8o+TxNYMGvGmZqotkQy90xkaeKbrxbT8kuDjvYW8RoOqDXQrFQLA= X-Received: by 2002:a37:345:: with SMTP id 66mr31062128qkd.272.1593737495575; Thu, 02 Jul 2020 17:51:35 -0700 (PDT) MIME-Version: 1.0 References: <1592371583-30672-1-git-send-email-iamjoonsoo.kim@lge.com> <1592371583-30672-4-git-send-email-iamjoonsoo.kim@lge.com> <8d12fc23-8731-c5f5-e38c-f40bfecb067f@suse.cz> In-Reply-To: <8d12fc23-8731-c5f5-e38c-f40bfecb067f@suse.cz> From: Joonsoo Kim Date: Fri, 3 Jul 2020 09:51:24 +0900 Message-ID: Subject: Re: [PATCH v6 3/6] mm/workingset: extend the workingset detection for anon LRU To: Vlastimil Babka Cc: Andrew Morton , Linux Memory Management List , LKML , Johannes Weiner , Michal Hocko , Hugh Dickins , Minchan Kim , Mel Gorman , kernel-team@lge.com, Joonsoo Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 80AF21ACEA2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 7=EC=9B=94 2=EC=9D=BC (=EB=AA=A9) =EC=98=A4=EC=A0=84 6:25, Vl= astimil Babka =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On 6/17/20 7:26 AM, js1304@gmail.com wrote: > > From: Joonsoo Kim > > Hi, > > I would adjust the subject, as it sounds like the patch does the whole > workingset detection, not just preparation. > How about: > > mm/workingset: prepare the workingset infrastructure for anon LRU Looks good. I will use it. > > In the following patch, workingset detection will be applied to > > anonymous LRU. To prepare it, this patch adds some code to > > distinguish/handle the both LRUs. > > How about: > To prepare for this, this patch splits workingset event counters for refa= ult, > activate and restore into anon and file variants, as well as the refaults > counter in struct lruvec. Will do. > > v6: do not introduce a new nonresident_age for anon LRU since > > we need to use *unified* nonresident_age to implement workingset > > detection for anon LRU. > > Again, v6 update info shouldn't go to changelog. In this case I think it = doesn't > need mentioning at all, at least not in this patch. Okay. I agree that this should not be included in the changelog. I just wan= t to notice someone who checked previous patches about that there is an important change in this version. > > Acked-by: Johannes Weiner > > Signed-off-by: Joonsoo Kim > > Acked-by: Vlastimil Babka Thanks.