From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19514C433DF for ; Wed, 10 Jun 2020 05:13:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A64A72074B for ; Wed, 10 Jun 2020 05:13:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jTeg4CPQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A64A72074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EB8596B0002; Wed, 10 Jun 2020 01:13:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E687C6B0005; Wed, 10 Jun 2020 01:13:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7CF96B0006; Wed, 10 Jun 2020 01:13:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id BDA746B0002 for ; Wed, 10 Jun 2020 01:13:08 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 74ACB2461 for ; Wed, 10 Jun 2020 05:13:08 +0000 (UTC) X-FDA: 76912133256.07.car50_2e1491d26dc8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 455FB1803F645 for ; Wed, 10 Jun 2020 05:13:08 +0000 (UTC) X-HE-Tag: car50_2e1491d26dc8 X-Filterd-Recvd-Size: 4136 Received: from mail-qv1-f67.google.com (mail-qv1-f67.google.com [209.85.219.67]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Wed, 10 Jun 2020 05:13:07 +0000 (UTC) Received: by mail-qv1-f67.google.com with SMTP id e2so492436qvw.7 for ; Tue, 09 Jun 2020 22:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=hLUoxt0yiIKouGw7/buAE5rk8hMNj3nZR/xKb2B/ppc=; b=jTeg4CPQ7s4h9Y4F7BOUQVHOAxnY8YXCxjC/UrDVy9eN4he3dh5AFSdg94P/oYYfeP dbJFi3RpFReQOhjJRvudpIken1Rzr11mWy0Hn/9l+SjQHJ3zBZ33sebrkLiwBZTfYAil CzTtAtWwvGi7JAkvTpsjR5RjzUeXkjkwK39HrJH89c/k3Q/ueAbt3dJtC/E+G1iauWEd nZaozL0GeaIOC4RyLqP2HhPMt5UZ3lHVp3SmZd51aei04H02KVo+K/Lu+t9Z11DOmIGv 4k1xEqpoQ54wrkjzleSc9ykpZV88+iwlu567Urs0h7fdZRrGYbXygA6SDIJvqR8Xa02+ 3riA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=hLUoxt0yiIKouGw7/buAE5rk8hMNj3nZR/xKb2B/ppc=; b=Sjwo2bdDPZh1pWZvzzkY3cQDeL1qPCyTLIh82WU/SMdtFsb+JnK96VljnMPatSJLLz XkaUF1MHh1gN4D7fFlggoMTAjhhnw7UmhsE7EQ45Ysulv1bFi2jdgY93Icvkb1BAEpac Eh6xa9u3AZmBj0fTmgtzWfRqd6nO8d3qIo9WyvvjS4+AW6KKO+8pIeUDH9UdY+/xLbGH hmsUmx7ec6UCE0dCwSn759hY2IZ1hZcfxWxtnain6dEge+QXf3lQMpFyAOkNT99QPR0W AYA1QUp2E3ZMaATQwb8NxFZ7ozSBEx+D9oK01M/fZTz2avHfw/Ugpkxp78e8jhLLdzf4 zImg== X-Gm-Message-State: AOAM530C7LsoPJQghVt6KhGZE15pKGaFZdrYLjScovFXtEm4w8HoHti5 wJHai7DyYBxBmUieQqNX5SxKdwv4+Dk1cRcLtNM= X-Google-Smtp-Source: ABdhPJwueE8ZjMW1bpMs2FrKsGnGX0T6gYMQdn2T3ghIBONhrFPd8wQC8+4GwNFV8+CzuFgJdOp/zChta6l90nzMsVo= X-Received: by 2002:ad4:4368:: with SMTP id u8mr1472220qvt.227.1591765987012; Tue, 09 Jun 2020 22:13:07 -0700 (PDT) MIME-Version: 1.0 References: <1590561903-13186-1-git-send-email-iamjoonsoo.kim@lge.com> <1590561903-13186-8-git-send-email-iamjoonsoo.kim@lge.com> <20200609135431.GI22623@dhcp22.suse.cz> In-Reply-To: <20200609135431.GI22623@dhcp22.suse.cz> From: Joonsoo Kim Date: Wed, 10 Jun 2020 14:12:56 +0900 Message-ID: Subject: Re: [PATCH v2 07/12] mm/hugetlb: do not modify user provided gfp_mask To: Michal Hocko Cc: Andrew Morton , Linux Memory Management List , LKML , kernel-team@lge.com, Vlastimil Babka , Christoph Hellwig , Roman Gushchin , Mike Kravetz , Naoya Horiguchi , Joonsoo Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 455FB1803F645 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 6=EC=9B=94 9=EC=9D=BC (=ED=99=94) =EC=98=A4=ED=9B=84 10:54, M= ichal Hocko =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On Wed 27-05-20 15:44:58, Joonsoo Kim wrote: > > From: Joonsoo Kim > > > > It's not good practice to modify user input. Instead of using it to > > build correct gfp_mask for APIs, this patch introduces another gfp_mask > > field, __gfp_mask, for internal usage. > > Ugh, this is really ugly. It is just hugetlb to add __GFP_THISNODE as a > special case. This is an ugly hack but I do not think we want to work > around it by yet another hack. Moreover it seems that the __GFP_THISNODE > might be not needed anymore as pointed out in a reply to earlier patch. If you mean __GFP_THISNODE handling is ugly, as you pointed out, __GFP_THISNODE handling would be removed in the next version. If you mean introducing __gfp_mask is ugly, I will try to use a local varia= ble to keep modified gfp_mask rather than introducing a field in alloc_control. Thanks.