From: Shayan Pooya <shayan@liveve.org>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Michal Hocko <mhocko@kernel.org>,
koct9i@gmail.com, cgroups mailinglist <cgroups@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Oleg Nesterov <oleg@redhat.com>
Subject: Re: bug in memcg oom-killer results in a hung syscall in another process in the same cgroup
Date: Tue, 12 Jul 2016 15:57:50 -0700 [thread overview]
Message-ID: <CABAubTiVb8j8wEbcr16FAJnBxxS7QzghpPiJUcmV+=Ji=QgL=A@mail.gmail.com> (raw)
In-Reply-To: <57851224.2020902@yandex-team.ru>
> Yep. Bug still not fixed in upstream. In our kernel I've plugged it with
> this:
>
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -2808,8 +2808,9 @@ asmlinkage __visible void schedule_tail(struct
> task_struct *prev)
> balance_callback(rq);
> preempt_enable();
>
> - if (current->set_child_tid)
> - put_user(task_pid_vnr(current), current->set_child_tid);
> + if (current->set_child_tid &&
> + put_user(task_pid_vnr(current), current->set_child_tid))
> + force_sig(SIGSEGV, current);
> }
I just verified that with your patch there is no hung processes and I
see processes getting SIGSEGV as expected.
Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-07-12 22:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 23:49 bug in memcg oom-killer results in a hung syscall in another process in the same cgroup Shayan Pooya
2016-07-11 6:41 ` Michal Hocko
2016-07-11 17:40 ` Shayan Pooya
2016-07-11 18:33 ` Shayan Pooya
2016-07-12 7:19 ` Michal Hocko
2016-07-12 15:35 ` Shayan Pooya
2016-07-12 15:52 ` Konstantin Khlebnikov
2016-07-12 16:52 ` Oleg Nesterov
2016-07-12 22:57 ` Shayan Pooya [this message]
2016-07-14 13:22 ` Oleg Nesterov
2016-07-14 15:35 ` Shayan Pooya
2016-07-15 16:58 ` Shayan Pooya
2016-07-18 13:53 ` Oleg Nesterov
2016-07-13 8:08 ` Michal Hocko
2016-07-12 7:17 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABAubTiVb8j8wEbcr16FAJnBxxS7QzghpPiJUcmV+=Ji=QgL=A@mail.gmail.com' \
--to=shayan@liveve.org \
--cc=cgroups@vger.kernel.org \
--cc=khlebnikov@yandex-team.ru \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).