From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57680C433F5 for ; Thu, 5 May 2022 22:25:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92CC66B0071; Thu, 5 May 2022 18:25:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DB5E6B0073; Thu, 5 May 2022 18:25:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77C326B0074; Thu, 5 May 2022 18:25:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 674BB6B0071 for ; Thu, 5 May 2022 18:25:05 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 55E7F121A7E for ; Thu, 5 May 2022 22:25:04 +0000 (UTC) X-FDA: 79433120928.28.B6C56C6 Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) by imf21.hostedemail.com (Postfix) with ESMTP id 0ABB81C0097 for ; Thu, 5 May 2022 22:24:57 +0000 (UTC) Received: by mail-vs1-f44.google.com with SMTP id w124so5534339vsb.8 for ; Thu, 05 May 2022 15:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZTU61zGXmWFiJ96Frh3Jz27MZBWaPQRzBHvvGIgt+qo=; b=QZRowjxdyK3cW28/2AurA6uZk0guOaXUobYrDQoZCXWjvLQ/UqqjkspA5cq5vJ+lmO +3VbOyg8tu+9HHC1yNMS9fsG78gc0LDsxRKGKuxDPRLFtxvfi6CwNOqKaTu2udwfQwkv kR9lBSbM5k/K8gXDLSshvj7HkXa/BzC0t91oaM4geJKTL/jxwdmyKz/neojgz/Uo6xaw AOiiQ8YF0qfzCUU3y/7/icQ5tkmKsKoBTJn5cIyN71HYj/JFEs9X81LOQVThWl5uXnKb 3HnpMtxMR/nY9nHCaG3a0wOMj9PnPQKa4DCx8yQwXiLEURUhuk9+smXGAN7Fyv6N/LU0 tzvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZTU61zGXmWFiJ96Frh3Jz27MZBWaPQRzBHvvGIgt+qo=; b=6+1ph2riZMiWa3iXWk5KDiveKip/5U9NoSJi269lMCzQgY02vLI2hMoseKDnyAdzeb 0nt2ZwmiHJZDY0I6myAyxdISp98iUA9vIrmpnZ027K+MUxyThxrlpFci3Kt3fHPfr/Ib FOKO4aljnMMyOAVAON/KDx0cwJFtzVYp2c32BrWd9C6E8dqQE7/dyAMUATnpg/VhqERo A5rc87kLzUY/nlNQcy7ViXwo54TWA95G9Hk14a7hx5ta2jmOU7jN6fqMAzwUJrUkWAcu GrTJyVlStXkb7/4dQG6urEBDc7APFA93WBYr4oGPzo97aC5hXUIoFH54k6HWayncYaJS 7Pvg== X-Gm-Message-State: AOAM533WZNrAKJqduANqfDBRHocJ0dmj4cvF/3uMZ6h2vIavUvl3PZoR UVUChb9W7RW3xOlIOQ5mlP2vlbPdSAEALf0i8xbdcA== X-Google-Smtp-Source: ABdhPJzSTIXaeYs3GBff5g8EE46n+pwTbaDmDqbFn++uI37hHmsvQXFL1UGe+27TlhuxLyn320oDrpT4/PNoNTSXYm8= X-Received: by 2002:a67:c29e:0:b0:32d:1090:54cb with SMTP id k30-20020a67c29e000000b0032d109054cbmr108667vsj.56.1651789502928; Thu, 05 May 2022 15:25:02 -0700 (PDT) MIME-Version: 1.0 References: <20220427160016.144237-1-hannes@cmpxchg.org> <20220427160016.144237-5-hannes@cmpxchg.org> In-Reply-To: From: Suleiman Souhlal Date: Fri, 6 May 2022 07:24:51 +0900 Message-ID: Subject: Re: [PATCH 4/5] mm: zswap: add basic meminfo and vmstat coverage To: Shakeel Butt Cc: Yang Shi , Johannes Weiner , Minchan Kim , Andrew Morton , Michal Hocko , Roman Gushchin , Seth Jennings , Dan Streetman , Linux MM , Cgroups , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0ABB81C0097 X-Stat-Signature: 47jmdej7sxe8hb4gxkqr954p3p8kauwo X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=QZRowjxd; spf=pass (imf21.hostedemail.com: domain of suleiman@google.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=suleiman@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam09 X-HE-Tag: 1651789497-815741 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 6, 2022 at 4:33 AM Shakeel Butt wrote: > > On Thu, Apr 28, 2022 at 9:54 AM Yang Shi wrote: > > > [...] > > > Yes, we have some modifications to zswap to make it work without any > > > backing real swap. Though there is a future plan to move to zram > > > eventually. > > > > Interesting, if so why not just simply use zram? > > > > Historical reasons. When we started trying out the zswap, I think zram > was still in staging or not stable enough (Suleiman can give a better > answer). One of the reasons we chose zswap instead of zram is that zswap can reject pages. Also, we wanted to have per-memcg pools, which zswap made much easier to do. -- Suleiman