From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20F18C4361B for ; Thu, 17 Dec 2020 09:21:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7F4C4238E1 for ; Thu, 17 Dec 2020 09:21:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F4C4238E1 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BD9736B0036; Thu, 17 Dec 2020 04:21:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B8B6E6B005D; Thu, 17 Dec 2020 04:21:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA0D76B0068; Thu, 17 Dec 2020 04:21:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9125B6B0036 for ; Thu, 17 Dec 2020 04:21:15 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 55E36DE09 for ; Thu, 17 Dec 2020 09:21:15 +0000 (UTC) X-FDA: 77602230510.28.snake43_470126927433 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 95E2D1F0A for ; Thu, 17 Dec 2020 09:21:14 +0000 (UTC) X-HE-Tag: snake43_470126927433 X-Filterd-Recvd-Size: 4749 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Thu, 17 Dec 2020 09:21:13 +0000 (UTC) Received: by mail-lf1-f45.google.com with SMTP id l11so55617761lfg.0 for ; Thu, 17 Dec 2020 01:21:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RwEh0M4XyY2hiOmYBDj8f0F+ID8sJomDM2BqOgzIZ9k=; b=uBZ8T2nrpEWIdU8PlV1qYuUHOxEDPAmdJb5LDet6JO6Cz3ERDAf67rs5hBq83fBM5N igGk52whuX60s4CmRMpgTcPZRuDs2ZtbeP/rg94Gbj2CXW/hnGBYucnIi0WVhYx/Jyf9 kzuSdq0zMCj/nKKROWtCoxkl4g9S8fMqeW7XEKUMi24kzemDBDryvQbDzboQHrpeZvRW IzGYQFUcGU4BesoJtR+FuKBHma62SCtIoj9//XSuFvDruaYt3DBuH+1uXvESgzdC4++e J99vF46bMaqjBr6kz2WSMf5F3skwtyNx75lpjyWwsSmgoP6yV3/dG+xKtLhOlW0Wn4VK 8I2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RwEh0M4XyY2hiOmYBDj8f0F+ID8sJomDM2BqOgzIZ9k=; b=O8hrDRpq8ETLa3I17+4tPDUm/DPM/rYe5iw4CyLvEb70+Bl6WFm0e8R55SYaFtuoUv 1ApZsqjArKQsHs3PCcuDEzJHBfjAcG8ps2QyJ2XPvIn1Tz8dH6vPCf9sO1tH0ELlM4cD APPYWCkoVz3OALFG32nwFCvXf5241nnKwtsThrdvtd0Ic1NwZXDn9bXP2IfX1NNAflat 05SWhWhDGLgLS2bxqWJ++Tsbqw6KnoP6MIGUkfqzaTS3W5w4FcjI2zD8FTiTZPbdO6jT VvC32OzBfeUV64JY8Wv1ULX9u8RYxGVZQ/MFXJnbDXZFZlOCrlLgspLnhE3FaCI2sq+t /+YA== X-Gm-Message-State: AOAM5327mRyjZBuTDHo8vBbC6CyEgahPZjeYs6eMPKPKFMxJ2UCyzqD/ AQBjUTCnNo2d6bBepla6Et/d3xlyaD7DSPjJAqjVjQ== X-Google-Smtp-Source: ABdhPJzMq3Tt4wcGf7njgjSinoEyB+6xUM0htdK8AamwRCPUhE3CSyC/igc7pTw7fwbGC3nWhOEuVNPpFClSIxEYJec= X-Received: by 2002:a2e:8608:: with SMTP id a8mr16720171lji.89.1608196872037; Thu, 17 Dec 2020 01:21:12 -0800 (PST) MIME-Version: 1.0 References: <20201215204156.f05ec694b907845bcfab5c44@linux-foundation.org> <20201216044316.LYocMD9yH%akpm@linux-foundation.org> <20201216104142.GY4077@smile.fi.intel.com> In-Reply-To: <20201216104142.GY4077@smile.fi.intel.com> From: David Gow Date: Thu, 17 Dec 2020 17:21:00 +0800 Message-ID: Subject: Re: [patch 18/95] lib/list_kunit: follow new file name convention for KUnit tests To: Andy Shevchenko Cc: Linus Torvalds , Andrew Morton , Shuah Khan , Brendan Higgins , Mark Brown , Linux-MM , "Vaittinen, Matti" , mm-commits@vger.kernel.org, Vitor Massaru Iha Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 16, 2020 at 6:41 PM Andy Shevchenko wrote: > > On Wed, Dec 16, 2020 at 02:53:10PM +0800, David Gow wrote: > > On Wed, Dec 16, 2020 at 2:02 PM Linus Torvalds > > wrote: > > ... > > > > Don't send me any more rename patches until your tools can actually do renames. > > > My other thought is that this sort of patchset really makes more sense > > to push through the kselftest/kunit branch anyway, as all of the > > changes were really more KUnit related than anything else. Does it > > make sense to re-submit this that way? > > I think it makes sense because this is driven by rules set up by kselftest/kunit. > My main concern here is to have cmdline_kunit in the tree (it is a new file). > Renaming is up to you, I just wanted to be consistent with names and KUnit > documentation. It looks like the cmdline_kunit changes have been merged now, so it's a relief that those weren't held up: I agree that they're the more important changes. I do think renaming things to match the new convention is a good idea (so thanks again for doing that), but it's not exactly an urgent fix. My preference is that these get added to one of the kunit branches in the kselftest repo, so they can be picked up when convenient. This should just be the first three patches in this series: https://lore.kernel.org/linux-kselftest/20201112180732.75589-1-andriy.shevchenko@linux.intel.com/ I'd expect those to still apply pretty cleanly, but I haven't actually checked yet. Cheers, -- David